[Lldb-commits] [PATCH] D126109: [lldb] Fix broken bad-address-breakpoint test

This revision was automatically updated to reflect the committed changes. Closed by commit rG84b9985f5f63: [lldb] Fix broken bad-address-breakpoint test (authored by hawkinsw, committed by JDevlieghere). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D126109: [lldb] Fix broken bad-address-breakpoint test

hawkinsw added a comment. In D126109#3535931 , @JDevlieghere wrote: > In D126109#3534522 , @hawkinsw > wrote: > >> @DavidSpickett Thanks (again) for the feedback. Once I fix the nit, is the >> proper protocol f

[Lldb-commits] [PATCH] D126109: [lldb] Fix broken bad-address-breakpoint test

hawkinsw updated this revision to Diff 432192. hawkinsw added a comment. Updating the revision to consider feedback (!= None vs is not None) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126109/new/ https://reviews.llvm.org/D126109 Files: lldb/

[Lldb-commits] [PATCH] D126109: [lldb] Fix broken bad-address-breakpoint test

JDevlieghere added a comment. In D126109#3534522 , @hawkinsw wrote: > @DavidSpickett Thanks (again) for the feedback. Once I fix the nit, is the > proper protocol for you to review again? I am sorry to ask but I don't know > the right procedure and don'

[Lldb-commits] [PATCH] D126109: [lldb] Fix broken bad-address-breakpoint test

hawkinsw added a comment. @DavidSpickett Thanks (again) for the feedback. Once I fix the nit, is the proper protocol for you to review again? I am sorry to ask but I don't know the right procedure and don't want to do the wrong thing! Comment at: lldb/test/API/functionalitie

[Lldb-commits] [PATCH] D126109: [lldb] Fix broken bad-address-breakpoint test

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. Much clearer now, thanks. LGTM with the one nit fixed. Comment at: lldb/test/API/functionalities/breakpoint/address_breakpoints/TestBadAddressBreakpoints.py:42

[Lldb-commits] [PATCH] D126109: [lldb] Fix broken bad-address-breakpoint test

hawkinsw added a comment. @DavidSpickett Thank you for the review! I hope that this 2nd version of the patch addresses your helpful comments! Will Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126109/new/ https://reviews.llvm.org/D126109 ___

[Lldb-commits] [PATCH] D126109: [lldb] Fix broken bad-address-breakpoint test

hawkinsw updated this revision to Diff 431427. hawkinsw added a comment. Updating based on DavidSpickett helpful feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126109/new/ https://reviews.llvm.org/D126109 Files: lldb/test/API/functiona

[Lldb-commits] [PATCH] D126109: [lldb] Fix broken bad-address-breakpoint test

hawkinsw added inline comments. Comment at: lldb/test/API/functionalities/breakpoint/address_breakpoints/TestBadAddressBreakpoints.py:43 +if region.GetRegionEnd() > illegal_address: +illegal_address = region.GetRegionEnd() hawkinsw

[Lldb-commits] [PATCH] D126109: [lldb] Fix broken bad-address-breakpoint test

hawkinsw added inline comments. Comment at: lldb/test/API/functionalities/breakpoint/address_breakpoints/TestBadAddressBreakpoints.py:43 +if region.GetRegionEnd() > illegal_address: +illegal_address = region.GetRegionEnd() DavidSpic

[Lldb-commits] [PATCH] D126109: [lldb] Fix broken bad-address-breakpoint test

DavidSpickett added inline comments. Comment at: lldb/test/API/functionalities/breakpoint/address_breakpoints/TestBadAddressBreakpoints.py:43 +if region.GetRegionEnd() > illegal_address: +illegal_address = region.GetRegionEnd() Davi

[Lldb-commits] [PATCH] D126109: [lldb] Fix broken bad-address-breakpoint test

DavidSpickett added a reviewer: DavidSpickett. DavidSpickett added inline comments. Comment at: lldb/test/API/functionalities/breakpoint/address_breakpoints/TestBadAddressBreakpoints.py:43 +if region.GetRegionEnd() > illegal_address: +illegal_address

[Lldb-commits] [PATCH] D126109: [lldb] Fix broken bad-address-breakpoint test

hawkinsw created this revision. hawkinsw added reviewers: teemperor, JDevlieghere. Herald added a project: All. hawkinsw requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. After changing the "fallback" behavior when a user sets a breakpoint wi