DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land.
Much clearer now, thanks. LGTM with the one nit fixed. ================ Comment at: lldb/test/API/functionalities/breakpoint/address_breakpoints/TestBadAddressBreakpoints.py:42 + regions.GetMemoryRegionAtIndex(region_idx, region) + if illegal_address == None or \ + region.GetRegionEnd() > illegal_address: ---------------- General rule is to use `is None` instead of `== None`, though the result is the same here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126109/new/ https://reviews.llvm.org/D126109 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
