hawkinsw added a comment. @DavidSpickett Thanks (again) for the feedback. Once I fix the nit, is the proper protocol for you to review again? I am sorry to ask but I don't know the right procedure and don't want to do the wrong thing!
================ Comment at: lldb/test/API/functionalities/breakpoint/address_breakpoints/TestBadAddressBreakpoints.py:42 + regions.GetMemoryRegionAtIndex(region_idx, region) + if illegal_address == None or \ + region.GetRegionEnd() > illegal_address: ---------------- DavidSpickett wrote: > General rule is to use `is None` instead of `== None`, though the result is > the same here. Yes! I always make that error! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126109/new/ https://reviews.llvm.org/D126109 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
