DavidSpickett added a reviewer: DavidSpickett. DavidSpickett added inline comments.
================ Comment at: lldb/test/API/functionalities/breakpoint/address_breakpoints/TestBadAddressBreakpoints.py:43 + if region.GetRegionEnd() > illegal_address: + illegal_address = region.GetRegionEnd() ---------------- I'm confused as to what the logic is here now. You: * read from address 0x0 to fill in error * walk the memory regions until the highest one, making the end of that the illegal address * assume that the error value from reading 0x0 is the same as you'd get from this new illegal address ... Or am I missing something and the ptr was just left in accidentally. (I would suggest you could jump to the last region in the list straight away but I don't think we actually require them to be sorted, plus sometimes you get multiple regions with the same base) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126109/new/ https://reviews.llvm.org/D126109 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
