[Lldb-commits] [PATCH] D105215: [lldb] Remove CPlusPlusLanguage from Mangled

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG993220a99cce: [lldb] Remove CPlusPlusLanguage from Mangled (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D105215: [lldb] Remove CPlusPlusLanguage from Mangled

bulbazord added a comment. Thanks for the reviews and comments! It's kind of unfortunate that LLDB is like this right now but I believe this patch is a step in the right direction. :) Comment at: lldb/source/Core/Mangled.cpp:322 if (preference == ePreferDemangledWithoutArgu

[Lldb-commits] [PATCH] D105215: [lldb] Remove CPlusPlusLanguage from Mangled

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. I still think the "Demangled" part of the GetDemangledFunctionNameWithoutArguments is redundant. I'm not sure what sense it would make to get a mangled name without arguments? And you coul

[Lldb-commits] [PATCH] D105215: [lldb] Remove CPlusPlusLanguage from Mangled

clayborg added a comment. My comments were mostly about how we should refactor in a perfect world. Not sure we need to solve that right away. I am ok with this patch as it is if Jim is. Jim? What do you think about this patch? OK? I am good if you are. Comment at: lldb/sourc

[Lldb-commits] [PATCH] D105215: [lldb] Remove CPlusPlusLanguage from Mangled

bulbazord added inline comments. Comment at: lldb/source/Core/Mangled.cpp:322 if (preference == ePreferDemangledWithoutArguments) { -return GetDemangledNameWithoutArguments(m_mangled, demangled); +if (Language *lang = Language::FindPlugin(GuessLanguage())) { + ret

[Lldb-commits] [PATCH] D105215: [lldb] Remove CPlusPlusLanguage from Mangled

clayborg added inline comments. Comment at: lldb/source/Core/Mangled.cpp:322 if (preference == ePreferDemangledWithoutArguments) { -return GetDemangledNameWithoutArguments(m_mangled, demangled); +if (Language *lang = Language::FindPlugin(GuessLanguage())) { + retu

Re: [Lldb-commits] [PATCH] D105215: [lldb] Remove CPlusPlusLanguage from Mangled

Mostly I was reacting to your saying the "fully qualified name" idea was too much of a C++ specific thing and didn't belong in the Language abstraction. That doesn't seem to me right. Swift has module names & class namespaces, etc. And you might want to dial up all methods with some base name

[Lldb-commits] [PATCH] D105215: [lldb] Remove CPlusPlusLanguage from Mangled

bulbazord added a comment. ping! @jingham I can change the name to `GetFullyQualifiedBaseName` if needed. Is there anything else here that should be changed or addressed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105215/new/ https://reviews.l

Re: [Lldb-commits] [PATCH] D105215: [lldb] Remove CPlusPlusLanguage from Mangled

> On Jul 8, 2021, at 12:25 PM, Alex Langford via Phabricator > wrote: > > bulbazord added a comment. > > In D105215#2850988 , @jingham wrote: > >> In D105215#2850821 , @bulbazord >> wrote: >> >>> I kind of

[Lldb-commits] [PATCH] D105215: [lldb] Remove CPlusPlusLanguage from Mangled

bulbazord added a comment. In D105215#2850988 , @jingham wrote: > In D105215#2850821 , @bulbazord > wrote: > >> I kind of feel that `Language::GetDemangledFunctionNameWithoutArguments` may >> be a bit too specif

[Lldb-commits] [PATCH] D105215: [lldb] Remove CPlusPlusLanguage from Mangled

jingham added a comment. In D105215#2850821 , @bulbazord wrote: > I kind of feel that `Language::GetDemangledFunctionNameWithoutArguments` may > be a bit too specific for a generalized language plugins. I think it may be > worth it to make `Mangled` an

[Lldb-commits] [PATCH] D105215: [lldb] Remove CPlusPlusLanguage from Mangled

bulbazord added a comment. Herald added a subscriber: JDevlieghere. I kind of feel that `Language::GetDemangledFunctionNameWithoutArguments` may be a bit too specific for a generalized language plugins. I think it may be worth it to make `Mangled` an interface that language plugins can implement

[Lldb-commits] [PATCH] D105215: [lldb] Remove CPlusPlusLanguage from Mangled

bulbazord created this revision. bulbazord added reviewers: teemperor, jingham. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The only remaining plugin dependency in Mangled is CPlusPlusLanguage which it uses to extract informat