bulbazord added a comment. In D105215#2850988 <https://reviews.llvm.org/D105215#2850988>, @jingham wrote:
> In D105215#2850821 <https://reviews.llvm.org/D105215#2850821>, @bulbazord > wrote: > >> I kind of feel that `Language::GetDemangledFunctionNameWithoutArguments` may >> be a bit too specific for a generalized language plugins. I think it may be >> worth it to make `Mangled` an interface that language plugins can implement >> (e.g. `CPlusPlusMangledName`) but I haven't totally thought out what the >> ramifications of that would be yet. > > The name is unfortunate, but the notion that function types have an > identifier, that is then decorated by arguments and maybe return types, seems > pretty common. So in this particular case, maybe we just need a better name? > GetBaseName isn't right since this function also returns any namespace > information. Maybe GetFullyQualifiedBaseName? This may be my ignorance of other languages speaking, but `GetFullyQualifiedBaseName` sounds a little more specific to C++. I'm not sure if other languages use this terminology, so I tried to keep it as generic as possible. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105215/new/ https://reviews.llvm.org/D105215 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
