jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.
I still think the "Demangled" part of the
GetDemangledFunctionNameWithoutArguments is redundant. I'm not sure what sense
it would make to get a mangled name without arguments? And you could have a
language that doesn't mangle symbols but still has namespaces, classes &
overloading, for which the notion of getting the full name w/o arguments makes
sense even though no mangling/demangling is involved. But the current name
isn't horrible.
We also have a general awkwardness with demangling names using Languages
because C++ by itself is underdetermined - you really need {C++, mangling
scheme}. We just end up guessing about the mangling based on symbols - or in
this case so far as I can see we only ever handle the Itanium mangling scheme.
But this patch doesn't make that worse. So this is fine by me.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105215/new/
https://reviews.llvm.org/D105215
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
