[Lldb-commits] [PATCH] D132734: [lldb] Fix member access in GetExpressionPath

werat added a comment. In D132734#3887018 , @JDevlieghere wrote: > Thanks Will, let me apply this locally and see if that addresses the issue > for which I reverted the original patch. Hy Jonas, sorry for bumping an old thread, but did you manage to ch

[Lldb-commits] [PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

bolshakov-a updated this revision to Diff 558001. bolshakov-a added a comment. One more problem has been discovered and fixed: IR emitting didn't work when using a subobject as a template argument when the corresponding template parameter is used in an lvalue context. A test case has been added

[Lldb-commits] [PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

bolshakov-a updated this revision to Diff 557997. bolshakov-a added a comment. Fixes after review. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140996/new/ https://reviews.llvm.org/D140996 Files: clang-tools-extra/clangd/DumpAST.cpp clang-tools-extra/clangd/FindTarget.cpp clang/

[Lldb-commits] [PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

bolshakov-a added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:2205-2206 "bit-field%select{| %1}2">; +def err_reference_bind_to_bitfield_in_cce : Error< + "reference cannot bind to bit-field in converted constant expression">; def err_referen

[Lldb-commits] [PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

aaron.ballman added a comment. In D140996#4655288 , @bolshakov-a wrote: > Sorry, but I don't know what remains to be done here. It seems that the only > important question is about ABI, but I've already answered that the changes > under discussion seem

[Lldb-commits] [PATCH] D159127: [lldb][libc++] Adds chrono data formatters.

Michael137 added a comment. In D159127#4655450 , @aprantl wrote: > @Mordante @Michael137 This seems to fail on older versions of > compiler/libcxx > https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake-matrix/7247/ You > can probably fix this by

[Lldb-commits] [PATCH] D159127: [lldb][libc++] Adds chrono data formatters.

aprantl added a comment. @Mordante @Michael137 This seems to fail on older versions of compiler/libcxx https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake-matrix/7247/ You can probably fix this by just requiring a minimum clang version in the tests Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D159315: [lldb] Add OperatingSystem base class to the lldb python module

This revision was automatically updated to reflect the committed changes. Closed by commit rGec456ba9ca0a: [lldb] Add OperatingSystem base class to the lldb python module (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159315/new/ h

[Lldb-commits] [PATCH] D159314: [lldb] Introduce OperatingSystem{, Python}Interface and make use it

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7a1e8783586e: [lldb] Introduce OperatingSystem{,Python}Interface and make use it (authored by mib). Repository: rG LLVM Github Monorepo CHANGES S

[Lldb-commits] [PATCH] D159314: [lldb] Introduce OperatingSystem{, Python}Interface and make use it

mib added a comment. In D159314#4655289 , @bulbazord wrote: > Ok, makes sense to me. Since this is a refactor, I assume that the current > test suite should be enough to cover this change? @bulbazord yes! CHANGES SINCE LAST ACTION https://reviews.ll

[Lldb-commits] [PATCH] D159314: [lldb] Introduce OperatingSystem{, Python}Interface and make use it

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. Ok, makes sense to me. Since this is a refactor, I assume that the current test suite should be enough to cover this change? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159314

[Lldb-commits] [PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

bolshakov-a added a comment. Sorry, but I don't know what remains to be done here. It seems that the only important question is about ABI, but I've already answered that the changes under discussion seem to be already fixed in the Itanium ABI document. CHANGES SINCE LAST ACTION https://revie

[Lldb-commits] [PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

aaron.ballman added a comment. In D140996#4646880 , @cor3ntin wrote: > It would be nice to figure out a plan for this PR in the next few weeks, > before we get kicked out of Phab! Agreed -- @bolshakov-a are you still planning to actively work on this pa

[Lldb-commits] [PATCH] D159127: [lldb][libc++] Adds chrono data formatters.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0e4264ab1e7a: [lldb][libc++] Adds chrono data formatters. (authored by Mordante). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D159127: [lldb][libc++] Adds chrono data formatters.

Mordante added a comment. In D159127#4654774 , @Michael137 wrote: > Was looking at leftover reviews, would be nice to land this Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159127/

[Lldb-commits] [PATCH] D62732: [RISCV] Add SystemV ABI

hiraditya added a comment. Herald added subscribers: wangpc, jobnoorman, luke. We should close this as it has been pushed upstream as part of https://reviews.llvm.org/rG847de9c332775d1841fec9fea5cb5c41592a4c8f Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[Lldb-commits] [PATCH] D159314: [lldb] Introduce OperatingSystem{, Python}Interface and make use it

mib added a comment. Since @bulbazord asked me offline, all the repeat it here: Everything that was deleted here was replaced by either a call to the existing `ScriptedPythonInterface::Dispatch` method or depends on the new way to create scripted plugin objects

[Lldb-commits] [PATCH] D159314: [lldb] Introduce OperatingSystem{, Python}Interface and make us it

mib updated this revision to Diff 557856. mib marked 2 inline comments as done. mib added a comment. Address @bulbazord comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159314/new/ https://reviews.llvm.org/D159314 Files: lldb/include/lldb/Interpreter/Interfaces/OperatingSystem

[Lldb-commits] [PATCH] D158833: [lldb] Move ScriptInterpreter Interfaces to subdirectory (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG77374d3b53ce: [lldb] Move ScriptInterpreter Interfaces to subdirectory (NFC) (authored by mib). Changed prior to commit: https://reviews.llvm.org/

[Lldb-commits] [PATCH] D159310: [lldb] Move template python files to separate directory

This revision was automatically updated to reflect the committed changes. Closed by commit rG6bff2d51dcc7: [lldb] Move template python files to separate directory (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159310/new/ https://r

[Lldb-commits] [PATCH] D159127: [lldb][libc++] Adds chrono data formatters.

Michael137 accepted this revision. Michael137 added a comment. This revision is now accepted and ready to land. Was looking at leftover reviews, would be nice to land this Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159127/new/ https://reviews.ll

[Lldb-commits] [PATCH] D151919: [lldb][NFCI] Apply IndexEntry to DWARFUnitHeader outside of extraction

This revision was automatically updated to reflect the committed changes. Closed by commit rGdd76375c8009: [lldb][NFCI] Apply IndexEntry to DWARFUnitHeader outside of extraction (authored by bulbazord). Changed prior to commit: https://reviews.llvm.org/D151919?vs=529769&id=557568#toc Repositor

[Lldb-commits] [PATCH] D159550: Remove unused #include

ted added a subscriber: jasonmolenda. ted added a comment. Remove unused #include pointed out by @jasonmolenda in D159101 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159550/new/ https://reviews.llvm.org/D159550

[Lldb-commits] [PATCH] D159550: Remove unused #include

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb14153490134: Remove unused #include (authored by ted). Herald adde

[Lldb-commits] [PATCH] D159550: Remove unused #include

ted created this revision. Herald added subscribers: luke, sunshaoce, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, niosHD, sabuasal, simoncook, johnrusso, rbar, asb. Herald added a proje

[Lldb-commits] [PATCH] D159101: [RISC-V] Add RISC-V ABI plugin

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG847de9c33277: [RISC-V] Add RISC-V ABI plugin (authored by ted). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[Lldb-commits] [PATCH] D159101: [RISC-V] Add RISC-V ABI plugin

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. This looks good to me, thanks for reviving this and finishing it up. We should land before phabracator is flash frozen, we can iterate issues are found in the future. =

[Lldb-commits] [PATCH] D159101: [RISC-V] Add RISC-V ABI plugin

ted updated this revision to Diff 557323. ted marked 4 inline comments as done. ted added a comment. Fix comment about "a" registers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159101/new/ https://reviews.llvm.org/D159101 Files: lldb/source/Pl

[Lldb-commits] [PATCH] D159101: [RISC-V] Add RISC-V ABI plugin

ted updated this revision to Diff 557322. ted marked 3 inline comments as done. ted added a comment. Change "word_size = m_is_rv64 ? 8 : 4" to "word_size = reg_size" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159101/new/ https://reviews.llvm.org

[Lldb-commits] [PATCH] D159101: [RISC-V] Add RISC-V ABI plugin

ted updated this revision to Diff 557321. ted added a comment. Remove disabling JIT and enabling IR Interpreter function calls, as requested by Jason Molenda. Added default unwind plan as suggested by Jason Molenda. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[Lldb-commits] [PATCH] D159542: Lazy deference underlying object for shared/weak/unique_ptr synthetic provider

yinghuitan abandoned this revision. yinghuitan added a comment. Abandon to use the github workflow Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159542/new/ https://reviews.llvm.org/D159542 ___ lldb-comm

[Lldb-commits] [PATCH] D159542: Lazy deference underlying object for shared/weak/unique_ptr synthetic provider

yinghuitan created this revision. yinghuitan added reviewers: clayborg, labath, jingham, jdoerfert, JDevlieghere, kusmour, GeorgeHuyubo. Herald added a project: All. yinghuitan requested review of this revision. Herald added subscribers: lldb-commits, wangpc. Herald added a project: LLDB. We noti

[Lldb-commits] [PATCH] D54053: [NativePDB] Add the ability to create clang record decls from mangled names.

shafik added a comment. Herald added a project: All. Is this PR still relevant or can it be closed? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54053/new/ https://reviews.llvm.org/D54053 ___ lldb-commits mailing list lldb-commits@lists.llvm

[Lldb-commits] [PATCH] D159101: [RISC-V] Add RISC-V ABI plugin

ted added inline comments. Comment at: lldb/source/Plugins/ABI/RISCV/ABISysV_riscv.cpp:133 +ABISysV_riscv::CreateInstance(ProcessSP process_sp, const ArchSpec &arch) { + if (process_sp) { +process_sp->SetCanInterpretFunctionCalls(true); DavidSpickett wrote:

[Lldb-commits] [PATCH] D158500: [lldb][AArch64] Linux corefile support for SME

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG43812c8c87b1: [lldb][AArch64] Linux corefile support for SME (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D158500: [lldb][AArch64] Linux corefile support for SME

DavidSpickett updated this revision to Diff 557171. DavidSpickett added a comment. Remove redundant if. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158500/new/ https://reviews.llvm.org/D158500 Files: lldb/source/Plugins/Process/Utility/Registe

[Lldb-commits] [PATCH] D158500: [lldb][AArch64] Linux corefile support for SME

omjavaid accepted this revision. omjavaid added a comment. This revision is now accepted and ready to land. This looks good with just one nit above. Comment at: lldb/source/Plugins/Process/elf-core/RegisterContextPOSIXCore_arm64.cpp:74 - if (m_register_info_up->IsSVEEnabled

[Lldb-commits] [PATCH] D156774: [lldb][DWARFASTParserClang] Resolve nested types when parsing structures

Endill abandoned this revision. Endill added a comment. Moved to GitHub: https://github.com/llvm/llvm-project/pull/66879 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156774/new/ https://reviews.llvm.org/D156774 ___

[Lldb-commits] [PATCH] D157609: [lldb] Add more ways to find split DWARF files

dblaikie added a comment. In D157609#4645298 , @clayborg wrote: > In D157609#4644194 , @DavidSpickett > wrote: > >>> Any chance we could simplify this situation and have dwo searches use >>> exactly the same/sha

[Lldb-commits] [PATCH] D158663: [lldb] Fix stdcpp type summary mistakenly marked as regex (NFC)

kastiglione added a comment. Merged in https://github.com/llvm/llvm-project/pull/66949 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158663/new/ https://reviews.llvm.org/D158663 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D158663: [lldb] Fix stdcpp type summary mistakenly marked as regex (NFC)

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG56b148aa8d6f: [lldb] Fix stdcpp type summary mistakenly marked as regex (NFC) (#66949) (authored by kastiglione, committed

[Lldb-commits] [PATCH] D156774: [lldb][DWARFASTParserClang] Resolve nested types when parsing structures

Endill added a comment. @Michael137 I moved this over to GitHub , and I need your help there writing the unit test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156774/new/ https://reviews.llvm.or

[Lldb-commits] [PATCH] D154927: [lldb][AArch64] Add SME's streaming vector control register

This revision was automatically updated to reflect the committed changes. Closed by commit rGd7fab666955e: [lldb][AArch64] Add SME's streaming vector control register (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154927/n

[Lldb-commits] [PATCH] D154927: [lldb][AArch64] Add SME's streaming vector control register

omjavaid accepted this revision. omjavaid added a comment. This revision is now accepted and ready to land. This is good too. Thanks!!! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154927/new/ https://reviews.llvm.org/D154927

[Lldb-commits] [PATCH] D158500: [lldb][AArch64] Linux corefile support for SME

DavidSpickett updated this revision to Diff 557101. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158500/new/ https://reviews.llvm.org/D158500 Files: lldb/source/Plugins/Process/Utility/RegisterContextPOSIX_

[Lldb-commits] [PATCH] D154927: [lldb][AArch64] Add SME's streaming vector control register

DavidSpickett marked 2 inline comments as done. DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:1181 + + return {}; +} DavidSpickett wrote: > omjavaid wrote: > > Shouldnt we build a relevan

[Lldb-commits] [PATCH] D154927: [lldb][AArch64] Add SME's streaming vector control register

DavidSpickett updated this revision to Diff 557100. DavidSpickett added a comment. - Return error in SVCR read. - Note absence of write tests of SVCR because it's read only. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154927/new/ https://reviews.

[Lldb-commits] [PATCH] D154927: [lldb][AArch64] Add SME's streaming vector control register

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:1181 + + return {}; +} omjavaid wrote: > Shouldnt we build a relevant error message here incase ReadSMEControl fails > on ReadZAHeader I thi

[Lldb-commits] [PATCH] D154927: [lldb][AArch64] Add SME's streaming vector control register

omjavaid added a comment. Are Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:1181 + + return {}; +} Shouldnt we build a relevant error message here incase ReadSMEControl fails on ReadZAHeader Comment at:

[Lldb-commits] [PATCH] D159101: [RISC-V] Add RISC-V ABI plugin

jasonmolenda added inline comments. Comment at: lldb/source/Plugins/ABI/RISCV/ABISysV_riscv.cpp:135 +process_sp->SetCanInterpretFunctionCalls(true); +process_sp->SetCanJIT(false); + } These should not be set in the ABI, please remove these. These are pr

[Lldb-commits] [PATCH] D159101: [RISC-V] Add RISC-V ABI plugin

DavidSpickett added a comment. FYI I will be away next week, and the week after that Phab is supposed to be made read-only. So look to @jasonmolenda to approve in that time frame, or we can take this to a PR after that. Comment at: lldb/source/Plugins/ABI/RISCV/ABISysV_riscv.

[Lldb-commits] [PATCH] D159101: [RISC-V] Add RISC-V ABI plugin

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/ABI/RISCV/ABISysV_riscv.cpp:262 + // NOTE: It's unsafe to iterate through LLDB_REGNUM_GENERICs + // But the a registers re sequential in the RISC-V register space + ++reg_index; S

[Lldb-commits] [PATCH] D159101: [RISC-V] Add RISC-V ABI plugin

ted updated this revision to Diff 557049. ted added a comment. Fix crash when there was no process. Remove bugs in function call setup when using IR interpreter. Change flag tests to use lldb_private::Flags for flags testing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[Lldb-commits] [PATCH] D158514: [lldb][AArch64] Invalidate SVG prior to reconfiguring ZA regdef

DavidSpickett abandoned this revision. DavidSpickett added a comment. Moved to https://github.com/llvm/llvm-project/pull/66768. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158514/new/ https://reviews.llvm.org/D158514

[Lldb-commits] [PATCH] D158506: [lldb][AArch64] Add release notes and documentation for SME

DavidSpickett abandoned this revision. DavidSpickett added a comment. Moved to https://github.com/llvm/llvm-project/pull/66767. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158506/new/ https://reviews.llvm.org/D158506

[Lldb-commits] [PATCH] D159505: [lldb][AArch64] Add testing for SME's ZA and SVG registers

This revision was automatically updated to reflect the committed changes. Closed by commit rGe96adfd0dbcf: [lldb][AArch64] Add testing for SME's ZA and SVG registers (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159505/ne

[Lldb-commits] [PATCH] D159505: [lldb][AArch64] Add testing for SME's ZA and SVG registers

DavidSpickett updated this revision to Diff 557034. DavidSpickett added a comment. Fix some python formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159505/new/ https://reviews.llvm.org/D159505 Files: lldb/test/API/commands/register/reg

[Lldb-commits] [PATCH] D159504: [lldb][AArch64] Implement resizing of SME's ZA register

This revision was automatically updated to reflect the committed changes. Closed by commit rG46b961f36bc5: [lldb][AArch64] Implement resizing of SME's ZA register (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159504/new/

[Lldb-commits] [PATCH] D159503: [lldb][AArch64] Add SME streaming vector length pseduo register

This revision was automatically updated to reflect the committed changes. Closed by commit rGa0768b8237ad: [lldb][AArch64] Add SME streaming vector length pseduo register (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1595

[Lldb-commits] [PATCH] D159502: [lldb][AArch64] Add SME's Array Storage (ZA) register

This revision was automatically updated to reflect the committed changes. Closed by commit rGd99d9d8b74ff: [lldb][AArch64] Add SME's Array Storage (ZA) register (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159502/new/ h

[Lldb-commits] [PATCH] D159505: [lldb][AArch64] Add testing for SME's ZA and SVG registers

DavidSpickett updated this revision to Diff 557021. DavidSpickett added a comment. Clarify comment about SIGILL from inactive ZA. Fix some leftover clang-format issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159505/new/ https://reviews.llvm

[Lldb-commits] [PATCH] D159505: [lldb][AArch64] Add testing for SME's ZA and SVG registers

DavidSpickett added inline comments. Comment at: lldb/test/API/commands/register/register/aarch64_za_register/za_dynamic_resize/main.c:12 +// (this is just how ptrace works). +// * Writing to an inactive ZA produces a SIGILL. + omjavaid wrote: > Is this a kern

[Lldb-commits] [PATCH] D159505: [lldb][AArch64] Add testing for SME's ZA and SVG registers

omjavaid accepted this revision. omjavaid added a comment. This revision is now accepted and ready to land. this looks good Comment at: lldb/test/API/commands/register/register/aarch64_za_register/za_dynamic_resize/main.c:12 +// (this is just how ptrace works). +// * Writing

[Lldb-commits] [PATCH] D158514: [lldb][AArch64] Invalidate SVG prior to reconfiguring ZA regdef

DavidSpickett updated this revision to Diff 557014. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158514/new/ https://reviews.llvm.org/D158514 Files: lldb/source/Plugins/Process/gdb-remote/GDBRemoteRegisterC

[Lldb-commits] [PATCH] D158506: [lldb][AArch64] Add release notes and documentation for SME

DavidSpickett updated this revision to Diff 557013. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158506/new/ https://reviews.llvm.org/D158506 Files: lldb/docs/index.rst lldb/docs/use/aarch64-linux.rst l

[Lldb-commits] [PATCH] D158500: [lldb][AArch64] Linux corefile support for SME

DavidSpickett updated this revision to Diff 557012. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158500/new/ https://reviews.llvm.org/D158500 Files: lldb/source/Plugins/Process/Utility/RegisterContextPOSIX_

[Lldb-commits] [PATCH] D154927: [lldb][AArch64] Add SME's streaming vector control register

DavidSpickett updated this revision to Diff 557011. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154927/new/ https://reviews.llvm.org/D154927 Files: lldb/source/Plugins/Process/Linux/NativeRegisterContextLi

[Lldb-commits] [PATCH] D159505: [lldb][AArch64] Add testing for SME's ZA and SVG registers

DavidSpickett updated this revision to Diff 557010. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159505/new/ https://reviews.llvm.org/D159505 Files: lldb/test/API/commands/register/register/aarch64_dynamic

[Lldb-commits] [PATCH] D159505: [lldb][AArch64] Add testing for SME's ZA and SVG registers

DavidSpickett marked 2 inline comments as done. DavidSpickett added inline comments. Comment at: lldb/test/API/commands/register/register/aarch64_za_register/za_dynamic_resize/Makefile:3 + +CFLAGS_EXTRAS := -march=armv8-a+sve+sme -lpthread + DavidSpickett wrote:

[Lldb-commits] [PATCH] D159504: [lldb][AArch64] Implement resizing of SME's ZA register

DavidSpickett updated this revision to Diff 557009. DavidSpickett marked an inline comment as done. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159504/new/ https://reviews.llvm.org/D159504 Files: lldb/incl

[Lldb-commits] [PATCH] D159503: [lldb][AArch64] Add SME streaming vector length pseduo register

DavidSpickett updated this revision to Diff 557008. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159503/new/ https://reviews.llvm.org/D159503 Files: lldb/source/Plugins/Process/Linux/NativeRegisterContextLi

[Lldb-commits] [PATCH] D159502: [lldb][AArch64] Add SME's Array Storage (ZA) register

DavidSpickett updated this revision to Diff 557007. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159502/new/ https://reviews.llvm.org/D159502 Files: lldb/include/lldb/Utility/RegisterValue.h lldb/source/P

[Lldb-commits] [PATCH] D159505: [lldb][AArch64] Add testing for SME's ZA and SVG registers

DavidSpickett added inline comments. Comment at: lldb/test/API/commands/register/register/aarch64_dynamic_regset/TestArm64DynamicRegsets.py:201 +self.runCmd("register write za '{}'".format(za_value)) +self.expect("register read za", substrs=[za_value]) --

[Lldb-commits] [PATCH] D159505: [lldb][AArch64] Add testing for SME's ZA and SVG registers

omjavaid added inline comments. Comment at: lldb/test/API/commands/register/register/aarch64_dynamic_regset/TestArm64DynamicRegsets.py:201 +self.runCmd("register write za '{}'".format(za_value)) +self.expect("register read za", substrs=[za_value]) ---

[Lldb-commits] [PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

cor3ntin added a comment. It would be nice to figure out a plan for this PR in the next few weeks, before we get kicked out of Phab! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140996/new/ https://reviews.llvm.org/D140996 ___ lldb-commits

[Lldb-commits] [PATCH] D159504: [lldb][AArch64] Implement resizing of SME's ZA register

omjavaid accepted this revision. omjavaid added a comment. This revision is now accepted and ready to land. This look good Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159504/new/ https://reviews.llvm.org/D159504 _

[Lldb-commits] [PATCH] D159503: [lldb][AArch64] Add SME streaming vector length pseduo register

omjavaid accepted this revision. omjavaid added a comment. This revision is now accepted and ready to land. This is LGTM as you suggested pending child reviews. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159503/new/ https://reviews.llvm.org/D159

[Lldb-commits] [PATCH] D159505: [lldb][AArch64] Add testing for SME's ZA and SVG registers

DavidSpickett added a comment. I'll hold off landing any of the prior patches until this is reviewed, in case I have to go back and move things. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159505/new/ https://reviews.llvm.org/D159505 __

[Lldb-commits] [PATCH] D158506: [lldb][AArch64] Add release notes and documentation for SME

DavidSpickett updated this revision to Diff 556856. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158506/new/ https://reviews.llvm.org/D158506 Files: lldb/docs/index.rst lldb/docs/use/aarch64-linux.rst l

[Lldb-commits] [PATCH] D158500: [lldb][AArch64] Linux corefile support for SME

DavidSpickett updated this revision to Diff 556855. DavidSpickett added a comment. sme_regs -> sme_pseudo_regs and rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158500/new/ https://reviews.llvm.org/D158500 Files: lldb/source/Plugins/Proc

[Lldb-commits] [PATCH] D154927: [lldb][AArch64] Add SME's streaming vector control register

DavidSpickett updated this revision to Diff 556854. DavidSpickett added a comment. Rebase, use new sme_pseudo_regs naming. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154927/new/ https://reviews.llvm.org/D154927 Files: lldb/source/Plugins/Proc

[Lldb-commits] [PATCH] D159505: [lldb][AArch64] Add testing for SME's ZA and SVG registers

DavidSpickett updated this revision to Diff 556853. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159505/new/ https://reviews.llvm.org/D159505 Files: lldb/test/API/commands/register/register/aarch64_dynamic

[Lldb-commits] [PATCH] D159504: [lldb][AArch64] Implement resizing of SME's ZA register

DavidSpickett marked an inline comment as done. DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.cpp:839 + +void GDBRemoteDynamicRegisterInfo::UpdateARM64SMERegistersInfos(uint64_t svg) { + for (auto ® : m_regs) {

[Lldb-commits] [PATCH] D159504: [lldb][AArch64] Implement resizing of SME's ZA register

DavidSpickett updated this revision to Diff 556852. DavidSpickett added a comment. Combine reconfigure into one function. The tricky thing is we have to read svg and vg up front because we can't read registers while we're messing with register offsets. Otherwise, the result is a bit clearer and i

[Lldb-commits] [PATCH] D159503: [lldb][AArch64] Add SME streaming vector length pseduo register

DavidSpickett updated this revision to Diff 556851. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159503/new/ https://reviews.llvm.org/D159503 Files: lldb/source/Plugins/Process/Linux/NativeRegisterContextLi

[Lldb-commits] [PATCH] D159503: [lldb][AArch64] Add SME streaming vector length pseduo register

DavidSpickett added a comment. Note that GetSMEOffset refers to the whole register set which does include ZA, so no change of name there. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159503/new/ https://reviews.llvm.org/D159503 _

[Lldb-commits] [PATCH] D159503: [lldb][AArch64] Add SME streaming vector length pseduo register

DavidSpickett marked 2 inline comments as done. DavidSpickett added a comment. Will apply the rename in core files as well later. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159503/new/ https://reviews.llvm.org/D159503 __

[Lldb-commits] [PATCH] D159503: [lldb][AArch64] Add SME streaming vector length pseduo register

DavidSpickett updated this revision to Diff 556844. DavidSpickett added a comment. - sme_regs -> sme_pseudo_regs, also changed the accesor method names. - clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159503/new/ https://reviews.llvm.o

[Lldb-commits] [PATCH] D159504: [lldb][AArch64] Implement resizing of SME's ZA register

omjavaid added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.cpp:839 + +void GDBRemoteDynamicRegisterInfo::UpdateARM64SMERegistersInfos(uint64_t svg) { + for (auto ® : m_regs) { can we combine UpdateARM64SVERegiste

[Lldb-commits] [PATCH] D159503: [lldb][AArch64] Add SME streaming vector length pseduo register

omjavaid added a comment. This looks find just couple of nits inline. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:354 + + // ZA is part of the SME set but uses a seperate member buffer for storage. + // Therefore its effective

[Lldb-commits] [PATCH] D159502: [lldb][AArch64] Add SME's Array Storage (ZA) register

omjavaid accepted this revision. omjavaid added a comment. This revision is now accepted and ready to land. This is LGTM. Thanks for your patience. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159502/new/ https://reviews.llvm.org/D159502

[Lldb-commits] [PATCH] D159313: [lldb][NFCI] Remove use of ConstString in StructuredData

This revision was automatically updated to reflect the committed changes. Closed by commit rGa5a2a5a3eca0: [lldb][NFCI] Remove use of ConstString in StructuredData (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159313/new/ ht

[Lldb-commits] [PATCH] D159313: [lldb][NFCI] Remove use of ConstString in StructuredData

fdeazeve accepted this revision. fdeazeve added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159313/new/ https://reviews.llvm.org/D159313 __

[Lldb-commits] [PATCH] D159313: [lldb][NFCI] Remove use of ConstString in StructuredData

bulbazord updated this revision to Diff 556798. bulbazord added a comment. Remove unneeded lambda Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159313/new/ https://reviews.llvm.org/D159313 Files: lldb/include/lldb/Utility/StructuredData.h lldb

[Lldb-commits] [PATCH] D159313: [lldb][NFCI] Remove use of ConstString in StructuredData

bulbazord added inline comments. Comment at: lldb/source/Utility/StructuredData.cpp:249-251 + llvm::sort(sorted_entries, [&](const Entry &lhs, const Entry &rhs) -> bool { +return lhs.first < rhs.first; + }); Oh I can remove this lambda too -- Let me update.

[Lldb-commits] [PATCH] D159011: [lldb][NFCI] Remove use of ConstString from UnixSignals

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2f377c5bd713: [lldb][NFCI] Remove use of ConstString from UnixSignals (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D159011: [lldb][NFCI] Remove use of ConstString from UnixSignals

fdeazeve accepted this revision. fdeazeve added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159011/new/ https://reviews.llvm.org/D159011 ___ lldb-commits mailing list lldb-commits@list

[Lldb-commits] [PATCH] D158514: [lldb][AArch64] Invalidate SVG prior to reconfiguring ZA regdef

DavidSpickett updated this revision to Diff 556759. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158514/new/ https://reviews.llvm.org/D158514 Files: lldb/source/Plugins/Process/gdb-remote/GDBRemoteRegisterC

[Lldb-commits] [PATCH] D158506: [lldb][AArch64] Add release notes and documentation for SME

DavidSpickett updated this revision to Diff 556758. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158506/new/ https://reviews.llvm.org/D158506 Files: lldb/docs/index.rst lldb/docs/use/aarch64-linux.rst l

[Lldb-commits] [PATCH] D158500: [lldb][AArch64] Linux corefile support for SME

DavidSpickett updated this revision to Diff 556757. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158500/new/ https://reviews.llvm.org/D158500 Files: lldb/source/Plugins/Process/Utility/RegisterContextPOSIX_

  1   2   3   4   5   6   7   8   9   10   >