DavidSpickett added a comment.

FYI I will be away next week, and the week after that Phab is supposed to be 
made read-only. So look to @jasonmolenda to approve in that time frame, or we 
can take this to a PR after that.



================
Comment at: lldb/source/Plugins/ABI/RISCV/ABISysV_riscv.cpp:133
+ABISysV_riscv::CreateInstance(ProcessSP process_sp, const ArchSpec &arch) {
+  if (process_sp) {
+    process_sp->SetCanInterpretFunctionCalls(true);
----------------
Do you know why this check is needed? Is there a specific test that hits this?

The other ABI plugins seem to sidestep this by not having to `->` on it, but 
that could just be luck.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159101/new/

https://reviews.llvm.org/D159101

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to