mib added a comment. Since @bulbazord asked me offline, all the repeat it here: Everything that was deleted here was replaced by either a call to the existing `ScriptedPythonInterface::Dispatch` method or depends on the new way to create scripted plugin objects <https://github.com/llvm/llvm-project/pull/68052>.
================ Comment at: lldb/source/Plugins/OperatingSystem/Python/OperatingSystemPython.cpp:112-114 + // return llvm::createStringError( + // llvm::inconvertibleErrorCode(), + // "Failed to create scripted thread interface."); ---------------- bulbazord wrote: > nit: Remove commented out code. > > side note, maybe OperatingSystemPython should have a static factory method so > we can actually return a meaningful error like this? Since the constructor > can fail, we might end up with a half-initialized object. Doesn't have to be > in this change, I think it would make sense for a follow-up. I added a `// FIXME:` and I'll do the error handling in a followup. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159314/new/ https://reviews.llvm.org/D159314 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
