DavidSpickett added inline comments.
================
Comment at:
lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:1181
+
+ return {};
+}
----------------
omjavaid wrote:
> Shouldnt we build a relevant error message here incase ReadSMEControl fails
> on ReadZAHeader
I think this should be `return error` in fact, let me check what that does.
================
Comment at:
lldb/test/API/commands/register/register/aarch64_za_register/za_save_restore/TestZARegisterSaveRestore.py:183
+ self.expect("register read svcr",
substrs=["0x{:016x}".format(svcr_value)])
for expr in exprs:
----------------
omjavaid wrote:
> should we also add a svcr write test here?
It's read only. We could allow writes but it introduces a lot more ways to
change state, most of which aren't obviously useful for the user. If someone
really wants it, it can be added.
I will note this in a comment here.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D154927/new/
https://reviews.llvm.org/D154927
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
