[Lldb-commits] [PATCH] D158663: [lldb] Fix stdcpp type summary mistakenly marked as regex (NFC)

kastiglione added a comment. Merged in https://github.com/llvm/llvm-project/pull/66949 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158663/new/ https://reviews.llvm.org/D158663 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D159142: [lldb] Add support for recognizing swift ast sections in object files

kastiglione added inline comments. Comment at: lldb/source/Core/Section.cpp:153 + case eSectionTypeSwiftModules: +return "swift-modules"; } I wonder if this should be "swiftmodules". I have never seen it spelled with a hyphen. Repository: rG LLVM Git

[Lldb-commits] [PATCH] D159127: [lldb][libc++] Adds chrono data formatters.

kastiglione added a comment. Thanks for doing this! Question to all: Should the summary string include the unit? lldb doesn't always show the type, so it could help comprehension if the unit is included. For example `60s` instead of `60`. Comment at: lldb/source/Plugins/Lang

[Lldb-commits] [PATCH] D158663: [lldb] Fix stdcpp type summary mistakenly marked as regex (NFC)

kastiglione created this revision. kastiglione added a reviewer: jingham. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. `std::basic_string` is not a regex, and treating it as such could unintentio

[Lldb-commits] [PATCH] D157041: [lldb] Protect OptionValue accesses from data races

kastiglione added inline comments. Comment at: lldb/source/Interpreter/OptionValue.cpp:49 + std::lock_guard lock(m_mutex); if (GetType() == OptionValue::eTypeBoolean) return static_cast(this); do these GetAsX functions need to lock? Repository: rG LL

[Lldb-commits] [PATCH] D157041: [lldb] Protect OptionValue accesses from data races

kastiglione added inline comments. Comment at: lldb/source/Interpreter/OptionValue.cpp:41 llvm::StringRef value) { + std::lock_guard lock(m_mutex); Status error; this one doesn't need a lock Comment at: lldb

[Lldb-commits] [PATCH] D152837: [lldb] Identify Swift-implemented ObjC classes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe19339f5f8c1: [lldb] Identify Swift-implemented ObjC classes (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[Lldb-commits] [PATCH] D152837: [lldb] Identify Swift-implemented ObjC classes

kastiglione updated this revision to Diff 542169. kastiglione added a comment. Redo ValueObjectDynamicValue::UpdateValue changes based on upstream testing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152837/new/ https://reviews.llvm.org/D152837 F

[Lldb-commits] [PATCH] D152837: [lldb] Identify Swift-implemented ObjC classes

kastiglione updated this revision to Diff 539359. kastiglione added a comment. Change `bool IsSwift()` to `LanguageType GetImplementationLanguage()` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152837/new/ https://reviews.llvm.org/D152837 Files:

[Lldb-commits] [PATCH] D152837: [lldb] Identify Swift-implemented ObjC classes

kastiglione added a comment. @bulbazord @augusto2112 hopefully this is a quick review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152837/new/ https://reviews.llvm.org/D152837 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D152837: [lldb] Identify Swift-implemented ObjC classes

kastiglione updated this revision to Diff 539268. kastiglione added a comment. Refactor for better API layering Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152837/new/ https://reviews.llvm.org/D152837 Files: lldb/include/lldb/Target/LanguageRu

[Lldb-commits] [PATCH] D153489: [lldb] Print hint if object description is requested but not implemented

kastiglione added inline comments. Comment at: lldb/source/Commands/CommandObjectDWIMPrint.cpp:133-135 + << "note: object description requested, but type doesn't implement " + "a custom object description. Consider using \"p\" instead of " + "\"po

[Lldb-commits] [PATCH] D153489: [lldb] Print hint if object description is requested but not implemented

kastiglione added inline comments. Comment at: lldb/include/lldb/Target/Target.h:496 + std::once_flag target_once_flag; // These two functions fill out the Broadcaster interface: did you mean to use this, or should it be deleted? Comment

[Lldb-commits] [PATCH] D154128: [lldb] Add log indicating which kind of data formatter

This revision was automatically updated to reflect the committed changes. Closed by commit rGb43375bb8195: [lldb] Add log indicating which kind of data formatter (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154128/new/ ht

[Lldb-commits] [PATCH] D153802: [lldb] Delete RewriteObjCClassReferences (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG2c37cbef5821: [lldb] Delete RewriteObjCClassReferences (NFC) (authored by kastiglione). Changed prior to commit: https://reviews.llvm.org/D153802?vs=534693&id=536439#toc Repository: rG LLVM Github Mo

[Lldb-commits] [PATCH] D154128: [lldb] Add log indicating which kind of data formatter

kastiglione updated this revision to Diff 536348. kastiglione added a comment. Remove __FUNCTION__ from FormatManager logs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154128/new/ https://reviews.llvm.org/D154128 Files: lldb/source/DataFormatte

[Lldb-commits] [PATCH] D154128: [lldb] Add log indicating which kind of data formatter

kastiglione updated this revision to Diff 536305. kastiglione added a comment. Restore `static_cast()` because of `-Wformat-pedantic` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154128/new/ https://reviews.llvm.org/D154128 Files: lldb/source/D

[Lldb-commits] [PATCH] D154128: [lldb] Add log indicating which kind of data formatter

kastiglione updated this revision to Diff 536300. kastiglione added a comment. Include formatter kind ("format", "summary", "synthetic") to FormatManager logs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154128/new/ https://reviews.llvm.org/D15412

[Lldb-commits] [PATCH] D154128: [lldb] Add log indicating which kind of data formatter

kastiglione added a comment. I just test gave `__PRETTY_FUNCTION__` a test drive, and it's a bit verbose/noisy: For example: [ImplSP lldb_private::FormatManager::Get(lldb_private::ValueObject &, lldb::DynamicValueType) [ImplSP = std::shared_ptr]] Begin synthetic lookup. Here's an example of

[Lldb-commits] [PATCH] D154128: [lldb] Add log indicating which kind of data formatter

kastiglione created this revision. kastiglione added reviewers: jingham, augusto2112. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The `formatter` logs include a function name, but these functions

[Lldb-commits] [PATCH] D153922: [lldb] Duplicate Target::Launch resuming logic into CommandObjectPlatformProcessLaunch

kastiglione added inline comments. Comment at: lldb/source/Commands/CommandObjectPlatform.cpp:1232 + +assert(launch_info.GetHijackListener()); + DavidSpickett wrote: > DavidSpickett wrote: > > This assert fails on Linux. Is it necessary or should I look i

[Lldb-commits] [PATCH] D153489: [lldb] Print hint if object description is requested but not implemented

kastiglione added inline comments. Comment at: lldb/source/Commands/CommandObjectDWIMPrint.h:46-51 + /// Add a hint if object description was requested, but no description + /// function was implemented, and dump valobj to output_stream after. + static void MaybeAddPoHintAndDu

[Lldb-commits] [PATCH] D153489: [lldb] Print hint if object description is requested but not implemented

kastiglione added a comment. > I wonder if we should hint in all 3 command objects (expr, frame var and > DWIM) or if we should limit this to DWIM instead (since DWIM is the one > aliased to p and po and I don't think vo or expr -O are often used > unintentionally). I missed this comment. My i

[Lldb-commits] [PATCH] D153489: [lldb] Print hint if object description is requested but not implemented

kastiglione added inline comments. Comment at: lldb/source/Commands/CommandObjectDWIMPrint.cpp:81-83 +<< "note: object description requested, but type doesn't implement " + "a custom object description. Consider using \"p\" instead of " + "\"po\"\n"; -

[Lldb-commits] [PATCH] D98653: [lldb] Refactor variable paths to support languages with non-pointer "this" (NFC)

kastiglione abandoned this revision. kastiglione added a comment. Herald added a subscriber: Michael137. Herald added a project: All. This was superseded by D145276 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98

[Lldb-commits] [PATCH] D153636: [LLDB] Fix the use of "platform process launch" with no extra arguments

kastiglione added inline comments. Comment at: lldb/test/API/commands/platform/process/launch/TestPlatformProcessLaunch.py:50 +self.runCmd("settings set target.run-args D E") +self.runCmd("platform process launch --stdout {}".format(outfile)) +self.runCmd

[Lldb-commits] [PATCH] D153922: [lldb] Duplicate Target::Launch resuming logic into CommandObjectPlatformProcessLaunch

This revision was automatically updated to reflect the committed changes. Closed by commit rG86fd957af981: [lldb] Duplicate Target::Launch resuming logic into… (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153922/new/ http

[Lldb-commits] [PATCH] D153636: [LLDB] Fix the use of "platform process launch" with no extra arguments

kastiglione added a subscriber: jingham. kastiglione added a comment. Thanks to @jingham's help in identifying this issue, I have opened https://reviews.llvm.org/D153922 as a potential fix for the issue on macOS. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[Lldb-commits] [PATCH] D153922: [lldb] Duplicate Target::Launch resuming logic into CommandObjectPlatformProcessLaunch

kastiglione created this revision. kastiglione added reviewers: jingham, DavidSpickett. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Fix `platform process launch` on macOS where it fails for lack

[Lldb-commits] [PATCH] D153636: [LLDB] Fix the use of "platform process launch" with no extra arguments

kastiglione added inline comments. Comment at: lldb/test/API/commands/platform/process/launch/TestPlatformProcessLaunch.py:50 +self.runCmd("settings set target.run-args D E") +self.runCmd("platform process launch --stdout {}".format(outfile)) +self.runCmd

[Lldb-commits] [PATCH] D153636: [LLDB] Fix the use of "platform process launch" with no extra arguments

kastiglione added a comment. I will try to reproduce. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153636/new/ https://reviews.llvm.org/D153636 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D153802: [lldb] Delete RewriteObjCClassReferences (NFC)

kastiglione created this revision. kastiglione added reviewers: augusto2112, bulbazord. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The `RewriteObjCClassReferences` pass was applicable only to th

[Lldb-commits] [PATCH] D153648: [lldb] Remove broken shared cache duplicate class handling

kastiglione added a comment. In D153648#898 , @jingham wrote: > and that the one that won will indeed be in that list but will not be marked > as a duplicate. All of the duplicate classes are in the duplicate list, not a single class that won. For

[Lldb-commits] [PATCH] D153648: [lldb] Remove broken shared cache duplicate class handling

kastiglione created this revision. kastiglione added reviewers: JDevlieghere, jingham, bulbazord. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The shared cache list of ObjC classes contains classe

[Lldb-commits] [PATCH] D153088: [lldb] De-virtualize applicable functions in ValueObject (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rGf2a1320c2ff5: [lldb] De-virtualize applicable functions in ValueObject (NFC) (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153088/

[Lldb-commits] [PATCH] D153088: [lldb] De-virtualize applicable functions in ValueObject (NFC)

kastiglione created this revision. kastiglione added reviewers: bulbazord, jingham. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Remove `virtual` from `ValueObject` functions that aren't overridde

[Lldb-commits] [PATCH] D152031: [lldb] Default can_create to true in GetChildAtIndex (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rGa1a74f7cdea3: [lldb] Default can_create to true in GetChildAtIndex (NFC) (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152031/new/

[Lldb-commits] [PATCH] D151966: [lldb] Default can_create to true in GetChildMemberWithName (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG7d4fcd411b3d: [lldb] Default can_create to true in GetChildMemberWithName (NFC) (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1519

[Lldb-commits] [PATCH] D152837: [lldb] Identify Swift-implemented ObjC classes

kastiglione added inline comments. Comment at: lldb/source/Core/ValueObjectDynamicValue.cpp:119-123 +if (auto *runtime = llvm::dyn_cast_or_null( +process->GetLanguageRuntime(lldb::eLanguageTypeObjC))) + if (auto class_sp = runtime->GetClassDescriptor(valobj))

[Lldb-commits] [PATCH] D152837: [lldb] Identify Swift-implemented ObjC classes

kastiglione created this revision. kastiglione added reviewers: aprantl, jingham, augusto2112. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Classes implemented in Swift can be exposed to ObjC. For

[Lldb-commits] [PATCH] D152569: [lldb] Introduce a tool to quickly generate projects with an arbitrary number of sources

kastiglione added inline comments. Comment at: lldb/scripts/generate-project.py:21 +def generate_c_header(directory: str, index: int) -> None: +header_path = f"{directory}/obj{index}.h" +with open(header_path, "w") as f: kastiglione wrote: > os.path.join

[Lldb-commits] [PATCH] D152569: [lldb] Introduce a tool to quickly generate projects with an arbitrary number of sources

kastiglione added inline comments. Comment at: lldb/scripts/generate-project.py:21 +def generate_c_header(directory: str, index: int) -> None: +header_path = f"{directory}/obj{index}.h" +with open(header_path, "w") as f: os.path.join to be windows friendl

[Lldb-commits] [PATCH] D152590: Streamline expression parser error messages

kastiglione added inline comments. Herald added a subscriber: Michael137. Comment at: lldb/source/Interpreter/CommandReturnObject.cpp:104 return; - error(GetErrorStream()) << in_string.rtrim() << '\n'; + // Workaround to deal with already fully formatted compiler diagnosti

[Lldb-commits] [PATCH] D152569: [lldb] Introduce a tool to quickly generate projects with an arbitrary number of sources

kastiglione added inline comments. Comment at: lldb/scripts/generate-project.py:69 +f.write(" {\n") +f.write(f" print(\"{index}\")\n") +f.write("}\n") Comment at: lldb/scripts/generate-project.py:116 +f.write("

[Lldb-commits] [PATCH] D152569: [lldb] Introduce a tool to quickly generate projects with an arbitrary number of sources

kastiglione added inline comments. Comment at: lldb/scripts/generate-project.py:175 +# Building Objects and their respective swiftmodule +f.write(f"$(OBJDIR)/%.o: %.swift objdir\n") +f.write("\t$(SWIFT_FE) -c -primary-file $< -I objs/ \\\n") --

[Lldb-commits] [PATCH] D152569: [lldb] Introduce a tool to quickly generate projects with an arbitrary number of sources

kastiglione added inline comments. Comment at: lldb/scripts/generate-project.py:118-126 +f.write(f" $(OBJDIR)/main.o\n") +f.write("\n") +f.write("all: many-objects\n") +f.write("objdir:\n") +f.write("\tmkdir -p $(OBJDIR)\n") +f.wri

[Lldb-commits] [PATCH] D151950: [lldb] Unconditionally increment depth when printing children

kastiglione accepted this revision. kastiglione added a comment. This revision is now accepted and ready to land. thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151950/new/ https://reviews.llvm.org/D151950 __

[Lldb-commits] [PATCH] D151950: [lldb] Unconditionally increment depth when printing children

kastiglione added a comment. +1 to a test thanks for the fix! Comment at: lldb/source/DataFormatters/ValueObjectPrinter.cpp:593 const DumpValueObjectOptions::PointerDepth &curr_ptr_depth) { - const uint32_t consumed_depth = (!m_options.m_pointer_as_array) ? 1 : 0; + con

[Lldb-commits] [PATCH] D151966: [lldb] Default can_create to true in GetChildMemberWithName (NFC)

kastiglione added a comment. To expand the conversation, I have also opened D152031 which makes the same change to `GetChildAtIndex`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151966/new/ https://reviews.llv

[Lldb-commits] [PATCH] D152031: [lldb] Default can_create to true in GetChildAtIndex (NFC)

kastiglione created this revision. kastiglione added reviewers: bulbazord, jingham. Herald added a subscriber: arphaman. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Existing callers of `GetChildA

[Lldb-commits] [PATCH] D151966: [lldb] Default can_create to true in GetChildMemberWithName (NFC)

kastiglione added a comment. correction: there's still an overload of `GetChildAtNamePath`, which takes a can_create value and passes it through to `GetChildMemberWithName`. However that function isn't used, and could be deleted. To delete the parameter, that overload of `GetChildMemberWithName

[Lldb-commits] [PATCH] D152010: [lldb][NFCI] ConstString methods should take StringRefs by value

kastiglione added inline comments. Comment at: lldb/source/Utility/ConstString.cpp:305 -void ConstString::SetString(const llvm::StringRef &s) { - m_string = StringPool().GetConstCStringWithLength(s.data(), s.size()); +void ConstString::SetString(const llvm::StringRef s) { + m

[Lldb-commits] [PATCH] D152010: [lldb][NFCI] ConstString methods should take StringRefs by value

kastiglione added inline comments. Herald added a subscriber: JDevlieghere. Comment at: lldb/source/Utility/ConstString.cpp:305 -void ConstString::SetString(const llvm::StringRef &s) { - m_string = StringPool().GetConstCStringWithLength(s.data(), s.size()); +void ConstString::

[Lldb-commits] [PATCH] D151966: [lldb] Default can_create to true in GetChildMemberWithName (NFC)

kastiglione created this revision. kastiglione added reviewers: jingham, bulbazord. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. It turns out all existing callers of `GetChildMemberWithName` pass

[Lldb-commits] [PATCH] D151813: [lldb] Take StringRef names in GetChildAtNamePath (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG00e52cc4a8cc: [lldb] Take StringRef names in GetChildAtNamePath (NFC) (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151813/new/ h

[Lldb-commits] [PATCH] D151813: [lldb] Take StringRef names in GetChildAtNamePath (NFC)

kastiglione updated this revision to Diff 527715. kastiglione added a comment. Change auto to StringRef Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151813/new/ https://reviews.llvm.org/D151813 Files: lldb/include/lldb/Core/ValueObject.h lldb

[Lldb-commits] [PATCH] D151811: [lldb] Take StringRef name in GetIndexOfChildWithName (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG5dae706259da: [lldb] Take StringRef name in GetIndexOfChildWithName (NFC) (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151811/new

[Lldb-commits] [PATCH] D151811: [lldb] Take StringRef name in GetIndexOfChildWithName (NFC)

kastiglione added inline comments. Comment at: lldb/source/Core/ValueObjectSyntheticFilter.cpp:338 if (!did_find && m_synth_filter_up != nullptr) { uint32_t index = m_synth_filter_up->GetIndexOfChildWithName(name); if (index == UINT32_MAX) Michael137

[Lldb-commits] [PATCH] D151810: [lldb] Take StringRef name in GetIndexOfChildMemberWithName (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG57c122d0ea1d: [lldb] Take StringRef name in GetIndexOfChildMemberWithName (NFC) (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1518

[Lldb-commits] [PATCH] D151813: [lldb] Take StringRef names in GetChildAtNamePath (NFC)

kastiglione added inline comments. Comment at: lldb/source/Core/ValueObject.cpp:434 ValueObjectSP root(GetSP()); - for (ConstString name : names) { + for (auto name : names) { root = root->GetChildMemberWithName(name, true); bulbazord wrote: > kastiglio

[Lldb-commits] [PATCH] D151813: [lldb] Take StringRef names in GetChildAtNamePath (NFC)

kastiglione added inline comments. Comment at: lldb/include/lldb/Core/ValueObject.h:483 // this will always create the children if necessary - lldb::ValueObjectSP GetChildAtNamePath(llvm::ArrayRef names, - ConstString *name_of_error = n

[Lldb-commits] [PATCH] D151813: [lldb] Take StringRef names in GetChildAtNamePath (NFC)

kastiglione created this revision. kastiglione added reviewers: bulbazord, jingham. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Following D151810 , this changes

[Lldb-commits] [PATCH] D151811: [lldb] Take StringRef name in GetIndexOfChildWithName (NFC)

kastiglione created this revision. kastiglione added reviewers: bulbazord, jingham. Herald added a subscriber: arphaman. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. As with D151615

[Lldb-commits] [PATCH] D151810: [lldb] Take StringRef name in GetIndexOfChildMemberWithName (NFC)

kastiglione created this revision. kastiglione added reviewers: bulbazord, jingham. Herald added a subscriber: arphaman. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Change the type of the `name`

[Lldb-commits] [PATCH] D151384: [lldb] Override GetVariable in ValueObjectSynthetic (NFC)

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG7578672c96e1: [lldb] Override GetVariable in ValueObjectSynthetic (NFC) (authored by kastiglione). Repository: rG LLVM

[Lldb-commits] [PATCH] D151384: [lldb] Override GetVariable in ValueObjectSynthetic (NFC)

kastiglione added a comment. Jim approved offline. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151384/new/ https://reviews.llvm.org/D151384 ___ lldb-commits mailing list lldb-commits@lists.llvm.org htt

[Lldb-commits] [PATCH] D151615: [lldb] Take StringRef name in GetChildMemberWithName (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rGcb463c34dd4c: [lldb] Take StringRef name in GetChildMemberWithName (NFC) (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151615/new/

[Lldb-commits] [PATCH] D151351: [lldb] Prevent dwim-print from showing kNoResult error

This revision was automatically updated to reflect the committed changes. Closed by commit rG061a839033dc: [lldb] Prevent dwim-print from showing kNoResult error (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151351/new/ ht

[Lldb-commits] [PATCH] D151748: [lldb] Consult summary provider before printing children of root references

This revision was automatically updated to reflect the committed changes. Closed by commit rGc7eb1b07470b: [lldb] Consult summary provider before printing children of root references (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[Lldb-commits] [PATCH] D151748: [lldb] Consult summary provider before printing children of root references

kastiglione created this revision. kastiglione added reviewers: jingham, bulbazord, aprantl, Michael137. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. When printing the root of a value, if it's a r

[Lldb-commits] [PATCH] D151615: [lldb] Change GetChildMemberWithName to take a StringRef, not ConstString

kastiglione added a comment. In D151615#4378130 , @bulbazord wrote: > It may or may not have a measurable impact on performance, but my bet is that > it doesn't make it worse. yes the reason I wanted this change is for ergonomics, I was annoyed that it

[Lldb-commits] [PATCH] D151615: [lldb] Change GetChildMemberWithName to take a StringRef, not ConstString

kastiglione created this revision. kastiglione added reviewers: bulbazord, jingham. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. `GetChildMemberWithName` does not need a `ConstString`. This change

[Lldb-commits] [PATCH] D151384: [lldb] Override GetVariable in ValueObjectSynthetic (NFC)

kastiglione created this revision. kastiglione added a reviewer: jingham. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Make `GetVariable` a passthrough function the the underlying value object in

[Lldb-commits] [PATCH] D151351: [lldb] Prevent dwim-print from showing kNoResult error

kastiglione created this revision. kastiglione added reviewers: aprantl, jingham. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Expression evaluation for `void` valued expressions sets an error usi

[Lldb-commits] [PATCH] D146765: [lldb/crashlog] Load inlined symbol into interactive crashlog

kastiglione added inline comments. Comment at: lldb/examples/python/crashlog.py:703 +symbol = ( +r'(?: +(?:' # spaces and + sign +r'(.+)' # symbol name this is just "spaces", not "spaces and + si

[Lldb-commits] [PATCH] D150619: [lldb] Delay removal of persistent results

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGdb814552132d: [lldb] Delay removal of persistent results (authored by kastiglione). Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D150619: [lldb] Delay removal of persistent results

kastiglione added a comment. thank you @jingham, that is great feedback! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150619/new/ https://reviews.llvm.org/D150619 ___ lldb-commits mailing list lldb-comm

[Lldb-commits] [PATCH] D150619: [lldb] Delay removal of persistent results

kastiglione updated this revision to Diff 522875. kastiglione added a comment. - Explicitly control expression evaluation options for suppressing persistent result - Use the ValueObject's display language instead of the CU or frame's language Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D150619: [lldb] Delay removal of persistent results

kastiglione added a comment. s/frame pointer/pointer to StackFrame/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150619/new/ https://reviews.llvm.org/D150619 ___ lldb-commits mailing list lldb-commits@l

[Lldb-commits] [PATCH] D150619: [lldb] Delay removal of persistent results

kastiglione updated this revision to Diff 522384. kastiglione added a comment. check frame pointer before calling GuessLanguage Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150619/new/ https://reviews.llvm.org/D150619 Files: lldb/source/Command

[Lldb-commits] [PATCH] D150619: [lldb] Delay removal of persistent results

kastiglione added a comment. This change is tested using the original tests from D144044 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150619/new/ https://reviews.llvm.org/D150619 __

[Lldb-commits] [PATCH] D150129: [lldb] Refine call to decl printing helper (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG8d4f0e079554: [lldb] Refine call to decl printing helper (NFC) (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150129/new/ https://

[Lldb-commits] [PATCH] D150619: [lldb] Delay removal of persistent results

kastiglione updated this revision to Diff 522354. kastiglione added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150619/new/ https://reviews.llvm.org/D150619 Files: lldb/source/Commands/CommandObjectDWIMPrint.cpp lldb/source

[Lldb-commits] [PATCH] D150619: [lldb] Delay removal of persistent results

kastiglione created this revision. kastiglione added reviewers: aprantl, jingham. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Follow up to "Suppress persistent result when running po" (D144044 <

[Lldb-commits] [PATCH] D150383: [lldb] Correct elision of line zero in mixed disassembly

This revision was automatically updated to reflect the committed changes. Closed by commit rGefbd5870402b: [lldb] Correct elision of line zero in mixed disassembly (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150383/new/

[Lldb-commits] [PATCH] D149214: [lldb] Speed up DebugAbbrev parsing

kastiglione added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFAbbreviationDeclaration.h:61 uint8_t m_has_children = 0; - DWARFAttribute::collection m_attributes; }; With this change, can the following be removed from` DWARFAttribu

[Lldb-commits] [PATCH] D150383: [lldb] Correct elision of line zero in mixed disassembly

kastiglione updated this revision to Diff 521420. kastiglione added a comment. add positive check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150383/new/ https://reviews.llvm.org/D150383 Files: lldb/source/Core/Disassembler.cpp lldb/test/She

[Lldb-commits] [PATCH] D150383: [lldb] Correct elision of line zero in mixed disassembly

kastiglione updated this revision to Diff 521392. kastiglione added a comment. add Shell test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150383/new/ https://reviews.llvm.org/D150383 Files: lldb/source/Core/Disassembler.cpp lldb/test/Shell/C

[Lldb-commits] [PATCH] D150383: [lldb] Correct elision of line zero in mixed disassembly

kastiglione added a comment. Herald added a subscriber: JDevlieghere. For testing, can anyone recommend a way to construct debug info with line entries that have line zero? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150383/new/ https://reviews.

[Lldb-commits] [PATCH] D150383: [lldb] Correct elision of line zero in mixed disassembly

kastiglione created this revision. kastiglione added reviewers: jingham, aprantl, jasonmolenda. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. When `disassemble --mixed` is run, do not show source f

[Lldb-commits] [PATCH] D150160: [lldb] Simplify Log::PutString (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG586414927418: [lldb] Simplify Log::PutString (NFC) (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150160/new/ https://reviews.llvm

[Lldb-commits] [PATCH] D150160: [lldb] Simplify Log::PutString (NFC)

kastiglione updated this revision to Diff 520541. kastiglione added a comment. Update comments too Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150160/new/ https://reviews.llvm.org/D150160 Files: lldb/source/Utility/Log.cpp Index: lldb/source

[Lldb-commits] [PATCH] D150160: [lldb] Simplify Log::PutString (NFC)

kastiglione created this revision. kastiglione added reviewers: mib, bulbazord. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. - As no format string is involved, avoid unecessary call into `Printf`

[Lldb-commits] [PATCH] D150129: [lldb] Refine call to decl printing helper (NFC)

kastiglione created this revision. kastiglione added reviewers: aprantl, JDevlieghere, jingham. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. When `ValueObjectPrinter` calls its `m_decl_printing_he

[Lldb-commits] [PATCH] D150078: [lldb] Prevent mutation of CommandAlias::GetOptionArguments

This revision was automatically updated to reflect the committed changes. Closed by commit rG765237779ce4: [lldb] Prevent mutation of CommandAlias::GetOptionArguments (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150078/new

[Lldb-commits] [PATCH] D150078: [lldb] Prevent mutation of CommandAlias::GetOptionArguments

kastiglione created this revision. kastiglione added reviewers: jingham, JDevlieghere, aprantl. Herald added a subscriber: jeroen.dobbelaere. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Fix a mut

[Lldb-commits] [PATCH] D147736: [lldb] Add an LLDB_DEPRECATED macro similar to LLVM_DEPRECATED

kastiglione added inline comments. Comment at: lldb/include/lldb/API/SBDefines.h:33 +// supports the attribute. +#if defined(SWIG) or _cplusplus < 201402L +#undef LLDB_DEPRECATED @JDevlieghere should this be `||` instead of `or`? Repository: rG LLVM Github Mo

[Lldb-commits] [PATCH] D148650: [lldb] Pass skip_exec=True in TestExec.test_skipping_exec

kastiglione abandoned this revision. kastiglione added a comment. Herald added a subscriber: JDevlieghere. 🤦‍♂️ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148650/new/ https://reviews.llvm.org/D148650

[Lldb-commits] [PATCH] D148650: [lldb] Pass skip_exec=True in TestExec.test_skipping_exec

kastiglione created this revision. kastiglione added a reviewer: jingham. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Fix the test to match the function name, by passing `skip_exec=True`. Otherw

[Lldb-commits] [PATCH] D148588: [lldb] Add more asserts to TestExec

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG773d9c360432: [lldb] Add more asserts to TestExec (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANG

  1   2   3   4   5   6   7   8   >