[Lldb-commits] [PATCH] D151950: [lldb] Unconditionally increment depth when printing children

[Dave Lee via Phabricator via lldb-commits]

kastiglione added a comment.

+1 to a test

thanks for the fix!



================
Comment at: lldb/source/DataFormatters/ValueObjectPrinter.cpp:593
     const DumpValueObjectOptions::PointerDepth &curr_ptr_depth) {
-  const uint32_t consumed_depth = (!m_options.m_pointer_as_array) ? 1 : 0;
+  const uint32_t consumed_depth = m_options.m_pointer_as_array ? 0 : 1;
   const bool does_consume_ptr_depth =
----------------
seems this is now used with `m_omit_summary_depth`, maybe name it 
`consumed_summary_depth`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151950/new/

https://reviews.llvm.org/D151950

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits