kastiglione added inline comments.
================
Comment at: lldb/source/Core/ValueObjectSyntheticFilter.cpp:338
if (!did_find && m_synth_filter_up != nullptr) {
uint32_t index = m_synth_filter_up->GetIndexOfChildWithName(name);
if (index == UINT32_MAX)
----------------
Michael137 wrote:
> Could pass name_ref directly now, instead of doing the implicit conversion
This is a different `GetIndexOfChildWithName`, in the
`SyntheticChildrenFrontEnd` class. It still takes a `ConstString`, changing it
is a follow up.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151811/new/
https://reviews.llvm.org/D151811
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits