[Lldb-commits] [lldb] [lldb] Provide lr value in faulting frame on arm64 (PR #138805)

2025-05-07 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: I'm thinking I'll write an API test that instruction steps through the whole thing and backtraces at each point, making sure it can get every function between the current one & main at all points, just for fun extra stress testing. https://github.com/llvm/llvm-project/pull/

[Lldb-commits] [lldb] [lldb] Provide lr value in faulting frame on arm64 (PR #138805)

2025-05-07 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda updated https://github.com/llvm/llvm-project/pull/138805 >From 4fc9acd03a58a3617b113352c48e5dd2fdb58eda Mon Sep 17 00:00:00 2001 From: Jason Molenda Date: Tue, 6 May 2025 22:37:17 -0700 Subject: [PATCH 1/4] [lldb] Provide lr value in faulting frame on arm64 When

[Lldb-commits] [lldb] [lldb] Provide lr value in faulting frame on arm64 (PR #138805)

2025-05-07 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda updated https://github.com/llvm/llvm-project/pull/138805 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,s

[Lldb-commits] [lldb] [LLDB] Add field member operators to DIL (PR #138093)

2025-05-07 Thread via lldb-commits
cmtice wrote: > A very predictable question. Why is the implementation of this more > complicated than `base->GetChildMemberWithName(name)`. I think it shouldn't > be. > > To avoid repeating the same points over and over, I suggest going through the > discussion on the dereference/addressof p

[Lldb-commits] [lldb] [lldb-dap] Re-enable the lldb-dap tests (PR #138791)

2025-05-07 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: All the Linux and Windows buildbots are green, but GreenDragon is consistently failing with one of the breakpoint tests and it's not immediately obvious what the problem is. If I rerun the tests enough times, I can reproduce a failure locally. I've disabled those tests in d

[Lldb-commits] [lldb] [LLDB] Add field member operators to DIL (PR #138093)

2025-05-07 Thread via lldb-commits
@@ -88,6 +89,29 @@ class IdentifierNode : public ASTNode { std::string m_name; }; +class MemberOfNode : public ASTNode { +public: + MemberOfNode(uint32_t location, ASTNodeUP base, bool is_arrow, + ConstString name) + : ASTNode(location, NodeKind::eMemberO

[Lldb-commits] [lldb] [LLDB] Add field member operators to DIL (PR #138093)

2025-05-07 Thread via lldb-commits
@@ -88,6 +89,29 @@ class IdentifierNode : public ASTNode { std::string m_name; }; +class MemberOfNode : public ASTNode { +public: + MemberOfNode(uint32_t location, ASTNodeUP base, bool is_arrow, + ConstString name) + : ASTNode(location, NodeKind::eMemberO

[Lldb-commits] [lldb] [LLDB] Add field member operators to DIL (PR #138093)

2025-05-07 Thread via lldb-commits
@@ -272,4 +272,204 @@ Interpreter::Visit(const UnaryOpNode *node) { m_expr, "invalid ast: unexpected binary operator", node->GetLocation()); } +lldb::ValueObjectSP +Interpreter::EvaluateMemberOf(lldb::ValueObjectSP value, + const std::vector

[Lldb-commits] [lldb] [LLDB] Add field member operators to DIL (PR #138093)

2025-05-07 Thread via lldb-commits
https://github.com/cmtice updated https://github.com/llvm/llvm-project/pull/138093 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,sans-se

[Lldb-commits] [lldb] df4eac2 - [lldb-dap] Temporarily disable the breakpoint tests

2025-05-07 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2025-05-07T23:08:51-07:00 New Revision: df4eac2f8b6d32772953d3d8063568fe4c0314c1 URL: https://github.com/llvm/llvm-project/commit/df4eac2f8b6d32772953d3d8063568fe4c0314c1 DIFF: https://github.com/llvm/llvm-project/commit/df4eac2f8b6d32772953d3d8063568fe4c0314c1.d

[Lldb-commits] [lldb] [lldb][AIX] Support for XCOFF Sections (PR #131304)

2025-05-07 Thread Dhruv Srivastava via lldb-commits
@@ -7,6 +7,9 @@ # CHECK: Stripped: false # CHECK: Type: executable # CHECK: Strata: unknown +# CHECK: Name: .text +# CHECK-NEXT: code +# CHECK-NEXT: r-x DhruvSrivastavaX wrote: Yes, I was a little hesitant to make it larger as other platform test cases are mu

[Lldb-commits] [lldb] [lldb][AIX] Support for XCOFF Sections (PR #131304)

2025-05-07 Thread Dhruv Srivastava via lldb-commits
@@ -190,8 +190,83 @@ void ObjectFileXCOFF::ParseSymtab(Symtab &lldb_symtab) {} bool ObjectFileXCOFF::IsStripped() { return false; } -void ObjectFileXCOFF::CreateSections(SectionList &unified_section_list) {} - +void ObjectFileXCOFF::CreateSections(SectionList &unified_section

[Lldb-commits] [lldb] [lldb] Change the statusline format to print "no target" (PR #139021)

2025-05-07 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/139021 >From fcd590a31f7b490f5fbc5996d9c5f2836ff4e7ee Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Wed, 7 May 2025 21:20:47 -0700 Subject: [PATCH 1/2] [lldb] Change the statusline format to print "no tar

[Lldb-commits] [lldb] [lldb] Provide lr value in faulting frame on arm64 (PR #138805)

2025-05-07 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: FTR that test is skipped on darwin because _sigtramp in libc on aarch64 doesn't have any hand-supplied eh_frame right now :/ I have a test case put together, with a few functions written in assembly with hand-added cfi directives. It's probably darwin specific assembly, ob

[Lldb-commits] [lldb] efce7a1 - [lldb-dap] Re-enable the lldb-dap tests (#138791)

2025-05-07 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2025-05-07T20:40:04-07:00 New Revision: efce7a169e58ec8b27d266ec4dfb851f85a7c6c2 URL: https://github.com/llvm/llvm-project/commit/efce7a169e58ec8b27d266ec4dfb851f85a7c6c2 DIFF: https://github.com/llvm/llvm-project/commit/efce7a169e58ec8b27d266ec4dfb851f85a7c6c2.d

[Lldb-commits] [lldb] [lldb-dap] Re-enable the lldb-dap tests (PR #138791)

2025-05-07 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/138791 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Fix GetIndexOfChildMemberWithName to handle anonymous structs. (PR #138487)

2025-05-07 Thread via lldb-commits
https://github.com/cmtice closed https://github.com/llvm/llvm-project/pull/138487 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 92d3029 - [LLDB] Fix GetIndexOfChildMemberWithName to handle anonymous structs. (#138487)

2025-05-07 Thread via lldb-commits
Author: cmtice Date: 2025-05-07T20:39:37-07:00 New Revision: 92d3029fa4a9c6ce21c50590e57ae834ae3db3bc URL: https://github.com/llvm/llvm-project/commit/92d3029fa4a9c6ce21c50590e57ae834ae3db3bc DIFF: https://github.com/llvm/llvm-project/commit/92d3029fa4a9c6ce21c50590e57ae834ae3db3bc.diff LOG: [

[Lldb-commits] [lldb] [lldb-dap] Re-enable the lldb-dap tests (PR #138791)

2025-05-07 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: I re-landed the launch sequence patch (aeeb9a3c09f40f42a1e8e5e3c8dbde3b260744bd) and the Windows bots are happy again. Given that was the only objections, I'm going to merge this so we can get some insights overnight. As I said in the description, I expect the tests to be

[Lldb-commits] [lldb] [LLDB] Fix GetIndexOfChildMemberWithName to handle anonymous structs. (PR #138487)

2025-05-07 Thread via lldb-commits
https://github.com/cmtice updated https://github.com/llvm/llvm-project/pull/138487 >From 780371cf111c97e2bce5f030625ff557bb2f40b6 Mon Sep 17 00:00:00 2001 From: Caroline Tice Date: Sun, 4 May 2025 23:43:28 -0700 Subject: [PATCH 1/3] [LLDB] Fix GetIndexOfChildMemberWithName to handle anonymous

[Lldb-commits] [clang] [lldb] [clang] Add support for `__ptrauth` being applied to integer types (PR #137580)

2025-05-07 Thread Oliver Hunt via lldb-commits
https://github.com/ojhunt edited https://github.com/llvm/llvm-project/pull/137580 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Adding a modules explorer to lldb-dap ext. (PR #138977)

2025-05-07 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM but please give @da-viper a chance to review this before merging. https://github.com/llvm/llvm-project/pull/138977 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.

[Lldb-commits] [lldb] [lldb-dap] Migrate 'continue' request to new RequestHandler. (PR #138987)

2025-05-07 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. Very straightforward. LGTM. https://github.com/llvm/llvm-project/pull/138987 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-com

[Lldb-commits] [lldb] [lldb-dap] Migrate 'continue' request to new RequestHandler. (PR #138987)

2025-05-07 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: John Harrison (ashgti) Changes This adds types for the 'continue' request and updates the existing handler to the new base class. --- Full diff: https://github.com/llvm/llvm-project/pull/138987.diff 4 Files Affected: - (modified) lldb/t

[Lldb-commits] [lldb] [lldb-dap] Migrate 'continue' request to new RequestHandler. (PR #138987)

2025-05-07 Thread John Harrison via lldb-commits
https://github.com/ashgti created https://github.com/llvm/llvm-project/pull/138987 This adds types for the 'continue' request and updates the existing handler to the new base class. Rate limit · GitHub body { background-color: #f6f8fa; co

[Lldb-commits] [lldb] [lldb-dap] Change the launch sequence (reland) (PR #138981)

2025-05-07 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: aeeb9a3c09f40f42a1e8e5e3c8dbde3b260744bd https://github.com/llvm/llvm-project/pull/138981 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Change the launch sequence (reland) (PR #138981)

2025-05-07 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/138981 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] aeeb9a3 - [lldb-dap] Change the launch sequence (#138219) (reland)

2025-05-07 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2025-05-07T16:20:47-07:00 New Revision: aeeb9a3c09f40f42a1e8e5e3c8dbde3b260744bd URL: https://github.com/llvm/llvm-project/commit/aeeb9a3c09f40f42a1e8e5e3c8dbde3b260744bd DIFF: https://github.com/llvm/llvm-project/commit/aeeb9a3c09f40f42a1e8e5e3c8dbde3b260744bd.d

[Lldb-commits] [lldb] [lldb-dap] Change the launch sequence (reland) (PR #138981)

2025-05-07 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/138981 >From 8c7a01465891c83f7cc99ee95b0852c56e0f150f Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Tue, 6 May 2025 15:58:44 -0700 Subject: [PATCH 1/2] [lldb-dap] Change the launch sequence (#138219) Thi

[Lldb-commits] [lldb] [lldb-dap] Adding a modules explorer to lldb-dap ext. (PR #138977)

2025-05-07 Thread John Harrison via lldb-commits
@@ -763,6 +764,16 @@ } ] } -] +], +"views": { + "debug": [ +{ + "id": "lldb-dap.modulesExplorer", + "name": "LLDB Modules Explorer", ashgti wrote: Updated to just be 'Modules'. https://github.

[Lldb-commits] [lldb] [lldb-dap] Adding a modules explorer to lldb-dap ext. (PR #138977)

2025-05-07 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/138977 >From 756174c282fc7101bfadb29556f39ce046ad0116 Mon Sep 17 00:00:00 2001 From: John Harrison Date: Wed, 7 May 2025 14:54:29 -0700 Subject: [PATCH 1/2] [lldb-dap] Adding a modules explorer to lldb-dap ext. This cr

[Lldb-commits] [lldb] 0d0ef58 - [lldb][Darwin] Note why this test is xfail'ed on

2025-05-07 Thread Jason Molenda via lldb-commits
Author: Jason Molenda Date: 2025-05-07T15:53:30-07:00 New Revision: 0d0ef58c8facb0f2e5c2f4615b0d25f19e5abe01 URL: https://github.com/llvm/llvm-project/commit/0d0ef58c8facb0f2e5c2f4615b0d25f19e5abe01 DIFF: https://github.com/llvm/llvm-project/commit/0d0ef58c8facb0f2e5c2f4615b0d25f19e5abe01.diff

[Lldb-commits] [lldb] [lldb] Expose QueueThreadPlanForStepSingleInstruction function to SBThreadPlan (PR #137904)

2025-05-07 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen updated https://github.com/llvm/llvm-project/pull/137904 >From 998d59c6462326874d3fcd13f4cf92290c7bf5f9 Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Wed, 30 Apr 2025 02:00:44 +0200 Subject: [PATCH 1/5] Expose QueueThreadPlanForStepSingleInstruction function to SBT

[Lldb-commits] [lldb] [lldb-dap] Adding a modules explorer to lldb-dap ext. (PR #138977)

2025-05-07 Thread Jonas Devlieghere via lldb-commits
@@ -763,6 +764,16 @@ } ] } -] +], +"views": { + "debug": [ +{ + "id": "lldb-dap.modulesExplorer", + "name": "LLDB Modules Explorer", JDevlieghere wrote: Is "explorer" common terminology in VS C

[Lldb-commits] [lldb] [lldb-dap] Adding a modules explorer to lldb-dap ext. (PR #138977)

2025-05-07 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/138977 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Adding a modules explorer to lldb-dap ext. (PR #138977)

2025-05-07 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere commented: This is really awesome and I'm surprised/impressed with how little TypeScript it takes to implement something like this. https://github.com/llvm/llvm-project/pull/138977 ___ lldb-commits mailing list lldb-com

[Lldb-commits] [lldb] [lldb-dap] Change the launch sequence (reland) (PR #138981)

2025-05-07 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes This PR changes how we treat the launch sequence in lldb-dap. - Send the initialized event after we finish handling the initialize request, rather than after we finish attaching or launching. -

[Lldb-commits] [lldb] [lldb-dap] Change the launch sequence (reland) (PR #138981)

2025-05-07 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/138981 This PR changes how we treat the launch sequence in lldb-dap. - Send the initialized event after we finish handling the initialize request, rather than after we finish attaching or launching. - Delay h

[Lldb-commits] [lldb] [lldb-dap] Format extension typescript. (PR #138925)

2025-05-07 Thread John Harrison via lldb-commits
ashgti wrote: Oh, that script should already be defined in the package.json, that was the script I used for formatting. https://github.com/llvm/llvm-project/pull/138925 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/

[Lldb-commits] [lldb] [lldb-dap] Adding a modules explorer to lldb-dap ext. (PR #138977)

2025-05-07 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/138977 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Disable flaky test_qThreadInfo_matches_qC_attach test on AArch64 Linux (PR #138940)

2025-05-07 Thread Philip Reames via lldb-commits
https://github.com/preames approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/138940 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Adding a modules explorer to lldb-dap ext. (PR #138977)

2025-05-07 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: John Harrison (ashgti) Changes This creates a very basic module explorer for tracking and displaying loaded modules, reported by lldb-dap for the active debug session. This includes a basic session tracker that we can use to observe the de

[Lldb-commits] [lldb] [lldb-dap] Adding a modules explorer to lldb-dap ext. (PR #138977)

2025-05-07 Thread John Harrison via lldb-commits
https://github.com/ashgti created https://github.com/llvm/llvm-project/pull/138977 This creates a very basic module explorer for tracking and displaying loaded modules, reported by lldb-dap for the active debug session. This includes a basic session tracker that we can use to observe the debug

[Lldb-commits] [clang] [flang] [lld] [lldb] [llvm] [mlir] [polly] [CMake] respect LLVMConfig.cmake's LLVM_DEFINITIONS in standalone builds (PR #138587)

2025-05-07 Thread via lldb-commits
https://github.com/jeremyd2019 edited https://github.com/llvm/llvm-project/pull/138587 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix dynamic type resolutions for core files (PR #138698)

2025-05-07 Thread Felipe de Azevedo Piovezan via lldb-commits
felipepiovezan wrote: Btw I think this is causing an asan failure: https://green.lab.llvm.org/job/lldb-cmake-sanitized/1671/ ``` 2025-05-07T19:03:57.557Z] ==73219==ERROR: AddressSanitizer: stack-buffer-overflow on address 0x0001070cf5b8 at pc 0x0001056051c0 bp 0x00016b0a3730 sp 0x00016b0a2ee0

[Lldb-commits] [lldb] [lldb] Expose QueueThreadPlanForStepSingleInstruction function to SBThreadPlan (PR #137904)

2025-05-07 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen updated https://github.com/llvm/llvm-project/pull/137904 >From 998d59c6462326874d3fcd13f4cf92290c7bf5f9 Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Wed, 30 Apr 2025 02:00:44 +0200 Subject: [PATCH 1/5] Expose QueueThreadPlanForStepSingleInstruction function to SBT

[Lldb-commits] [lldb] [LLDB][Minidump] Add some buffer directories (PR #138943)

2025-05-07 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond closed https://github.com/llvm/llvm-project/pull/138943 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 40941f1 - [LLDB][Minidump] Add some buffer directories (#138943)

2025-05-07 Thread via lldb-commits
Author: Jacob Lalonde Date: 2025-05-07T12:53:37-07:00 New Revision: 40941f15962191d0236ecdc29cd6937abce974fb URL: https://github.com/llvm/llvm-project/commit/40941f15962191d0236ecdc29cd6937abce974fb DIFF: https://github.com/llvm/llvm-project/commit/40941f15962191d0236ecdc29cd6937abce974fb.diff

[Lldb-commits] [lldb] [LLDB][Minidump] Add some buffer directories (PR #138943)

2025-05-07 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions cpp -- lldb/source/Plugins/ObjectFile/Minidump/MinidumpFileB

[Lldb-commits] [lldb] [LLDB][Minidump] Add some buffer directories (PR #138943)

2025-05-07 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jacob Lalonde (Jlalond) Changes Add a generous amount of buffer directories. I found out some LLDB forks (internal and external) had custom ranges that could fail because we didn't pre-account for those. To prevent this from being a proble

[Lldb-commits] [lldb] [LLDB][Minidump] Add some buffer directories (PR #138943)

2025-05-07 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond edited https://github.com/llvm/llvm-project/pull/138943 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][Minidump] Add some buffer directories (PR #138943)

2025-05-07 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond created https://github.com/llvm/llvm-project/pull/138943 Add a generous amount of buffer directories. I found out some LLDB forks (internal and external) had custom ranges that could fail because we didn't pre-account for those. To prevent this from being a problem,

[Lldb-commits] [lldb] [lldb] print a notice when `source list` paging reaches the end of th… (PR #137515)

2025-05-07 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/137515 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Do not bump memory modificator ID when "internal" debugger memory is updated (PR #129092)

2025-05-07 Thread Mikhail Zakharov via lldb-commits
real-mikhail wrote: Thanks for the example and the link. I fixed test to work on both Windows-x86 and Windows-x64 and created new PR: https://github.com/llvm/llvm-project/pull/138941 https://github.com/llvm/llvm-project/pull/129092 ___ lldb-commits ma

[Lldb-commits] [lldb] [lldb] Fixed TestProcessModificationIdOnExpr to work on both x86 and x64 architectures (PR #138941)

2025-05-07 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Mikhail Zakharov (real-mikhail) Changes Original PR where test was introduced and improvements discussed: https://github.com/llvm/llvm-project/pull/129092#issuecomment-2855337004 --- Full diff: https://github.com/llvm/llvm-project/pull/138

[Lldb-commits] [lldb] [lldb] Fixed TestProcessModificationIdOnExpr to work on both x86 and x64 architectures (PR #138941)

2025-05-07 Thread Mikhail Zakharov via lldb-commits
https://github.com/real-mikhail created https://github.com/llvm/llvm-project/pull/138941 Original PR where test was introduced and improvements discussed: https://github.com/llvm/llvm-project/pull/129092#issuecomment-2855337004 Rate limit · GitHub body {

[Lldb-commits] [lldb] [lldb][test] Disable flaky test_qThreadInfo_matches_qC_attach test on AArch64 Linux (PR #138940)

2025-05-07 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dmitry Vasilyev (slydiman) Changes See #138085 for details. https://lab.llvm.org/buildbot/#/builders/59/builds/16937 https://lab.llvm.org/buildbot/#/builders/59/builds/17224 --- Full diff: https://github.com/llvm/llvm-project/pull/138940.

[Lldb-commits] [lldb] [lldb][test] Disable flaky test_qThreadInfo_matches_qC_attach test on AArch64 Linux (PR #138940)

2025-05-07 Thread Dmitry Vasilyev via lldb-commits
https://github.com/slydiman created https://github.com/llvm/llvm-project/pull/138940 See #138085 for details. https://lab.llvm.org/buildbot/#/builders/59/builds/16937 https://lab.llvm.org/buildbot/#/builders/59/builds/17224 Rate limit · GitHub body {

[Lldb-commits] [lldb] 854b9e9 - [lldb-dap] Format extension typescript. (#138925)

2025-05-07 Thread via lldb-commits
Author: John Harrison Date: 2025-05-07T11:49:53-07:00 New Revision: 854b9e931703dd1b9d8a2b0fe8da787f9e26058d URL: https://github.com/llvm/llvm-project/commit/854b9e931703dd1b9d8a2b0fe8da787f9e26058d DIFF: https://github.com/llvm/llvm-project/commit/854b9e931703dd1b9d8a2b0fe8da787f9e26058d.diff

[Lldb-commits] [lldb] [lldb-dap] Format extension typescript. (PR #138925)

2025-05-07 Thread John Harrison via lldb-commits
https://github.com/ashgti closed https://github.com/llvm/llvm-project/pull/138925 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Reapply "[lldb] Inherit DuplicateFileAction(HANDLE, HANDLE) handles on windows (#137978)" (PR #138896)

2025-05-07 Thread Dmitry Vasilyev via lldb-commits
https://github.com/slydiman approved this pull request. I have tested the failed Host.LaunchProcessDuplicatesHandle test on the setup similar to [lldb-remote-linux-win](https://lab.llvm.org/buildbot/#/builders/197). It is fixed now. https://github.com/llvm/llvm-project/pull/138896 ___

[Lldb-commits] [lldb] [lldb-dap] Format extension typescript. (PR #138925)

2025-05-07 Thread John Harrison via lldb-commits
ashgti wrote: I'm not sure, clang-format can format .json and .js/.ts files but I think the current config isn't applying it to those files. https://github.com/llvm/llvm-project/blob/main/llvm/utils/git/code-format-helper.py doesn't apply to those file extensions. We may be able to update tha

[Lldb-commits] [lldb] 47218ea - [lldb] Use -Wno-documentation-deprecated-sync if available (#138909)

2025-05-07 Thread via lldb-commits
Author: Kazu Hirata Date: 2025-05-07T11:14:28-07:00 New Revision: 47218eadd8adf1926ced879caa50b8885d1b070d URL: https://github.com/llvm/llvm-project/commit/47218eadd8adf1926ced879caa50b8885d1b070d DIFF: https://github.com/llvm/llvm-project/commit/47218eadd8adf1926ced879caa50b8885d1b070d.diff L

[Lldb-commits] [lldb] [lldb] Use -Wno-documentation-deprecated-sync if available (PR #138909)

2025-05-07 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/138909 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Fix package.json after a bad merge. (PR #138918)

2025-05-07 Thread John Harrison via lldb-commits
https://github.com/ashgti edited https://github.com/llvm/llvm-project/pull/138918 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Use -Wno-documentation-deprecated-sync if available (PR #138909)

2025-05-07 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/138909 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Format extension typescript. (PR #138925)

2025-05-07 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM. Can we automate this with package.json? https://github.com/llvm/llvm-project/pull/138925 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[Lldb-commits] [lldb] [lldb-dap] Fix package.json after a bad merge. (PR #138918)

2025-05-07 Thread John Harrison via lldb-commits
https://github.com/ashgti closed https://github.com/llvm/llvm-project/pull/138918 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] bf59716 - [lldb-dap] Fix package.json after a bad merge. (#138918)

2025-05-07 Thread via lldb-commits
Author: John Harrison Date: 2025-05-07T10:55:11-07:00 New Revision: bf5971634a9244fd65c1bf8316b3d6ec407783ae URL: https://github.com/llvm/llvm-project/commit/bf5971634a9244fd65c1bf8316b3d6ec407783ae DIFF: https://github.com/llvm/llvm-project/commit/bf5971634a9244fd65c1bf8316b3d6ec407783ae.diff

[Lldb-commits] [lldb] [lldb-dap] Format extension typescript. (PR #138925)

2025-05-07 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: John Harrison (ashgti) Changes I think the format checker isn't checking typescript files. I ran `npm run format` to fix the extenion typescript. --- Full diff: https://github.com/llvm/llvm-project/pull/138925.diff 2 Files Affected: - (

[Lldb-commits] [lldb] [lldb-dap] Format extension typescript. (PR #138925)

2025-05-07 Thread John Harrison via lldb-commits
https://github.com/ashgti created https://github.com/llvm/llvm-project/pull/138925 I think the format checker isn't checking typescript files. I ran `npm run format` to fix the extenion typescript. >From 389bcb54b146ff707933146d561a272024f415fb Mon Sep 17 00:00:00 2001 From: John Harrison Dat

[Lldb-commits] [lldb] [lldb-dap] Fix package.json after a bad merge. (PR #138918)

2025-05-07 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond approved this pull request. Thanks @ashgti! https://github.com/llvm/llvm-project/pull/138918 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Fix package.json after a bad merge. (PR #138918)

2025-05-07 Thread John Harrison via lldb-commits
ashgti wrote: > @ashgti Hey John, do you mind splitting this patch? Sure, I'll make this fixing the package.json. > As for the package.json, do we have any tests that try to npm build? Should > we add them? I don't think they're run as part of the CI today. We could see if there is some way

[Lldb-commits] [lldb] [lldb-dap] Fix package.json after a bad merge. (PR #138918)

2025-05-07 Thread John Harrison via lldb-commits
https://github.com/ashgti edited https://github.com/llvm/llvm-project/pull/138918 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Fix the package.json and format lldb-dap typescript. (PR #138918)

2025-05-07 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/138918 >From 05b709033990e6cdfd7cb9fdbd7e8eab260e7a62 Mon Sep 17 00:00:00 2001 From: John Harrison Date: Wed, 7 May 2025 10:46:55 -0700 Subject: [PATCH] [lldb-dap] Fix package.json after a bad merge. The package.json i

[Lldb-commits] [lldb] [lldb] Use -Wno-documentation-deprecated-sync if available (PR #138909)

2025-05-07 Thread Kazu Hirata via lldb-commits
@@ -16,6 +16,15 @@ if (CXX_SUPPORTS_DOCUMENTATION) PRIVATE -Wdocumentation) endif() +# Apply -Wno-documentation-deprecated-sync while we migrate away from +# report_fatal_error in llvm/include/llvm/Support/ErrorHandling.h +# and llvm/include/llvm/Support/Error.h. -

[Lldb-commits] [lldb] [lldb] Use -Wno-documentation-deprecated-sync if available (PR #138909)

2025-05-07 Thread Alex Langford via lldb-commits
@@ -16,6 +16,15 @@ if (CXX_SUPPORTS_DOCUMENTATION) PRIVATE -Wdocumentation) endif() +# Apply -Wno-documentation-deprecated-sync while we migrate away from +# report_fatal_error in llvm/include/llvm/Support/ErrorHandling.h +# and llvm/include/llvm/Support/Error.h. -

[Lldb-commits] [lldb] [lldb-dap] Change the launch sequence (PR #138219)

2025-05-07 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: The following two tests are both setting breakpoints without stopping at entry, which means that we could have run past the breakpoint by the time it's set: ``` lldb-api :: tools/lldb-dap/completions/TestDAP_completions.py lldb-api :: tools/lldb-dap/startDebugging/TestDA

[Lldb-commits] [lldb] [lldb-dap] Ensure we acquire the SB API lock while handling requests. (PR #137026)

2025-05-07 Thread John Harrison via lldb-commits
ashgti wrote: So, I was checking this and I see `lldb_dap::DAP::ResetDebuggerState() (/data/users/jeffreytan/llvm-sand/external/llvm-project/lldb/tools/lldb-dap/DAP.cpp:1411)` in the call stack. That function doesn't exist in the open source version of lldb-dap. I'm not sure what its doing bu

[Lldb-commits] [lldb] [LLDB] Add IsCoreDumping to ProcessInstanceInfo (PR #138580)

2025-05-07 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond closed https://github.com/llvm/llvm-project/pull/138580 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 1ad57b5 - [LLDB] Add IsCoreDumping to ProcessInstanceInfo (#138580)

2025-05-07 Thread via lldb-commits
Author: Jacob Lalonde Date: 2025-05-07T09:05:53-07:00 New Revision: 1ad57b58d6ba53be99bd6f2fa928a126c9deb91c URL: https://github.com/llvm/llvm-project/commit/1ad57b58d6ba53be99bd6f2fa928a126c9deb91c DIFF: https://github.com/llvm/llvm-project/commit/1ad57b58d6ba53be99bd6f2fa928a126c9deb91c.diff

[Lldb-commits] [lldb] [lldb] Fix offset computation in RegisterContextUnwind (PR #137155)

2025-05-07 Thread Pavel Labath via lldb-commits
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/137155 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix offset computation in RegisterContextUnwind (PR #137155)

2025-05-07 Thread Pavel Labath via lldb-commits
https://github.com/labath updated https://github.com/llvm/llvm-project/pull/137155 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,sans-se

[Lldb-commits] [lldb] [lldb] Call Target::ClearAllLoadedSections earlier (PR #138892)

2025-05-07 Thread Pavel Labath via lldb-commits
https://github.com/labath created https://github.com/llvm/llvm-project/pull/138892 Minidump files contain explicit information about load addresses of modules, so it can load them itself. This works on other platforms, but fails on darwin because DynamicLoaderDarwin nukes the loaded module lis

[Lldb-commits] [lldb] [lldb-dap] Change the launch sequence (PR #138219)

2025-05-07 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: Looking at the logs, the common theme appears to be that all the test binaries exit before they hit any breakpoints. My best guess as to why this is only happening on Windows is the way the dynamic loader there works. If that's the case, then it means that those tests are m

[Lldb-commits] [lldb] [lldb] Call Target::ClearAllLoadedSections earlier (PR #138892)

2025-05-07 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes Minidump files contain explicit information about load addresses of modules, so it can load them itself. This works on other platforms, but fails on darwin because DynamicLoaderDarwin nukes the loaded module l

[Lldb-commits] [lldb] 461ba2d - [lldb] XFAIL TestDynamicValue.py:test_from_core_file on arm(32)

2025-05-07 Thread Pavel Labath via lldb-commits
Author: Pavel Labath Date: 2025-05-07T16:57:30+02:00 New Revision: 461ba2db5d15793d18a5c18ce417c30e335602cc URL: https://github.com/llvm/llvm-project/commit/461ba2db5d15793d18a5c18ce417c30e335602cc DIFF: https://github.com/llvm/llvm-project/commit/461ba2db5d15793d18a5c18ce417c30e335602cc.diff

[Lldb-commits] [lldb] [lldb] Fix dynamic type resolutions for core files (PR #138698)

2025-05-07 Thread David Spickett via lldb-commits
DavidSpickett wrote: Yep, called from AddThreadList: ``` #0 0xedfbe37c llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) (/home/david.spickett/build-llvm-arm/local/lib/python3.10/dist-packages/lldb/_lldb.cpython-310-arm-linux-gnueabihf.so+0xdbe37c) #1 0xedfbca00 llvm::sys::RunS

[Lldb-commits] [lldb] [lldb] Fix dynamic type resolutions for core files (PR #138698)

2025-05-07 Thread Pavel Labath via lldb-commits
labath wrote: Oh, it's [this one](https://github.com/llvm/llvm-project/blob/3feb8b42e973f935883bc9e779645ecdae1a586d/lldb/source/Plugins/ObjectFile/Minidump/MinidumpFileBuilder.cpp#L547). That makes more sense now. I'll skip the test on arm. Thanks for catching that. https://github.com/llvm/ll

[Lldb-commits] [lldb] 1815d62 - [lldb] Add more logging to a unit test

2025-05-07 Thread Pavel Labath via lldb-commits
Author: Pavel Labath Date: 2025-05-07T16:11:09+02:00 New Revision: 1815d62d7c43455c55bfc1842e41a25ea04dcb9b URL: https://github.com/llvm/llvm-project/commit/1815d62d7c43455c55bfc1842e41a25ea04dcb9b DIFF: https://github.com/llvm/llvm-project/commit/1815d62d7c43455c55bfc1842e41a25ea04dcb9b.diff

[Lldb-commits] [lldb] [lldb] Inherit DuplicateFileAction(HANDLE, HANDLE) handles on windows (PR #137978)

2025-05-07 Thread Pavel Labath via lldb-commits
labath wrote: (I see the failure on https://lab.llvm.org/buildbot/#/builders/197. I want to submit some additional logging code before I revert this.) https://github.com/llvm/llvm-project/pull/137978 ___ lldb-commits mailing list lldb-commits@lists.ll

[Lldb-commits] [clang] [lldb] [llvm] [mlir] [NFC][Support] Add llvm::uninitialized_copy (PR #138174)

2025-05-07 Thread Rahul Joshi via lldb-commits
https://github.com/jurahul updated https://github.com/llvm/llvm-project/pull/138174 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,sans-s

[Lldb-commits] [lldb] [lldb] Fix dynamic type resolutions for core files (PR #138698)

2025-05-07 Thread Pavel Labath via lldb-commits
labath wrote: @DavidSpickett, I am confused by the error on this arm builder: https://lab.llvm.org/buildbot/#/builders/18/builds/15619 It says arm is not supported, but I think that error message is coming from [here](https://github.com/llvm/llvm-project/blob/3feb8b42e973f935883bc9e779645ecdae

[Lldb-commits] [clang] [lldb] [llvm] [mlir] [NFC][Support] Add llvm::uninitialized_copy (PR #138174)

2025-05-07 Thread Rahul Joshi via lldb-commits
jurahul wrote: Thanks @jpienaar. Given I have 2 approvals, will commit it today. https://github.com/llvm/llvm-project/pull/138174 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] d865f32 - [lldb] Parse DWARF CFI for discontinuous functions (#137006)

2025-05-07 Thread via lldb-commits
Author: Pavel Labath Date: 2025-05-07T15:04:22+02:00 New Revision: d865f32fe820f543f0a53bfeba08774f2c270589 URL: https://github.com/llvm/llvm-project/commit/d865f32fe820f543f0a53bfeba08774f2c270589 DIFF: https://github.com/llvm/llvm-project/commit/d865f32fe820f543f0a53bfeba08774f2c270589.diff

[Lldb-commits] [lldb] [lldb] Parse DWARF CFI for discontinuous functions (PR #137006)

2025-05-07 Thread Pavel Labath via lldb-commits
@@ -17,23 +17,32 @@ image show-unwind --cached true -n foo # CHECK: UNWIND PLANS for {{.*}}`foo # -# CHECK: Assembly language inspection UnwindPlan: -# CHECK-NEXT: This UnwindPlan originally sourced from assembly insn profiling -# CHECK-NEXT: This UnwindPlan is sourced fro

[Lldb-commits] [lldb] [lldb] Parse DWARF CFI for discontinuous functions (PR #137006)

2025-05-07 Thread Pavel Labath via lldb-commits
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/137006 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Inherit DuplicateFileAction(HANDLE, HANDLE) handles on windows (PR #137978)

2025-05-07 Thread Pavel Labath via lldb-commits
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/137978 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 7c5f5f3 - [lldb] Inherit DuplicateFileAction(HANDLE, HANDLE) handles on windows (#137978)

2025-05-07 Thread via lldb-commits
Author: Pavel Labath Date: 2025-05-07T15:02:45+02:00 New Revision: 7c5f5f3ef83b1d1d43d63862a8431af3dded15bb URL: https://github.com/llvm/llvm-project/commit/7c5f5f3ef83b1d1d43d63862a8431af3dded15bb DIFF: https://github.com/llvm/llvm-project/commit/7c5f5f3ef83b1d1d43d63862a8431af3dded15bb.diff

[Lldb-commits] [lldb] 21501d1 - [lldb] Fix dynamic type resolutions for core files (#138698)

2025-05-07 Thread via lldb-commits
Author: Pavel Labath Date: 2025-05-07T15:02:21+02:00 New Revision: 21501d1cf290a63760904fb125e77b432db49933 URL: https://github.com/llvm/llvm-project/commit/21501d1cf290a63760904fb125e77b432db49933 DIFF: https://github.com/llvm/llvm-project/commit/21501d1cf290a63760904fb125e77b432db49933.diff

  1   2   >