llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-lldb Author: Jacob Lalonde (Jlalond) <details> <summary>Changes</summary> Add a generous amount of buffer directories. I found out some LLDB forks (internal and external) had custom ranges that could fail because we didn't pre-account for those. To prevent this from being a problem, I've added a large number of buffer directories at the cost of 240 bytes. --- Full diff: https://github.com/llvm/llvm-project/pull/138943.diff 1 Files Affected: - (modified) lldb/source/Plugins/ObjectFile/Minidump/MinidumpFileBuilder.cpp (+5) ``````````diff diff --git a/lldb/source/Plugins/ObjectFile/Minidump/MinidumpFileBuilder.cpp b/lldb/source/Plugins/ObjectFile/Minidump/MinidumpFileBuilder.cpp index 38806dfc8e5b5..b6c7e66e28793 100644 --- a/lldb/source/Plugins/ObjectFile/Minidump/MinidumpFileBuilder.cpp +++ b/lldb/source/Plugins/ObjectFile/Minidump/MinidumpFileBuilder.cpp @@ -75,6 +75,11 @@ Status MinidumpFileBuilder::AddHeaderAndCalculateDirectories() { } } + // Add a generous buffer of directories, these are quite small + // and forks may add new directories upstream LLDB hadn't accounted for + // when we started pre-calculating directory size, so this should account for that + m_expected_directories += 100; + m_saved_data_size += m_expected_directories * sizeof(llvm::minidump::Directory); Status error; `````````` </details> https://github.com/llvm/llvm-project/pull/138943 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
