Author: Jacob Lalonde Date: 2025-05-07T12:53:37-07:00 New Revision: 40941f15962191d0236ecdc29cd6937abce974fb
URL: https://github.com/llvm/llvm-project/commit/40941f15962191d0236ecdc29cd6937abce974fb DIFF: https://github.com/llvm/llvm-project/commit/40941f15962191d0236ecdc29cd6937abce974fb.diff LOG: [LLDB][Minidump] Add some buffer directories (#138943) Add a generous amount of buffer directories. I found out some LLDB forks (internal and external) had custom ranges that could fail because we didn't pre-account for those. To prevent this from being a problem, I've added a large number of buffer directories at the cost of 240 bytes. Added: Modified: lldb/source/Plugins/ObjectFile/Minidump/MinidumpFileBuilder.cpp Removed: ################################################################################ diff --git a/lldb/source/Plugins/ObjectFile/Minidump/MinidumpFileBuilder.cpp b/lldb/source/Plugins/ObjectFile/Minidump/MinidumpFileBuilder.cpp index 38806dfc8e5b5..d2ca5b26c9ec9 100644 --- a/lldb/source/Plugins/ObjectFile/Minidump/MinidumpFileBuilder.cpp +++ b/lldb/source/Plugins/ObjectFile/Minidump/MinidumpFileBuilder.cpp @@ -75,6 +75,12 @@ Status MinidumpFileBuilder::AddHeaderAndCalculateDirectories() { } } + // Add a generous buffer of directories, these are quite small + // and forks may add new directories upstream LLDB hadn't accounted for + // when we started pre-calculating directory size, so this should account for + // that + m_expected_directories += 100; + m_saved_data_size += m_expected_directories * sizeof(llvm::minidump::Directory); Status error; _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
