cmtice wrote:

> A very predictable question. Why is the implementation of this more 
> complicated than `base->GetChildMemberWithName(name)`. I think it shouldn't 
> be.
> 
> To avoid repeating the same points over and over, I suggest going through the 
> discussion on the dereference/addressof patch. If you still have questions 
> after that, let me know.

GetChildMemberWithName didn't handle everything correctly. I've fixed part of 
that now. There's still a bug in the code that searches for fields in base 
classes, which I want to try to find & fix.  I've removed all the special 
handling code from this PR.

Please review again. Thanks!

https://github.com/llvm/llvm-project/pull/138093
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to