[Lldb-commits] [lldb] [lldb][AIX] get host info for AIX (PR #134354)

2025-04-29 Thread Hemang Gadhavi via lldb-commits
HemangGadhavi wrote: > Could you please disable/revert if the fix is not easy? @felipepiovezan Done through the commit ID cf7301aeb808a13fe882a4b0bf7f1bfe4051c301 by labath https://github.com/llvm/llvm-project/pull/134354 ___ lldb-commits mailing li

[Lldb-commits] [lldb] [lldb-dap] Add an RAII helper for synchronous mode (NFC) (PR #137900)

2025-04-29 Thread John Harrison via lldb-commits
@@ -235,4 +235,15 @@ std::string GetStringValue(const lldb::SBStructuredData &data) { return str; } +ScopeSyncMode::ScopeSyncMode(lldb::SBDebugger &debugger) +: m_debugger(debugger) { + assert(m_debugger.GetAsync() && "Debugger not in asynchronous mode!");

[Lldb-commits] [lldb] [lldb-dap] Add an RAII helper for synchronous mode (NFC) (PR #137900)

2025-04-29 Thread John Harrison via lldb-commits
https://github.com/ashgti approved this pull request. LGTM, that’s helpful for making sure we’re consistent at least https://github.com/llvm/llvm-project/pull/137900 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[Lldb-commits] [lldb] [lldb-dap] Fix raciness in launch and attach tests (PR #137920)

2025-04-29 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes We've gotten multiple reports of the launch and attach test being flaky, both in CI and locally when running the tests. I believe the flakiness is due to a race between the main thread and the event

[Lldb-commits] [lldb] [lldb-dap] Fix raciness in launch and attach tests (PR #137920)

2025-04-29 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/137920 We've gotten multiple reports of the launch and attach test being flaky, both in CI and locally when running the tests. I believe the flakiness is due to a race between the main thread and the event handle

[Lldb-commits] [lldb] [lldb-dap] Add an RAII helper for synchronous mode (NFC) (PR #137900)

2025-04-29 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/137900 >From c7c0c4c7763dd46062f75c113ba4febbd938e851 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Tue, 29 Apr 2025 16:48:19 -0700 Subject: [PATCH] [lldb-dap] Add an RAII helper for synchronous mode (NFC

[Lldb-commits] [lldb] [lldb-dap] Add an RAII helper for synchronous mode (NFC) (PR #137900)

2025-04-29 Thread Jonas Devlieghere via lldb-commits
@@ -235,4 +235,15 @@ std::string GetStringValue(const lldb::SBStructuredData &data) { return str; } +ScopeSyncMode::ScopeSyncMode(lldb::SBDebugger &debugger) +: m_debugger(debugger) { + assert(m_debugger.GetAsync() && "Debugger not in asynchronous mode!");

[Lldb-commits] [lldb] [lldb] print a notice when `source list` paging reaches the end of th… (PR #137515)

2025-04-29 Thread via lldb-commits
hapee wrote: > That's better, but checking something the SourceManager calls the last line > against UINT32_MAX seem to me too much implementation detail. I also can't > see any other reason why m_last_line would be useful outside the > SourceManager. > > So maybe a better API would be >

[Lldb-commits] [lldb] [lldb] print a notice when `source list` paging reaches the end of th… (PR #137515)

2025-04-29 Thread via lldb-commits
https://github.com/hapee updated https://github.com/llvm/llvm-project/pull/137515 >From edd562c3dcaab5e6faee8392a431e517f4207d61 Mon Sep 17 00:00:00 2001 From: hapee <623151...@qq.com> Date: Sun, 27 Apr 2025 18:27:04 +0800 Subject: [PATCH] [lldb] print a notice when `source list` paging

[Lldb-commits] [lldb] [lldb] Upgrade `GetIndexOfChildWithName` to use `llvm::Expected` (PR #136693)

2025-04-29 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/136693 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] add settings to control how synthetic symbol names are generated (PR #137512)

2025-04-29 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: Today we add a made up name, `___lldb_unnamed_symbol` using an ordinal that increases for each Module. The only thing special about the ordinal is that it is repeatable if lldb is run on the same binary. Using file addresses for that ordinal would give that same result.

[Lldb-commits] [lldb] [lldb-dap] Migrate attach to typed RequestHandler. (PR #137911)

2025-04-29 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions h,cpp -- lldb/tools/lldb-dap/DAP.cpp lldb/tools/lldb-dap/Ha

[Lldb-commits] [lldb] [lldb-dap] Migrate attach to typed RequestHandler. (PR #137911)

2025-04-29 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: John Harrison (ashgti) Changes This updates the `attach` request to the typed `RequestHandler`. Added a few more overlapping configurations to `lldb_dap::protocol::Configuration

[Lldb-commits] [lldb] [lldb-dap] Migrate attach to typed RequestHandler. (PR #137911)

2025-04-29 Thread John Harrison via lldb-commits
https://github.com/ashgti created https://github.com/llvm/llvm-project/pull/137911 This updates the `attach` request to the typed `RequestHandler`. Added a few more overlapping configurations to `lldb_dap::protocol::Configuration` that are shared between launching and attaching. There may b

[Lldb-commits] [lldb] [lldb-dap] Add an RAII helper for synchronous mode (NFC) (PR #137900)

2025-04-29 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/137900 >From e545b973e426c81e5f763eb92f157343e889b46a Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Tue, 29 Apr 2025 16:48:19 -0700 Subject: [PATCH] [lldb-dap] Add an RAII helper for synchronous mode (NFC

[Lldb-commits] [lldb] [lldb-dap] Add an RAII helper for synchronous mode (NFC) (PR #137900)

2025-04-29 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes While debugging the flakiness of the launch and attach tests, I noticed that we have some places in lldb-dap where we put the debugger in synchronous mode and have an early exit, that would leave th

[Lldb-commits] [lldb] [lldb-dap] Add an RAII helper for synchronous mode (NFC) (PR #137900)

2025-04-29 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/137900 While debugging the flakiness of the launch and attach tests, I noticed that we have some places in lldb-dap where we put the debugger in synchronous mode and have an early exit, that would leave the debug

[Lldb-commits] [lldb] [lldb] Upstream lldb-rpc-gen and LLDB RPC server-side emitters (PR #136748)

2025-04-29 Thread Chelsea Cassanova via lldb-commits
@@ -0,0 +1,19 @@ +if(LLDB_CODESIGN_IDENTITY) + # Use explicit LLDB identity + set(LLVM_CODESIGNING_IDENTITY ${LLDB_CODESIGN_IDENTITY}) +else() + # Use explicit LLVM identity or default to ad-hoc signing if empty + if(NOT LLVM_CODESIGNING_IDENTITY) +set(LLVM_CODESIGNING_IDE

[Lldb-commits] [lldb] [lldb] Upstream lldb-rpc-gen and LLDB RPC server-side emitters (PR #136748)

2025-04-29 Thread Chelsea Cassanova via lldb-commits
chelcassanova wrote: > So could you draft something like that? Separate PR from this. Absolutely! I know this is a lot of code to review, so anything that can be done to break all this down is more than something I'm willing to do. I can write up a design doc in order to better explain exactly

[Lldb-commits] [lldb] f73db3d - [lldb-dap[test] Don't pass --listen to debugserver

2025-04-29 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2025-04-29T14:59:36-07:00 New Revision: f73db3df80e6924551ea773c0d5afb54a82bc76f URL: https://github.com/llvm/llvm-project/commit/f73db3df80e6924551ea773c0d5afb54a82bc76f DIFF: https://github.com/llvm/llvm-project/commit/f73db3df80e6924551ea773c0d5afb54a82bc76f.d

[Lldb-commits] [lldb] [lldb] Upstream lldb-rpc-gen and LLDB RPC server-side emitters (PR #136748)

2025-04-29 Thread Chelsea Cassanova via lldb-commits
@@ -0,0 +1,61 @@ +#!/usr/bin/env python3 +# Usage: framework-header-version-fix.py MAJOR MINOR PATCH + +import argparse +import os +import re +import subprocess + + +def main(): +parser = argparse.ArgumentParser() +parser.add_argument("input") +parser.add_argument("

[Lldb-commits] [lldb] [lldb][test] Test all libcxxabi demangler test-cases against TrackingOutputBuffer (PR #137793)

2025-04-29 Thread Michael Buch via lldb-commits
Michael137 wrote: > > Do we really want a copy of all those test-cases in LLDB? > > Is it also in the monorepo? Can we just use a relative path to the file? Yup it is in the libcxxabi subdirectory. Is there precendent for such cross-project references ? (i guess header includes would be an exa

[Lldb-commits] [lldb] [lldb][lldb-dap] use the new protocol for setVariable requests. (PR #137803)

2025-04-29 Thread Ebuka Ezike via lldb-commits
@@ -294,6 +294,75 @@ bool fromJSON(const llvm::json::Value &, LaunchRequestArguments &, /// field is required. using LaunchResponseBody = VoidResponse; +/// Arguments for `setVariable` request. +struct SetVariableArguments { + /// The reference of the variable container. The

[Lldb-commits] [lldb] [lldb] Support alternatives for scope format entries (PR #137751)

2025-04-29 Thread Michael Buch via lldb-commits
@@ -153,10 +173,37 @@ constexpr llvm::StringRef lookupStrings[] = { "${target.file.fullpath}", "${var.dummy-var-to-test-wildcard}"}; -TEST(FormatEntity, LookupAllEntriesInTree) { +TEST_F(FormatEntityTest, LookupAllEntriesInTree) { for (const llvm::StringRef testStri

[Lldb-commits] [lldb] [lldb][lldb-dap] use the new protocol for setVariable requests. (PR #137803)

2025-04-29 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper edited https://github.com/llvm/llvm-project/pull/137803 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][lldb-dap] use the new protocol for setVariable requests. (PR #137803)

2025-04-29 Thread Ebuka Ezike via lldb-commits
@@ -430,17 +430,20 @@ class ScopesRequestHandler : public LegacyRequestHandler { void operator()(const llvm::json::Object &request) const override; }; -class SetVariableRequestHandler : public LegacyRequestHandler { +class SetVariableRequestHandler final da-

[Lldb-commits] [lldb] [lldb][test] Test all libcxxabi demangler test-cases against TrackingOutputBuffer (PR #137793)

2025-04-29 Thread Adrian Prantl via lldb-commits
adrian-prantl wrote: > Do we really want a copy of all those test-cases in LLDB? Is it also in the monorepo? Can we just use a relative path to the file? https://github.com/llvm/llvm-project/pull/137793 ___ lldb-commits mailing list lldb-commits@lists

[Lldb-commits] [lldb] [lldb][lldb-dap] use the new protocol for setVariable requests. (PR #137803)

2025-04-29 Thread John Harrison via lldb-commits
@@ -13,168 +13,66 @@ namespace lldb_dap { -// "SetVariableRequest": { -// "allOf": [ { "$ref": "#/definitions/Request" }, { -// "type": "object", -// "description": "setVariable request; value of command field is -// 'setVariable'. Set the variable with the give

[Lldb-commits] [lldb] [lldb][lldb-dap] use the new protocol for setVariable requests. (PR #137803)

2025-04-29 Thread John Harrison via lldb-commits
@@ -13,168 +13,66 @@ namespace lldb_dap { -// "SetVariableRequest": { -// "allOf": [ { "$ref": "#/definitions/Request" }, { -// "type": "object", -// "description": "setVariable request; value of command field is -// 'setVariable'. Set the variable with the give

[Lldb-commits] [lldb] [lldb][lldb-dap] use the new protocol for setVariable requests. (PR #137803)

2025-04-29 Thread John Harrison via lldb-commits
@@ -294,6 +294,75 @@ bool fromJSON(const llvm::json::Value &, LaunchRequestArguments &, /// field is required. using LaunchResponseBody = VoidResponse; +/// Arguments for `setVariable` request. +struct SetVariableArguments { + /// The reference of the variable container. The

[Lldb-commits] [lldb] [lldb][lldb-dap] use the new protocol for setVariable requests. (PR #137803)

2025-04-29 Thread John Harrison via lldb-commits
@@ -13,168 +13,66 @@ namespace lldb_dap { -// "SetVariableRequest": { -// "allOf": [ { "$ref": "#/definitions/Request" }, { -// "type": "object", -// "description": "setVariable request; value of command field is -// 'setVariable'. Set the variable with the give

[Lldb-commits] [lldb] [lldb][lldb-dap] use the new protocol for setVariable requests. (PR #137803)

2025-04-29 Thread John Harrison via lldb-commits
@@ -13,168 +13,66 @@ namespace lldb_dap { -// "SetVariableRequest": { -// "allOf": [ { "$ref": "#/definitions/Request" }, { -// "type": "object", -// "description": "setVariable request; value of command field is -// 'setVariable'. Set the variable with the give

[Lldb-commits] [lldb] [lldb][lldb-dap] use the new protocol for setVariable requests. (PR #137803)

2025-04-29 Thread John Harrison via lldb-commits
@@ -13,168 +13,66 @@ namespace lldb_dap { -// "SetVariableRequest": { -// "allOf": [ { "$ref": "#/definitions/Request" }, { -// "type": "object", -// "description": "setVariable request; value of command field is -// 'setVariable'. Set the variable with the give

[Lldb-commits] [lldb] [lldb][lldb-dap] use the new protocol for setVariable requests. (PR #137803)

2025-04-29 Thread John Harrison via lldb-commits
@@ -430,17 +430,20 @@ class ScopesRequestHandler : public LegacyRequestHandler { void operator()(const llvm::json::Object &request) const override; }; -class SetVariableRequestHandler : public LegacyRequestHandler { +class SetVariableRequestHandler final ash

[Lldb-commits] [lldb] [lldb][lldb-dap] use the new protocol for setVariable requests. (PR #137803)

2025-04-29 Thread John Harrison via lldb-commits
@@ -294,6 +294,75 @@ bool fromJSON(const llvm::json::Value &, LaunchRequestArguments &, /// field is required. using LaunchResponseBody = VoidResponse; +/// Arguments for `setVariable` request. +struct SetVariableArguments { + /// The reference of the variable container. The

[Lldb-commits] [lldb] [lldb] Support alternatives for scope format entries (PR #137751)

2025-04-29 Thread Michael Buch via lldb-commits
@@ -153,10 +173,37 @@ constexpr llvm::StringRef lookupStrings[] = { "${target.file.fullpath}", "${var.dummy-var-to-test-wildcard}"}; -TEST(FormatEntity, LookupAllEntriesInTree) { +TEST_F(FormatEntityTest, LookupAllEntriesInTree) { for (const llvm::StringRef testStri

[Lldb-commits] [lldb] [lldb] Support alternatives for scope format entries (PR #137751)

2025-04-29 Thread Jonas Devlieghere via lldb-commits
@@ -153,10 +173,37 @@ constexpr llvm::StringRef lookupStrings[] = { "${target.file.fullpath}", "${var.dummy-var-to-test-wildcard}"}; -TEST(FormatEntity, LookupAllEntriesInTree) { +TEST_F(FormatEntityTest, LookupAllEntriesInTree) { for (const llvm::StringRef testStri

[Lldb-commits] [lldb] [lldb] Support alternatives for scope format entries (PR #137751)

2025-04-29 Thread Jonas Devlieghere via lldb-commits
@@ -153,10 +173,37 @@ constexpr llvm::StringRef lookupStrings[] = { "${target.file.fullpath}", "${var.dummy-var-to-test-wildcard}"}; -TEST(FormatEntity, LookupAllEntriesInTree) { +TEST_F(FormatEntityTest, LookupAllEntriesInTree) { for (const llvm::StringRef testStri

[Lldb-commits] [lldb] [lldb] Support alternatives for scope format entries (PR #137751)

2025-04-29 Thread Michael Buch via lldb-commits
@@ -153,10 +173,37 @@ constexpr llvm::StringRef lookupStrings[] = { "${target.file.fullpath}", "${var.dummy-var-to-test-wildcard}"}; -TEST(FormatEntity, LookupAllEntriesInTree) { +TEST_F(FormatEntityTest, LookupAllEntriesInTree) { for (const llvm::StringRef testStri

[Lldb-commits] [lldb] [lldb-dap] Adding defaults to VSCode settings for user level defaults. (PR #137694)

2025-04-29 Thread John Harrison via lldb-commits
ashgti wrote: Okay, how about this, I updated the settings to break things into 2 categories "Adapter" settings and "Defaults". This is presented in the UI like this https://github.com/user-attachments/assets/5ab13737-91fb-44a3-934c-b0dd5dd782c9"; /> And removes `defaults` from the settings

[Lldb-commits] [lldb] [lldb] Upstream lldb-rpc-gen and LLDB RPC server-side emitters (PR #136748)

2025-04-29 Thread Chelsea Cassanova via lldb-commits
@@ -0,0 +1,57 @@ +#!/usr/bin/env python3 +# Usage: convert-lldb-header-to-rpc-header.py + +import argparse +import os +import re +import subprocess + + +def main(): +parser = argparse.ArgumentParser() +parser.add_argument("input") +parser.add_argument("output") +

[Lldb-commits] [lldb] [lldb] Upstream lldb-rpc-gen and LLDB RPC server-side emitters (PR #136748)

2025-04-29 Thread Chelsea Cassanova via lldb-commits
@@ -0,0 +1,57 @@ +#!/usr/bin/env python3 +# Usage: convert-lldb-header-to-rpc-header.py + +import argparse +import os +import re +import subprocess + + +def main(): +parser = argparse.ArgumentParser() +parser.add_argument("input") +parser.add_argument("output") +

[Lldb-commits] [lldb] [lldb] Upstream lldb-rpc-gen and LLDB RPC server-side emitters (PR #136748)

2025-04-29 Thread Chelsea Cassanova via lldb-commits
@@ -0,0 +1,57 @@ +#!/usr/bin/env python3 +# Usage: convert-lldb-header-to-rpc-header.py + +import argparse +import os +import re +import subprocess + + +def main(): +parser = argparse.ArgumentParser() +parser.add_argument("input") +parser.add_argument("output") +

[Lldb-commits] [lldb] [lldb-dap] Adding defaults to VSCode settings for user level defaults. (PR #137694)

2025-04-29 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/137694 >From 7de424db38e5decff9ce511bea9ff07f32509391 Mon Sep 17 00:00:00 2001 From: John Harrison Date: Mon, 28 Apr 2025 12:11:52 -0700 Subject: [PATCH 1/3] [lldb-dap] Adding defaults to VSCode settings for user level

[Lldb-commits] [lldb] [lldb] Upstream lldb-rpc-gen and LLDB RPC server-side emitters (PR #136748)

2025-04-29 Thread Chelsea Cassanova via lldb-commits
@@ -0,0 +1,57 @@ +#!/usr/bin/env python3 +# Usage: convert-lldb-header-to-rpc-header.py + +import argparse +import os +import re +import subprocess chelcassanova wrote: I'll change this, ditto for all other uses of subprocess https://github.com/llvm/llvm-proj

[Lldb-commits] [lldb] f784fa7 - [lldb] Disable TestExitDuringExpression on asan

2025-04-29 Thread Felipe de Azevedo Piovezan via lldb-commits
Author: Felipe de Azevedo Piovezan Date: 2025-04-29T12:38:51-07:00 New Revision: f784fa727543463b86511f7e5797174422cbeeaf URL: https://github.com/llvm/llvm-project/commit/f784fa727543463b86511f7e5797174422cbeeaf DIFF: https://github.com/llvm/llvm-project/commit/f784fa727543463b86511f7e579717442

[Lldb-commits] [lldb] [lldb][cmake] Add clang resource dir to LLDB shell tests config (PR #136761)

2025-04-29 Thread Chelsea Cassanova via lldb-commits
@@ -1,6 +1,12 @@ add_custom_target(lldb-shell-test-deps) set_target_properties(lldb-shell-test-deps PROPERTIES FOLDER "LLDB/Tests") add_dependencies(lldb-shell-test-deps lldb-test-depends) +if(LLDB_BUILT_STANDALONE) + get_target_property(CLANG_RESOURCE_DIR clang-resource-heade

[Lldb-commits] [lldb] [lldb][cmake] Add clang resource dir to LLDB shell tests config (PR #136761)

2025-04-29 Thread Alex Langford via lldb-commits
@@ -1,6 +1,12 @@ add_custom_target(lldb-shell-test-deps) set_target_properties(lldb-shell-test-deps PROPERTIES FOLDER "LLDB/Tests") add_dependencies(lldb-shell-test-deps lldb-test-depends) +if(LLDB_BUILT_STANDALONE) + get_target_property(CLANG_RESOURCE_DIR clang-resource-heade

[Lldb-commits] [lldb] [lldb][cmake] Add clang resource dir to LLDB shell tests config (PR #136761)

2025-04-29 Thread Alex Langford via lldb-commits
@@ -1,6 +1,12 @@ add_custom_target(lldb-shell-test-deps) set_target_properties(lldb-shell-test-deps PROPERTIES FOLDER "LLDB/Tests") add_dependencies(lldb-shell-test-deps lldb-test-depends) +if(LLDB_BUILT_STANDALONE) + get_target_property(CLANG_RESOURCE_DIR clang-resource-heade

[Lldb-commits] [lldb] [lldb][cmake] Add clang resource dir to LLDB shell tests config (PR #136761)

2025-04-29 Thread Alex Langford via lldb-commits
https://github.com/bulbazord requested changes to this pull request. Looking better, but I don't think the shell test's CMake file is the right place to calculate the resource directory. It's already calculated in `LLDBStandalone`. I think we should hoist this logic into LLDB's configuration m

[Lldb-commits] [lldb] [lldb][cmake] Add clang resource dir to LLDB shell tests config (PR #136761)

2025-04-29 Thread Alex Langford via lldb-commits
https://github.com/bulbazord edited https://github.com/llvm/llvm-project/pull/136761 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][docs] Update instructions to build standalone (PR #137383)

2025-04-29 Thread Chelsea Cassanova via lldb-commits
@@ -210,6 +210,7 @@ Clang. Then we build the ``ALL`` target with ninja: :: $ cmake -B /path/to/llvm-build -G Ninja \ + -DCMAKE_BUILD_TYPE=[] \ -DLLVM_ENABLE_PROJECTS=clang \ [] /path/to/llvm-project/llvm chelcassanova wrote: G

[Lldb-commits] [lldb] [lldb][cmake] Add clang resource dir to LLDB shell tests config (PR #136761)

2025-04-29 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/136761 >From b073c45b526d42af21e9def5f990d32ba82c5360 Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Tue, 22 Apr 2025 13:28:04 -0700 Subject: [PATCH] [lldb][cmake] Add clang resource dir to LLDB shell tes

[Lldb-commits] [lldb] Fix the lldb-dap error when empty source map is specified (PR #137722)

2025-04-29 Thread Jonas Devlieghere via lldb-commits
@@ -94,7 +93,9 @@ void BaseRequestHandler::SetSourceMapFromArguments( // Do any source remapping needed before we create our targets strm << "\".\" \"" << sourcePath << "\""; } - if (!sourceMapCommand.empty()) { + if (!sourceMapCommandMappings.empty()) { +std::s

[Lldb-commits] [lldb] Fix the lldb-dap error when empty source map is specified (PR #137722)

2025-04-29 Thread Jonas Devlieghere via lldb-commits
@@ -57,9 +57,8 @@ void BaseRequestHandler::SetSourceMapFromArguments( "source must be be an array of two-element arrays, " "each containing a source and replacement path string.\n"; - std::string sourceMapCommand; - llvm::raw_string_ostream strm(sourceMapCommand)

[Lldb-commits] [lldb] Fix the lldb-dap error when empty source map is specified (PR #137722)

2025-04-29 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGMT modulo nits https://github.com/llvm/llvm-project/pull/137722 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix the lldb-dap error when empty source map is specified (PR #137722)

2025-04-29 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/137722 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [clang][frontend] Require invocation to construct `CompilerInstance` (PR #137668)

2025-04-29 Thread Jan Svoboda via lldb-commits
https://github.com/jansvoboda11 updated https://github.com/llvm/llvm-project/pull/137668 >From 692779413664a17287a1f34d4e3225ae8bc96ae0 Mon Sep 17 00:00:00 2001 From: Jan Svoboda Date: Mon, 21 Apr 2025 11:55:43 -0700 Subject: [PATCH 1/2] [clang][frontend] Require invocation for `CompilerInstan

[Lldb-commits] [lldb] [lldb] Support alternatives for scope format entries (PR #137751)

2025-04-29 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/137751 >From b6618a2ecfe20880e323177f9683f51135b83fd6 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Mon, 28 Apr 2025 20:51:34 -0700 Subject: [PATCH] [lldb] Support alternatives for scope format entries T

[Lldb-commits] [clang] [clang-tools-extra] [lldb] Reland: [clang] preserve class type sugar when taking pointer to member (PR #132401)

2025-04-29 Thread via lldb-commits
gulfemsavrun wrote: We started seeing the following issue, and bisected to this commit. ``` test.cpp:8:12: error: no matching function for call to 'GetFieldChecked' 8 | return GetFieldChecked(b, &std::remove_reference::type::has_total); |^~~ test.cpp:6:5: no

[Lldb-commits] [lldb] [lldb][lldb-dap] Added support for "WriteMemory" request. (PR #131820)

2025-04-29 Thread Santhosh Kumar Ellendula via lldb-commits
santhoshe447 wrote: Hi, any further comments or suggestion on the changes. https://github.com/llvm/llvm-project/pull/131820 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][docs] Update instructions to build standalone (PR #137383)

2025-04-29 Thread Alex Langford via lldb-commits
@@ -210,6 +210,7 @@ Clang. Then we build the ``ALL`` target with ninja: :: $ cmake -B /path/to/llvm-build -G Ninja \ + -DCMAKE_BUILD_TYPE=[] \ -DLLVM_ENABLE_PROJECTS=clang \ [] /path/to/llvm-project/llvm bulbazord wrote: Right

[Lldb-commits] [lldb] [LLDB] Add unary operators Dereference and AddressOf to DIL (PR #134428)

2025-04-29 Thread Ilia Kuklin via lldb-commits
https://github.com/kuilpd closed https://github.com/llvm/llvm-project/pull/134428 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] d637038 - [LLDB] Add unary operators Dereference and AddressOf to DIL (#134428)

2025-04-29 Thread via lldb-commits
Author: Ilia Kuklin Date: 2025-04-29T21:29:52+05:00 New Revision: d63703842937c8a089a272297886de5fc7bdc0a4 URL: https://github.com/llvm/llvm-project/commit/d63703842937c8a089a272297886de5fc7bdc0a4 DIFF: https://github.com/llvm/llvm-project/commit/d63703842937c8a089a272297886de5fc7bdc0a4.diff L

[Lldb-commits] [lldb] [LLDB] Ptrace seize dead process (PR #137041)

2025-04-29 Thread Jacob Lalonde via lldb-commits
Jlalond wrote: > I see this is still a draft, but to avoid surprised, I want to say that I > think this should be two or three patches in the final form. One for the > PTRACE_SEIZE thingy, one for the "mechanism to prevent a process from > resuming" and maybe (depending on how involved it gets

[Lldb-commits] [lldb] [lldb] Provide an unconditional @skip annotation for API tests (PR #137712)

2025-04-29 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/137712 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 3081ec1 - [lldb] Provide an unconditional @skip annotation for API tests (#137712)

2025-04-29 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2025-04-29T08:28:43-07:00 New Revision: 3081ec12491aa2514e03fe27abf9ff44e9e332ae URL: https://github.com/llvm/llvm-project/commit/3081ec12491aa2514e03fe27abf9ff44e9e332ae DIFF: https://github.com/llvm/llvm-project/commit/3081ec12491aa2514e03fe27abf9ff44e9e332ae.d

[Lldb-commits] [lldb] cf7301a - [lldb] Disable the process architecture test on macOS as well

2025-04-29 Thread Pavel Labath via lldb-commits
Author: Pavel Labath Date: 2025-04-29T16:59:23+02:00 New Revision: cf7301aeb808a13fe882a4b0bf7f1bfe4051c301 URL: https://github.com/llvm/llvm-project/commit/cf7301aeb808a13fe882a4b0bf7f1bfe4051c301 DIFF: https://github.com/llvm/llvm-project/commit/cf7301aeb808a13fe882a4b0bf7f1bfe4051c301.diff

[Lldb-commits] [lldb] [lldb] Upgrade `GetIndexOfChildWithName` to use `llvm::Expected` (PR #136693)

2025-04-29 Thread Charles Zablit via lldb-commits
https://github.com/charles-zablit edited https://github.com/llvm/llvm-project/pull/136693 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][AIX] get host info for AIX (PR #134354)

2025-04-29 Thread Felipe de Azevedo Piovezan via lldb-commits
felipepiovezan wrote: Could you please disable/revert if the fix is not easy? https://github.com/llvm/llvm-project/pull/134354 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][AIX] get host info for AIX (PR #134354)

2025-04-29 Thread Felipe de Azevedo Piovezan via lldb-commits
felipepiovezan wrote: Hi, this test is _still_ failing on the macOS bots: https://ci.swift.org/view/all/job/llvm.org/job/lldb-cmake/11728/execution/node/111/log/ ``` /Users/ec2-user/jenkins/workspace/llvm.org/lldb-cmake/lldb-build/tools/lldb/unittests/Host/./HostTests --gtest_filter=HostTest.G

[Lldb-commits] [lldb] 55b4e5e - [lldb] Disable TestDAP_attach

2025-04-29 Thread Felipe de Azevedo Piovezan via lldb-commits
Author: Felipe de Azevedo Piovezan Date: 2025-04-29T07:18:22-07:00 New Revision: 55b4e5e5154550ba981af08ca9bd1e3da00e6fea URL: https://github.com/llvm/llvm-project/commit/55b4e5e5154550ba981af08ca9bd1e3da00e6fea DIFF: https://github.com/llvm/llvm-project/commit/55b4e5e5154550ba981af08ca9bd1e3da

[Lldb-commits] [lldb] [lldb] Fix error that lead Windows to think it could reverse execute (PR #137351)

2025-04-29 Thread David Spickett via lldb-commits
@@ -239,15 +239,15 @@ ProcessWindows::DoAttachToProcessWithID(lldb::pid_t pid, Status ProcessWindows::DoResume(RunDirection direction) { Log *log = GetLog(WindowsLog::Process); llvm::sys::ScopedLock lock(m_mutex); - Status error; if (direction == RunDirection::eRunRev

[Lldb-commits] [lldb] 65b0d21 - [lldb] Remove "error:" prefix from reverse execute error messages

2025-04-29 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2025-04-29T14:01:01Z New Revision: 65b0d21eb490aaa0c742739ce95b1acc654be22b URL: https://github.com/llvm/llvm-project/commit/65b0d21eb490aaa0c742739ce95b1acc654be22b DIFF: https://github.com/llvm/llvm-project/commit/65b0d21eb490aaa0c742739ce95b1acc654be22b.diff LOG

[Lldb-commits] [lldb] 4560ff8 - [lldb][test] Skip TestFrameFormatFunctionSuffix.test on Windows

2025-04-29 Thread Michael Buch via lldb-commits
Author: Michael Buch Date: 2025-04-29T14:25:31+01:00 New Revision: 4560ff8740c58745506c7797ec1076fd83dd7345 URL: https://github.com/llvm/llvm-project/commit/4560ff8740c58745506c7797ec1076fd83dd7345 DIFF: https://github.com/llvm/llvm-project/commit/4560ff8740c58745506c7797ec1076fd83dd7345.diff

[Lldb-commits] [lldb] [lldb][lldb-dap] use the new protocol for setVariable requests. (PR #137803)

2025-04-29 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Ebuka Ezike (da-viper) Changes ```cpp // The "id" is the unique integer ID that is unique within the enclosing // variablesReference. It is optionally added to any "interface Variable" // objects to uniquely identify a variable with

[Lldb-commits] [lldb] [lldb][lldb-dap] use the new protocol for setVariable requests. (PR #137803)

2025-04-29 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper created https://github.com/llvm/llvm-project/pull/137803 ```cpp // The "id" is the unique integer ID that is unique within the enclosing // variablesReference. It is optionally added to any "interface Variable" // objects to uniquely identify a variable withi

[Lldb-commits] [lldb] [lldb-dap] Adding defaults to VSCode settings for user level defaults. (PR #137694)

2025-04-29 Thread Ebuka Ezike via lldb-commits
da-viper wrote: looks like this ![image](https://github.com/user-attachments/assets/c1a98862-8ae4-432e-9781-cfc7f962b8cf) https://github.com/llvm/llvm-project/pull/137694 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.or

[Lldb-commits] [lldb] [lldb-dap] Adding defaults to VSCode settings for user level defaults. (PR #137694)

2025-04-29 Thread Ebuka Ezike via lldb-commits
da-viper wrote: I don't think we need the defaults in in the setting string as it makes more sense to type `lldb-dap.commandEscapePrefix` instead of `lldb-dap.defaults.commandEscapePrefix` https://github.com/llvm/llvm-project/pull/137694 ___ lldb-co

[Lldb-commits] [lldb] [lldb] Upstream lldb-rpc-gen and LLDB RPC server-side emitters (PR #136748)

2025-04-29 Thread David Spickett via lldb-commits
@@ -0,0 +1,61 @@ +#!/usr/bin/env python3 +# Usage: framework-header-version-fix.py MAJOR MINOR PATCH DavidSpickett wrote: As other files, short description here, audit your imports. https://github.com/llvm/llvm-project/pull/136748

[Lldb-commits] [lldb] [lldb] Upstream lldb-rpc-gen and LLDB RPC server-side emitters (PR #136748)

2025-04-29 Thread David Spickett via lldb-commits
@@ -0,0 +1,39 @@ +#!/usr/bin/env python3 +# Usage: framework-header-include-fix.py + +import argparse +import os +import re +import subprocess DavidSpickett wrote: Check you're using all these imports, subprocess appears unused. https://github.com/llvm/llvm-p

[Lldb-commits] [lldb] [lldb] Upstream lldb-rpc-gen and LLDB RPC server-side emitters (PR #136748)

2025-04-29 Thread David Spickett via lldb-commits
@@ -0,0 +1,535 @@ +//===-- RPCCommon.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb] Upstream lldb-rpc-gen and LLDB RPC server-side emitters (PR #136748)

2025-04-29 Thread David Spickett via lldb-commits
@@ -0,0 +1,535 @@ +//===-- RPCCommon.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb] Upstream lldb-rpc-gen and LLDB RPC server-side emitters (PR #136748)

2025-04-29 Thread David Spickett via lldb-commits
@@ -0,0 +1,39 @@ +#!/usr/bin/env python3 +# Usage: framework-header-include-fix.py + +import argparse +import os +import re +import subprocess + + +def main(): +parser = argparse.ArgumentParser() +parser.add_argument("input") +parser.add_argument("output") +args

[Lldb-commits] [lldb] [lldb] Upstream lldb-rpc-gen and LLDB RPC server-side emitters (PR #136748)

2025-04-29 Thread David Spickett via lldb-commits
@@ -0,0 +1,61 @@ +#!/usr/bin/env python3 +# Usage: framework-header-version-fix.py MAJOR MINOR PATCH DavidSpickett wrote: And the file read/write modes, use the most minimal you can. https://github.com/llvm/llvm-project/pull/136748 ___

[Lldb-commits] [lldb] [lldb] Upstream lldb-rpc-gen and LLDB RPC server-side emitters (PR #136748)

2025-04-29 Thread David Spickett via lldb-commits
@@ -0,0 +1,19 @@ +if(LLDB_CODESIGN_IDENTITY) + # Use explicit LLDB identity + set(LLVM_CODESIGNING_IDENTITY ${LLDB_CODESIGN_IDENTITY}) +else() + # Use explicit LLVM identity or default to ad-hoc signing if empty + if(NOT LLVM_CODESIGNING_IDENTITY) +set(LLVM_CODESIGNING_IDE

[Lldb-commits] [lldb] [lldb] Upstream lldb-rpc-gen and LLDB RPC server-side emitters (PR #136748)

2025-04-29 Thread David Spickett via lldb-commits
@@ -0,0 +1,61 @@ +#!/usr/bin/env python3 +# Usage: framework-header-version-fix.py MAJOR MINOR PATCH + +import argparse +import os +import re +import subprocess + + +def main(): +parser = argparse.ArgumentParser() +parser.add_argument("input") +parser.add_argument("

[Lldb-commits] [lldb] [lldb] Upstream lldb-rpc-gen and LLDB RPC server-side emitters (PR #136748)

2025-04-29 Thread David Spickett via lldb-commits
@@ -0,0 +1,57 @@ +#!/usr/bin/env python3 +# Usage: convert-lldb-header-to-rpc-header.py + +import argparse +import os +import re +import subprocess DavidSpickett wrote: Audit these imports, I think at least subprocess is unused. https://github.com/llvm/llvm-p

[Lldb-commits] [lldb] [lldb] Upstream lldb-rpc-gen and LLDB RPC server-side emitters (PR #136748)

2025-04-29 Thread David Spickett via lldb-commits
@@ -0,0 +1,39 @@ +#!/usr/bin/env python3 +# Usage: framework-header-include-fix.py DavidSpickett wrote: Add a short description of what this script does. Mainly, what is it fixing specifically? https://github.com/llvm/llvm-project/pull/136748 ___

[Lldb-commits] [lldb] [lldb] Upstream lldb-rpc-gen and LLDB RPC server-side emitters (PR #136748)

2025-04-29 Thread David Spickett via lldb-commits
@@ -0,0 +1,39 @@ +#!/usr/bin/env python3 +# Usage: framework-header-include-fix.py + +import argparse +import os +import re +import subprocess + + +def main(): +parser = argparse.ArgumentParser() +parser.add_argument("input") +parser.add_argument("output") +args

[Lldb-commits] [lldb] [lldb] Upstream lldb-rpc-gen and LLDB RPC server-side emitters (PR #136748)

2025-04-29 Thread David Spickett via lldb-commits
@@ -0,0 +1,57 @@ +#!/usr/bin/env python3 +# Usage: convert-lldb-header-to-rpc-header.py + +import argparse +import os +import re +import subprocess + + +def main(): +parser = argparse.ArgumentParser() +parser.add_argument("input") +parser.add_argument("output") +

[Lldb-commits] [lldb] [lldb] Upstream lldb-rpc-gen and LLDB RPC server-side emitters (PR #136748)

2025-04-29 Thread David Spickett via lldb-commits
@@ -0,0 +1,57 @@ +#!/usr/bin/env python3 +# Usage: convert-lldb-header-to-rpc-header.py + +import argparse +import os +import re +import subprocess + + +def main(): +parser = argparse.ArgumentParser() +parser.add_argument("input") +parser.add_argument("output") +

[Lldb-commits] [lldb] [lldb] Upstream lldb-rpc-gen and LLDB RPC server-side emitters (PR #136748)

2025-04-29 Thread David Spickett via lldb-commits
@@ -0,0 +1,57 @@ +#!/usr/bin/env python3 +# Usage: convert-lldb-header-to-rpc-header.py + +import argparse +import os +import re +import subprocess + + +def main(): +parser = argparse.ArgumentParser() +parser.add_argument("input") +parser.add_argument("output") +

[Lldb-commits] [lldb] [lldb] Upstream lldb-rpc-gen and LLDB RPC server-side emitters (PR #136748)

2025-04-29 Thread David Spickett via lldb-commits
@@ -0,0 +1,57 @@ +#!/usr/bin/env python3 +# Usage: convert-lldb-header-to-rpc-header.py + +import argparse +import os +import re +import subprocess + + +def main(): +parser = argparse.ArgumentParser() +parser.add_argument("input") +parser.add_argument("output") +

[Lldb-commits] [lldb] [lldb] Upstream lldb-rpc-gen and LLDB RPC server-side emitters (PR #136748)

2025-04-29 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett commented: This is a lot to deal with. So I have a bunch of nits on the first few files but my lack of overall understanding of the process meant I can't assess 1000s of lines of C++ implementing it. I know you explained the mechanics of this in the RFC, but, I

[Lldb-commits] [lldb] [lldb] Upstream lldb-rpc-gen and LLDB RPC server-side emitters (PR #136748)

2025-04-29 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/136748 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Test all libcxxabi demangler test-cases against TrackingOutputBuffer (PR #137793)

2025-04-29 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions inc,cpp -- lldb/unittests/Core/DemanglingCorrectness.inc ll

[Lldb-commits] [lldb] [lldb][test] Test all libcxxabi demangler test-cases against TrackingOutputBuffer (PR #137793)

2025-04-29 Thread via lldb-commits
github-actions[bot] wrote: :warning: undef deprecator found issues in your code. :warning: You can test this locally with the following command: ``bash git diff -U0 --pickaxe-regex -S '([^a-zA-Z0-9#_-]undef[^a-zA-Z0-9_-]|UndefValue::get)' 'HEAD~1' HEAD lldb/unittests/Core/Demang

[Lldb-commits] [lldb] [lldb][test] Test all libcxxabi demangler test-cases against TrackingOutputBuffer (PR #137793)

2025-04-29 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/137793 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Test all libcxxabi demangler test-cases against TrackingOutputBuffer (PR #137793)

2025-04-29 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes To test the infrastructure added in https://github.com/llvm/llvm-project/pull/131836 in would be nice to confirm that we can reconstruct all kinds of demangled names. The libcxxabi test-suite already has

  1   2   >