https://github.com/DavidSpickett commented:
This is a lot to deal with. So I have a bunch of nits on the first few files but my lack of overall understanding of the process meant I can't assess 1000s of lines of C++ implementing it. I know you explained the mechanics of this in the RFC, but, I think we should have a page on the website about it eventually anyway, and a design doc would really help review this too. So could you draft something like that? Separate PR from this. For now I'd just be looking for: * The use case of LLDB-RPC * The steps taken to generate the components of it, and what they should produce. That can remain in review while you upstream the rest of the code, and then we can think of any other sections to add before landing it. E.g. how to maintain LLDB-RPC and so on. https://github.com/llvm/llvm-project/pull/136748 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
