https://github.com/labath approved this pull request.
https://github.com/llvm/llvm-project/pull/112748
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1136,6 +1136,25 @@ ClangASTImporter::ASTImporterDelegate::ImportImpl(Decl
*From) {
void ClangASTImporter::ASTImporterDelegate::ImportDefinitionTo(
clang::Decl *to, clang::Decl *from) {
+ Log *log = GetLog(LLDBLog::Expressions);
+
+ auto getDeclName = [](Decl const *
@@ -1158,11 +1175,7 @@ void
ClangASTImporter::ASTImporterDelegate::ImportDefinitionTo(
to_tag->setCompleteDefinition(from_tag->isCompleteDefinition());
if (Log *log_ast = GetLog(LLDBLog::AST)) {
-std::string name_string;
-if (NamedDecl *from_named_
@@ -102,11 +102,9 @@ llvm::Error CommandObjectMultiword::LoadUserSubcommand(
std::string str_name(name);
- auto pos = m_subcommand_dict.find(str_name);
- if (pos == m_subcommand_dict.end()) {
-m_subcommand_dict[str_name] = cmd_obj_sp;
+ auto [pos, inserted] = m_subco
https://github.com/labath approved this pull request.
https://github.com/llvm/llvm-project/pull/112823
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,243 @@
+//===-- ObjectFileXCOFF.cpp
+//-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Kazu Hirata (kazutakahirata)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/112823.diff
1 Files Affected:
- (modified) lldb/source/Commands/CommandObjectMultiword.cpp (+2-4)
``diff
diff --git a/lldb/source/C
https://github.com/kazutakahirata created
https://github.com/llvm/llvm-project/pull/112823
None
>From 621d5b5a767daa4046dffec522c39e4bc652ac1b Mon Sep 17 00:00:00 2001
From: Kazu Hirata
Date: Thu, 17 Oct 2024 07:52:35 -0700
Subject: [PATCH] [lldb] Avoid repeated map lookups (NFC)
---
lldb/so
Author: Jason Molenda
Date: 2024-10-17T19:46:08-07:00
New Revision: 9c6f85f57a74278e4833f3da2606d80e7577d6d5
URL:
https://github.com/llvm/llvm-project/commit/9c6f85f57a74278e4833f3da2606d80e7577d6d5
DIFF:
https://github.com/llvm/llvm-project/commit/9c6f85f57a74278e4833f3da2606d80e7577d6d5.diff
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff e9eec14bb3566f6578950797559de98678f16985
e996ae0076881bc9f660f75baeb9522ff7af49e4 --e
https://github.com/ZequanWu created
https://github.com/llvm/llvm-project/pull/112811
This is the second half of https://github.com/llvm/llvm-project/pull/90008.
Essentially, it replace the work of resolving template types when we just need
the qualified names with walking the DIE tree in `DWAR
jasonmolenda wrote:
FTR I have an intel mac running the same OS as the CI bots (`LLVM host triple:
x86_64-apple-darwin22.6.0` it's macOS 13.5 aka macOS Ventura from 2022), and am
building github main so I can try to repo this failure and Alex's on this shell
test. I don't really think I'm goi
https://github.com/JDevlieghere approved this pull request.
LGTM, thanks for fixing this!
https://github.com/llvm/llvm-project/pull/112801
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-c
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Adrian Prantl (adrian-prantl)
Changes
I've been getting complaints from users being spammed by -gmodules missing file
warnings going out of control because each object file depends on an entire DAG
of PCM files that usually are all missing
https://github.com/adrian-prantl created
https://github.com/llvm/llvm-project/pull/112801
I've been getting complaints from users being spammed by -gmodules missing file
warnings going out of control because each object file depends on an entire DAG
of PCM files that usually are all missing at
kusmour wrote:
@DavidSpickett If you don't mind me asking, how do we add to release note?
Thanks in advance!
https://github.com/llvm/llvm-project/pull/112657
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mail
https://github.com/kusmour edited
https://github.com/llvm/llvm-project/pull/112657
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kusmour updated
https://github.com/llvm/llvm-project/pull/112657
>From 48831c67f07e1199145dbb5538c02f502d3f02bf Mon Sep 17 00:00:00 2001
From: Wanyi Ye
Date: Mon, 14 Oct 2024 22:37:50 -0700
Subject: [PATCH] [lldb] Fix write only file action to truncate the file
---
lldb/sou
https://github.com/clayborg updated
https://github.com/llvm/llvm-project/pull/112596
>From 890d2bcf655a2e1e58b025cc0df7b4e42956e4c6 Mon Sep 17 00:00:00 2001
From: Greg Clayton
Date: Sat, 28 Sep 2024 15:05:37 -0700
Subject: [PATCH 1/2] Add support for reading the dynamic symbol table from
progr
@@ -0,0 +1,631 @@
+## This test verifies that loading an ELF file that has no section headers can
+## load the dynamic symbol table using the DT_SYMTAB, DT_SYMENT, DT_HASH or
+## the DT_GNU_HASH .dynamic key/value pairs that are loaded via the PT_DYNAMIC
+## segment.
+##
+## This
https://github.com/Jlalond closed
https://github.com/llvm/llvm-project/pull/108448
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jacob Lalonde
Date: 2024-10-17T15:26:05-07:00
New Revision: 5033ea73bb01061feb09b3216c74619e1fbefdeb
URL:
https://github.com/llvm/llvm-project/commit/5033ea73bb01061feb09b3216c74619e1fbefdeb
DIFF:
https://github.com/llvm/llvm-project/commit/5033ea73bb01061feb09b3216c74619e1fbefdeb.diff
https://github.com/clayborg approved this pull request.
https://github.com/llvm/llvm-project/pull/108448
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -13,6 +13,13 @@
# the building of the a.out executable program. For example,
# DYLIB_ONLY := YES
#
+# When specifying one of the DYLIB_*_SOURCES variables, DYLIB_NAME
+# controls the name of the produced dylib. E.g., if set to "foo",
+# the generated dylib will be called "f
jimingham wrote:
> > > > do we have in mind any other languages that will implement this?
> > >
> > >
> > > I suspect any language wanting to implement this notion of function
> > > splitting (e.g. all the users of corosplitter) and virtual frames could
> > > have a use for this
> >
> >
> >
@@ -13,6 +13,13 @@
# the building of the a.out executable program. For example,
# DYLIB_ONLY := YES
#
+# When specifying one of the DYLIB_*_SOURCES variables, DYLIB_NAME
+# controls the name of the produced dylib. E.g., if set to "foo",
+# the generated dylib will be called "f
felipepiovezan wrote:
> > > do we have in mind any other languages that will implement this?
> >
> >
> > I suspect any language wanting to implement this notion of function
> > splitting (e.g. all the users of corosplitter) and virtual frames could
> > have a use for this
>
> We already have
@@ -363,6 +363,14 @@ class Language : public PluginInterface {
return false;
}
+ /// Returns a boolean indicating whether two symbol contexts correspond to
+ /// the same function. If the plugin has no opinion, it should return
nullopt.
+ virtual std::optional
+ Are
https://github.com/felipepiovezan updated
https://github.com/llvm/llvm-project/pull/112720
>From 231afe21bc48b3530dc11bc50a24085043807917 Mon Sep 17 00:00:00 2001
From: Felipe de Azevedo Piovezan
Date: Thu, 17 Oct 2024 06:00:31 -0700
Subject: [PATCH] [lldb] Introduce Language::AreEqualForFrameC
@@ -363,6 +363,14 @@ class Language : public PluginInterface {
return false;
}
+ /// Returns a boolean indicating whether two symbol contexts correspond to
+ /// the same function. If the plugin has no opinion, it should return
nullopt.
+ virtual std::optional
+ Are
jimingham wrote:
> > do we have in mind any other languages that will implement this?
>
> I suspect any language wanting to implement this notion of function splitting
> (e.g. all the users of corosplitter) and virtual frames could have a use for
> this
We already have `.cold` functions that
@@ -363,6 +363,14 @@ class Language : public PluginInterface {
return false;
}
+ /// Returns a boolean indicating whether two symbol contexts correspond to
+ /// the same function. If the plugin has no opinion, it should return
nullopt.
+ virtual std::optional
+ Are
jimingham wrote:
Note that a lot of lldb was written before C++11 was allowed in llvm projects.
So looking through code that hasn't been touched recently, you will likely find
constructs that could be made more efficient with some of the newer C++
gadgets. We probably shouldn't be doing chan
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Michael Buch (Michael137)
Changes
This patch emits a warning into the expression log when we call `MapImported`
on a decl which has already been imported, but with a new `to` destination
decl. In asserts builds this would lead to triggerin
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/112748
This patch emits a warning into the expression log when we call `MapImported`
on a decl which has already been imported, but with a new `to` destination
decl. In asserts builds this would lead to triggering
DhruvSrivastavaX wrote:
> This is exactly what I had in mind -- thank you.
>
> The patch looks mostly good, apart from the inline comments. My main question
> is about the "dependant modules" parsing code. AFAICT, its not actually
> functional (and not tested). Is yaml2objs xcoff backend suffi
kusmour wrote:
> What you describe makes some sense, but could you give an example of where
> this is used?
>
> Can this be triggered with `lldb program file --`? If
> so it would be good to 1. put that in the commit message in case anyone hits
> the same problem and searches the log, and 2.
@@ -0,0 +1,243 @@
+//===-- ObjectFileXCOFF.cpp
+//-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier
@@ -0,0 +1,243 @@
+//===-- ObjectFileXCOFF.cpp
+//-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier
@@ -0,0 +1,243 @@
+//===-- ObjectFileXCOFF.cpp
+//-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier
https://github.com/DhruvSrivastavaX updated
https://github.com/llvm/llvm-project/pull/111814
>From 08c9d5ae66ca857d165dc878ebd1b2e0de364a24 Mon Sep 17 00:00:00 2001
From: Dhruv-Srivastava
Date: Thu, 10 Oct 2024 02:24:42 -0500
Subject: [PATCH 1/6] Taking base file structure from ELF as reference
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/112566
>From d8369837a10f0e4750dd6c0f6c6b4467931b5012 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Wed, 16 Oct 2024 15:48:47 +0100
Subject: [PATCH 1/5] [lldb][test] Add test for ASTImporter's name conflict
res
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Michael Buch (Michael137)
Changes
Got caught out by this because simply specifying `DYLIB_CXX_SOURCES` (without
specifying `DYLIB_NAME`) resulted in linker errors because the dylib was never
built (and linked). We should probably make that
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/112735
Got caught out by this because simply specifying `DYLIB_CXX_SOURCES` (without
specifying `DYLIB_NAME`) resulted in linker errors because the dylib was never
built (and linked). We should probably make that a
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
f113a66c29b17e4937ff5d0ab67dc087fa6ee27e...110b0d6ba90be4041a880a9a9963019850782e75
lldb/
Michael137 wrote:
Skipped for now
https://github.com/llvm/llvm-project/pull/112566
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/112566
>From d8369837a10f0e4750dd6c0f6c6b4467931b5012 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Wed, 16 Oct 2024 15:48:47 +0100
Subject: [PATCH 1/4] [lldb][test] Add test for ASTImporter's name conflict
res
@@ -363,6 +363,14 @@ class Language : public PluginInterface {
return false;
}
+ /// Returns a boolean indicating whether two symbol contexts correspond to
+ /// the same function. If the plugin has no opinion, it should return
nullopt.
+ virtual std::optional
+ Are
felipepiovezan wrote:
> do we have in mind any other languages that will implement this?
I suspect any language wanting to implement this notion of function splitting
(e.g. all the users of corosplitter) and virtual frames could have a use for
this
https://github.com/llvm/llvm-project/pull/1
Author: Pavel Labath
Date: 2024-10-17T17:29:38+02:00
New Revision: 98b419ca7688aa2823df1e87f58051aaa8d9c37f
URL:
https://github.com/llvm/llvm-project/commit/98b419ca7688aa2823df1e87f58051aaa8d9c37f
DIFF:
https://github.com/llvm/llvm-project/commit/98b419ca7688aa2823df1e87f58051aaa8d9c37f.diff
https://github.com/labath closed
https://github.com/llvm/llvm-project/pull/112565
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/112276
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jonas Devlieghere
Date: 2024-10-17T08:22:56-07:00
New Revision: 4897fc44a918b8da886d48082b6cf004cf3ffe0b
URL:
https://github.com/llvm/llvm-project/commit/4897fc44a918b8da886d48082b6cf004cf3ffe0b
DIFF:
https://github.com/llvm/llvm-project/commit/4897fc44a918b8da886d48082b6cf004cf3ffe0b.d
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/112446
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jonas Devlieghere
Date: 2024-10-17T08:19:58-07:00
New Revision: 8c7f80f77505b7ff275d67a49f4f2dd07d604403
URL:
https://github.com/llvm/llvm-project/commit/8c7f80f77505b7ff275d67a49f4f2dd07d604403
DIFF:
https://github.com/llvm/llvm-project/commit/8c7f80f77505b7ff275d67a49f4f2dd07d604403.d
@@ -363,6 +363,14 @@ class Language : public PluginInterface {
return false;
}
+ /// Returns a boolean indicating whether two symbol contexts correspond to
+ /// the same function. If the plugin has no opinion, it should return
nullopt.
+ virtual std::optional
+ Are
kastiglione wrote:
do we have in mind any other languages that will implement this?
https://github.com/llvm/llvm-project/pull/112720
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/mbucko approved this pull request.
https://github.com/llvm/llvm-project/pull/111951
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kazutakahirata closed
https://github.com/llvm/llvm-project/pull/112655
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath updated
https://github.com/llvm/llvm-project/pull/112565
>From 8a531630f6b233d83f33740ce9dbbd9b3a778641 Mon Sep 17 00:00:00 2001
From: Pavel Labath
Date: Wed, 16 Oct 2024 16:54:06 +0200
Subject: [PATCH 1/4] [lldb] Don't exit the main loop when in runs out of
things to
Author: Kazu Hirata
Date: 2024-10-17T07:45:50-07:00
New Revision: 9173fd77394aa9617b235e1b146114f76c6d77d6
URL:
https://github.com/llvm/llvm-project/commit/9173fd77394aa9617b235e1b146114f76c6d77d6
DIFF:
https://github.com/llvm/llvm-project/commit/9173fd77394aa9617b235e1b146114f76c6d77d6.diff
L
labath wrote:
Thanks for the reviews.
https://github.com/llvm/llvm-project/pull/112565
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Felipe de Azevedo Piovezan (felipepiovezan)
Changes
This allows languages to provide an opinion on whether two symbol contexts are
equivalent (i.e. belong to the same function).
It is useful to drive the comparisons done by stepping plans
@@ -212,15 +209,14 @@ TEST_F(MainLoopTest, PendingCallbackTrigger) {
ASSERT_TRUE(callback2_called);
}
-// Regression test for assertion failure if a lot of callbacks end up
-// being queued after loop exits.
-TEST_F(MainLoopTest, PendingCallbackAfterLoopExited) {
+TEST_F(Mai
felipepiovezan wrote:
An example usage can be found here:
https://github.com/swiftlang/llvm-project/pull/9441
https://github.com/llvm/llvm-project/pull/112720
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mai
https://github.com/felipepiovezan created
https://github.com/llvm/llvm-project/pull/112720
This allows languages to provide an opinion on whether two symbol contexts are
equivalent (i.e. belong to the same function).
It is useful to drive the comparisons done by stepping plans that need to
en
@@ -365,10 +365,7 @@ Status MainLoopPosix::Run() {
Status error;
RunImpl impl(*this);
- // run until termination or until we run out of things to listen to
- // (m_read_fds will always contain m_trigger_pipe fd, so check for > 1)
- while (!m_terminate_request &&
---
@@ -0,0 +1,243 @@
+//===-- ObjectFileXCOFF.cpp
+//-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier
@@ -0,0 +1,243 @@
+//===-- ObjectFileXCOFF.cpp
+//-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier
https://github.com/labath commented:
This is exactly what I had in mind -- thank you.
The patch looks mostly good, apart from the inline comments. My main question
is about the "dependant modules" parsing code. AFAICT, its not actually
functional (and not tested). Is yaml2objs xcoff backend su
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/111814
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,243 @@
+//===-- ObjectFileXCOFF.cpp
+//-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier
@@ -0,0 +1,243 @@
+//===-- ObjectFileXCOFF.cpp
+//-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier
@@ -0,0 +1,116 @@
+//===-- ObjectFileXCOFF.h --- -*- C++
+//-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier
@@ -0,0 +1,243 @@
+//===-- ObjectFileXCOFF.cpp
+//-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier
https://github.com/DhruvSrivastavaX edited
https://github.com/llvm/llvm-project/pull/111814
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
felipepiovezan wrote:
Thanks for finding those, there are many places in LLDB doing repeated work
like this!
https://github.com/llvm/llvm-project/pull/112655
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mail
labath wrote:
It would be nice to have a test which verifies actual behavior rather than just
some flag being set somewhere. For example, you could add to/extend
`test/API/python_api/process/io/TestProcessIO.py` so that it writes some
initial data to the output file, and then verify that the
https://github.com/labath approved this pull request.
https://github.com/llvm/llvm-project/pull/112446
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/112582
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath commented:
If you can't reproduce this, I can take a look, but I think the failures are
likely due to the string length problems.
https://github.com/llvm/llvm-project/pull/112582
___
lldb-commits mailing list
lldb-commits@lis
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/112582
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -76,6 +76,46 @@ using namespace lldb_private::line_editor;
#endif // #if LLDB_EDITLINE_USE_WCHAR
+#if LLDB_EDITLINE_USE_WCHAR
+std::string ToBytes(const std::wstring &in) {
+ static std::locale locale("C.UTF-8");
+ static const auto &cvt =
+ std::use_facet>(locale);
@@ -76,6 +76,46 @@ using namespace lldb_private::line_editor;
#endif // #if LLDB_EDITLINE_USE_WCHAR
+#if LLDB_EDITLINE_USE_WCHAR
+std::string ToBytes(const std::wstring &in) {
+ static std::locale locale("C.UTF-8");
+ static const auto &cvt =
+ std::use_facet>(locale);
@@ -76,6 +76,46 @@ using namespace lldb_private::line_editor;
#endif // #if LLDB_EDITLINE_USE_WCHAR
+#if LLDB_EDITLINE_USE_WCHAR
+std::string ToBytes(const std::wstring &in) {
+ static std::locale locale("C.UTF-8");
+ static const auto &cvt =
+ std::use_facet>(locale);
DavidSpickett wrote:
Not sure what's going on with the register formatting. It might be that because
we do a substring comparison, `foo = 0x00` is found in `foo = 0x`.
So I would recommend loading the core file manually and just copying whatever
`register read` shows. If the formatting
https://github.com/ldrumm closed https://github.com/llvm/llvm-project/pull/86318
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ldrumm wrote:
I've let this patch stew for long enough, and I think it's now time. The
spurious test failures in files unchanged by this patch have gone away. After
re-reading the discussion above I'm ready to merge these changes.
There's been a good discussion, which helped me polish this a f
@@ -44,6 +44,8 @@
#include "llvm/Support/MathExtras.h"
#include "llvm/Support/MemoryBuffer.h"
#include "llvm/Support/MipsABIFlags.h"
+#include "lldb/Target/Process.h"
+
labath wrote:
btw, this grouping of include blocks with empty lines is an lldb-ism (other
@@ -0,0 +1,631 @@
+## This test verifies that loading an ELF file that has no section headers can
+## load the dynamic symbol table using the DT_SYMTAB, DT_SYMENT, DT_HASH or
+## the DT_GNU_HASH .dynamic key/value pairs that are loaded via the PT_DYNAMIC
+## segment.
+##
+## This
@@ -3895,3 +3924,103 @@ std::optional
ObjectFileELF::GetDynamicData() {
}
return std::nullopt;
}
+
+
+std::optional
+ObjectFileELF::GetDynsymDataFromDynamic(uint32_t &num_symbols) {
+ // Every ELF file which represents an executable or shared library has
+ // mandatory .
@@ -3895,3 +3924,103 @@ std::optional
ObjectFileELF::GetDynamicData() {
}
return std::nullopt;
}
+
+
+std::optional
+ObjectFileELF::GetDynsymDataFromDynamic(uint32_t &num_symbols) {
+ // Every ELF file which represents an executable or shared library has
+ // mandatory .
@@ -3895,3 +3924,103 @@ std::optional
ObjectFileELF::GetDynamicData() {
}
return std::nullopt;
}
+
+
+std::optional
+ObjectFileELF::GetDynsymDataFromDynamic(uint32_t &num_symbols) {
+ // Every ELF file which represents an executable or shared library has
+ // mandatory .
@@ -3895,3 +3924,103 @@ std::optional
ObjectFileELF::GetDynamicData() {
}
return std::nullopt;
}
+
+
+std::optional
+ObjectFileELF::GetDynsymDataFromDynamic(uint32_t &num_symbols) {
+ // Every ELF file which represents an executable or shared library has
+ // mandatory .
Michael137 wrote:
> I think this is one of those tests that should really be an API test. As far
> as I can tell, there's nothing darwin-specific about this bug -- except for
> the fact that building shared libraries in a cross-platform manner is hard.
> But the API tests have wrappers that le
https://github.com/mgorny approved this pull request.
I guess LGTM but I haven't given it really deep thought.
https://github.com/llvm/llvm-project/pull/112565
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mai
lawn123 wrote:
> You may be able to reduce the file by changing the
> `/proc/pid/coredump_filter` value:
> https://man7.org/linux/man-pages/man5/core.5.html
I reduced the core file size to 36kb.
https://github.com/llvm/llvm-project/pull/112296
__
https://github.com/lawn123 updated
https://github.com/llvm/llvm-project/pull/112296
>From ba485de763a08f6ff3c7468c1a1bfbbfb25ac48f Mon Sep 17 00:00:00 2001
From: Liu An
Date: Tue, 15 Oct 2024 10:31:35 +0800
Subject: [PATCH 1/4] [LoongArch64]: Add support for LoongArch64 in elf-core
for lldb
-
@@ -833,6 +845,107 @@ def test_riscv64_regs_gpr_only(self):
substrs=["registers were unavailable"],
)
+@skipIfLLVMTargetMissing("LoongArch")
lawn123 wrote:
> Is LoongArch one LLVM target or do you need to specifically have LoongArch64
@@ -833,6 +845,107 @@ def test_riscv64_regs_gpr_only(self):
substrs=["registers were unavailable"],
)
+@skipIfLLVMTargetMissing("LoongArch")
+def test_loongarch64_regs(self):
+# check registers using 64 bit LoongArch64 core file containing
1 - 100 of 137 matches
Mail list logo
