ldrumm wrote: I've let this patch stew for long enough, and I think it's now time. The spurious test failures in files unchanged by this patch have gone away. After re-reading the discussion above I'm ready to merge these changes.
There's been a good discussion, which helped me polish this a fair bit, and a few contentions which needed clarifying or ironing out. The main contention seems to have been that what's stored in git's database is always LF - even for for windows users or files that *need* CRLF endings (e.g. `.bat`). As I pointed out in a few comments (e.g.[1](https://github.com/llvm/llvm-project/pull/86318#issuecomment-2078216855),[2](https://github.com/llvm/llvm-project/pull/86318#issuecomment-2078219678),[3](https://github.com/llvm/llvm-project/pull/86318#issuecomment-2078259364)) it may be unintuitive to store everything in git's internal database with normalized LF, but it's how git *checks them out* that's important, and I believe I've ironed out any issues here by tracking down files and testcases that depend on a particular line-ending style and adding rules for them. For those who had such concerns, I believe I've clarified the principal and pointed out the practicalities that will make life *easier* for windows *and* unix contributors. To summarize: **No user should need adjust their local config as a result of this change** - Adrian is in favour - Fangrui Song has approved - Chris Bienemann has approved - Reid Kleckner had some concerns but they were clarified - Mehdi Amini approves in principle - Florian had some concerns I *believe* we addressed. - Aaron and Saleem had some objections that I *believe* I addressed in [this comment](https://github.com/llvm/llvm-project/pull/86318#issuecomment-2078259364) since I pointed out that the files will be checked out with the correct line endings on *all* systems - regardless of local config. I'll keep an eye on this, and will be happy to react to any issues that arise over the next week or so. Thanks for all the input. https://github.com/llvm/llvm-project/pull/86318 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
