DavidSpickett wrote:

Not sure what's going on with the register formatting. It might be that because 
we do a substring comparison, `foo = 0x00` is found in `foo = 0x00000000`.

So I would recommend loading the core file manually and just copying whatever 
`register read` shows. If the formatting is still off, potentially you need to 
update the register sizes or formatting style, but I don't think you need to do 
that in this PR. It can be a follow up to do just that.

Other than that I don't have any objections here, seems like @SixWeining is the 
architecture expert so they can give the final approval.

https://github.com/llvm/llvm-project/pull/112296
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to