[Lldb-commits] [PATCH] D158043: [lldb][NFCI] Module constructor should take ConstString by value

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, jingham, mib, aprantl. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. ConstStrings are super cheap to copy around. It is often

[Lldb-commits] [PATCH] D158023: [lldb] Simplify the LLDB website structure

bulbazord added a comment. I think the categories you've set are the same ones I would have created. May I suggest renaming `Extending LLDB` to `Scripting LLDB` or something similar? I think "Extending" and "Developing" are close enough in meaning that it may be confusing to end users. CHANGE

[Lldb-commits] [PATCH] D158022: [lldb] Print an actionable error message when sphinx_automodapi is not installed

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. From the discussion this sounds like a reasonable thing to do. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158022/new/ https://reviews.llvm.org/D158022 __

[Lldb-commits] [PATCH] D158041: [lldb] [gdb-remote] Also handle high/low memory addressable bits setting in the stop info packet

jasonmolenda created this revision. jasonmolenda added a reviewer: JDevlieghere. jasonmolenda added a project: LLDB. Herald added a project: All. jasonmolenda requested review of this revision. Herald added a subscriber: lldb-commits. A small follow on patch to https://reviews.llvm.org/D157667 to

[Lldb-commits] [PATCH] D158022: [lldb] Print an actionable error message when sphinx_automodapi is not installed

JDevlieghere added a comment. In D158022#4590291 , @mib wrote: > We should really add a `requirements.txt` file with all the dependencies. I've long wanted to make this all automated, and have CMake install all the necessary dependencies. But that seems

[Lldb-commits] [PATCH] D158022: [lldb] Print an actionable error message when sphinx_automodapi is not installed

mib added a comment. We should really add a `requirements.txt` file with all the dependencies. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158022/new/ https://reviews.llvm.org/D158022 ___ lldb-commits mailing list lldb-commits@lists.llvm.or

[Lldb-commits] [PATCH] D158035: [lldb] Protect RNBRemote from a data race

JDevlieghere added inline comments. Comment at: lldb/tools/debugserver/source/RNBRemote.cpp:780 PThreadMutex::Locker locker(m_mutex); if (m_rx_packets.empty()) { This is an RAII object, right? Can we just block scope it? Right now it looks like we might

[Lldb-commits] [PATCH] D158034: [lldb] Fix data race in ThreadList

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158034/new/ https://reviews.llvm.org/D158034 ___

[Lldb-commits] [PATCH] D158035: [lldb] Protect RNBRemote from a data race

augusto2112 created this revision. augusto2112 added reviewers: JDevlieghere, bulbazord, jingham. Herald added a subscriber: kristof.beyls. Herald added a project: All. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Thread sani

[Lldb-commits] [PATCH] D158034: [lldb] Fix data race in ThreadList

augusto2112 created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. ThreadSanitizer reports the following issue: Write of size 8 at 0x00010

[Lldb-commits] [lldb] 3b91957 - Revert "[lldb] Properly protect the Communication class with reader/writer lock"

Author: Augusto Noronha Date: 2023-08-15T16:03:28-07:00 New Revision: 3b919570f2f08581987de7851f3673352afb1578 URL: https://github.com/llvm/llvm-project/commit/3b919570f2f08581987de7851f3673352afb1578 DIFF: https://github.com/llvm/llvm-project/commit/3b919570f2f08581987de7851f3673352afb1578.dif

[Lldb-commits] [PATCH] D157760: [lldb] Properly protect the Communication class with reader/writer lock

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG5d16957207ce: [lldb] Properly protect the Communication class with reader/writer lock (authored by augusto2112). Reposito

[Lldb-commits] [lldb] 5d16957 - [lldb] Properly protect the Communication class with reader/writer lock

Author: Augusto Noronha Date: 2023-08-15T15:43:36-07:00 New Revision: 5d16957207ce1bd1a2091f3677e176012009c59a URL: https://github.com/llvm/llvm-project/commit/5d16957207ce1bd1a2091f3677e176012009c59a DIFF: https://github.com/llvm/llvm-project/commit/5d16957207ce1bd1a2091f3677e176012009c59a.dif

[Lldb-commits] [PATCH] D157992: [lldb][CPlusPlus][NFCI] Remove redundant construction of ClangASTImporter

This revision was automatically updated to reflect the committed changes. Closed by commit rG92d7254a989d: [lldb][CPlusPlus][NFCI] Remove redundant construction of ClangASTImporter (authored by Michael137). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[Lldb-commits] [lldb] 92d7254 - [lldb][CPlusPlus][NFCI] Remove redundant construction of ClangASTImporter

Author: Michael Buch Date: 2023-08-15T23:09:59+01:00 New Revision: 92d7254a989d106ba63e64d315dbb9397c275671 URL: https://github.com/llvm/llvm-project/commit/92d7254a989d106ba63e64d315dbb9397c275671 DIFF: https://github.com/llvm/llvm-project/commit/92d7254a989d106ba63e64d315dbb9397c275671.diff

[Lldb-commits] [PATCH] D157556: Replace the singleton "ShadowListener" with a primary and N secondary listeners

jingham marked 4 inline comments as done. jingham added a comment. I implemented Alex's suggestion for a GetListeners filter, but doing that triggered some bugs due to the fact that we weren't really pruning the m_listeners correctly as listeners come and go. I fixed some bugs there along with

[Lldb-commits] [PATCH] D158017: [lldb][NFCI] Rewrite error-handling code in ProcessGDBRemote::MonitorDebugserverProcess

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:3379-3385 + const char *signal_name = process_sp->GetUnixSignals()->

[Lldb-commits] [PATCH] D157556: Replace the singleton "ShadowListener" with a primary and N secondary listeners

jingham updated this revision to Diff 550495. jingham added a comment. Respond to review comments. In the course of implementing Alex's suggestion to add a filter to GetListeners, I noticed that there we were being lax in our dealing with removed listeners. RemoveListener didn't actually do th

[Lldb-commits] [PATCH] D157960: [lldb][gui] Update TreeItem children's m_parent on move

clayborg accepted this revision. clayborg added inline comments. This revision is now accepted and ready to land. Comment at: lldb/test/API/commands/gui/spawn-threads/TestGuiSpawnThreads.py:38 +for i in range(5): +# Stopped at the breakpoit, continue over the

[Lldb-commits] [PATCH] D158026: [lldb][NFCI] Remove unneeded ConstString from ValueObject::GetValueForExpressionPath_Impl

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, kastiglione, jingham. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://revie

[Lldb-commits] [PATCH] D157648: [lldb] Fix data race in Process

augusto2112 added a comment. @JDevlieghere do you have any opinions on this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157648/new/ https://reviews.llvm.org/D157648 ___ lldb-commits mailing list lldb-

[Lldb-commits] [PATCH] D158024: [lldb][NFCI] Remove unused method overload of ValueObject::GetChildAtNamePath

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, kastiglione, jingham. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.ll

[Lldb-commits] [lldb] d70d5e9 - Get binary UUID from fixed location in special Mach-O corefiles

Author: Jason Molenda Date: 2023-08-15T13:49:57-07:00 New Revision: d70d5e9f6fa2770f9a5e7be4ba6b3512f5424968 URL: https://github.com/llvm/llvm-project/commit/d70d5e9f6fa2770f9a5e7be4ba6b3512f5424968 DIFF: https://github.com/llvm/llvm-project/commit/d70d5e9f6fa2770f9a5e7be4ba6b3512f5424968.diff

[Lldb-commits] [PATCH] D158023: [lldb] Simplify the LLDB website structure

JDevlieghere created this revision. JDevlieghere added a reviewer: LLDB. Herald added a subscriber: arphaman. Herald added a project: All. JDevlieghere requested review of this revision. Feedback I hear regularly is that the LLDB website is hard to navigate. This patch is an attempt to simplify t

[Lldb-commits] [PATCH] D158022: [lldb] Print an actionable error message when sphinx_automodapi is not installed

JDevlieghere created this revision. JDevlieghere added a reviewer: LLDB. Herald added a project: All. JDevlieghere requested review of this revision. Print an error message with instructions on how to install sphinx_automodapi. https://reviews.llvm.org/D158022 Files: lldb/docs/conf.py Index

[Lldb-commits] [lldb] 5ed62c7 - Added a use of uuid_t, need to incl AppleUuidCompatibility.h

Author: Jason Molenda Date: 2023-08-15T13:52:37-07:00 New Revision: 5ed62c7bc99a979261d34e41aaca9581577674bf URL: https://github.com/llvm/llvm-project/commit/5ed62c7bc99a979261d34e41aaca9581577674bf DIFF: https://github.com/llvm/llvm-project/commit/5ed62c7bc99a979261d34e41aaca9581577674bf.diff

[Lldb-commits] [PATCH] D157756: Support corefiles that put the uuid of their binary in a fixed address in low memory; load that binary

This revision was automatically updated to reflect the committed changes. Closed by commit rGd70d5e9f6fa2: Get binary UUID from fixed location in special Mach-O corefiles (authored by jasonmolenda). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15775

[Lldb-commits] [PATCH] D158010: [lldb] Allow synthetic providers in C++ and fix linking problems

electriclilies added inline comments. Comment at: lldb/source/Commands/CommandObjectType.cpp:2174 -#if LLDB_ENABLE_PYTHON - jingham wrote: > electriclilies wrote: > > rriddle wrote: > > > Why is this dropped? > > Walter and I want to use the synthetic types fro

[Lldb-commits] [lldb] 3ad618f - Update qHostInfo/LC_NOTE so multiple address bits can be specified

Author: Jason Molenda Date: 2023-08-15T13:21:33-07:00 New Revision: 3ad618f4aea1ef7442f7ff75d92632aec177a4fd URL: https://github.com/llvm/llvm-project/commit/3ad618f4aea1ef7442f7ff75d92632aec177a4fd DIFF: https://github.com/llvm/llvm-project/commit/3ad618f4aea1ef7442f7ff75d92632aec177a4fd.diff

[Lldb-commits] [PATCH] D158017: [lldb][NFCI] Rewrite error-handling code in ProcessGDBRemote::MonitorDebugserverProcess

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, jasonmolenda, jingham, mib. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. I'm rewriting this for 2 reasons: 1. Although a 10

[Lldb-commits] [PATCH] D157667: Define qHostInfo and Mach-O LC_NOTE "addrable bits" methods to describe high and low memory addressing bits

This revision was automatically updated to reflect the committed changes. Closed by commit rG3ad618f4aea1: Update qHostInfo/LC_NOTE so multiple address bits can be specified (authored by jasonmolenda). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15

[Lldb-commits] [PATCH] D158010: [lldb] Allow synthetic providers in C++ and fix linking problems

jingham added inline comments. Comment at: lldb/source/Commands/CommandObjectType.cpp:2174 -#if LLDB_ENABLE_PYTHON - electriclilies wrote: > rriddle wrote: > > Why is this dropped? > Walter and I want to use the synthetic types from C++, but right now it's > o

[Lldb-commits] [PATCH] D157851: [lldb/crashlog] Add support for Last Exception Backtrace

mib added inline comments. Comment at: lldb/examples/python/crashlog.py:800-806 +thread = self.crashlog.Thread( +len(self.crashlog.threads), True, self.crashlog.process_arch +) +thread.queue = "Application Specific Backtrace" +for backt

[Lldb-commits] [PATCH] D157851: [lldb/crashlog] Add support for Last Exception Backtrace

bulbazord added inline comments. Comment at: lldb/examples/python/crashlog.py:800-806 +thread = self.crashlog.Thread( +len(self.crashlog.threads), True, self.crashlog.process_arch +) +thread.queue = "Application Specific Backtrace" +for

[Lldb-commits] [PATCH] D157852: [lldb/crashlog] Skip non-crashed threads in batch mode

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157852/new/ https://reviews.llvm.org/D157852 ___

[Lldb-commits] [lldb] 04da749 - [lldb] Fix warnings

Author: Kazu Hirata Date: 2023-08-15T12:46:36-07:00 New Revision: 04da7490d85dab7f2f97d0a782b674088bc5a10f URL: https://github.com/llvm/llvm-project/commit/04da7490d85dab7f2f97d0a782b674088bc5a10f DIFF: https://github.com/llvm/llvm-project/commit/04da7490d85dab7f2f97d0a782b674088bc5a10f.diff L

[Lldb-commits] [lldb] 2241364 - [lldb] Fix data race in PipePosix

Author: Augusto Noronha Date: 2023-08-15T11:30:35-07:00 New Revision: 22413641e236ebee7485ce8bc5880e8d1e41573f URL: https://github.com/llvm/llvm-project/commit/22413641e236ebee7485ce8bc5880e8d1e41573f DIFF: https://github.com/llvm/llvm-project/commit/22413641e236ebee7485ce8bc5880e8d1e41573f.dif

[Lldb-commits] [lldb] 4a390a5 - [lldb] Implement ModuleList::Swap

Author: Augusto Noronha Date: 2023-08-15T11:33:34-07:00 New Revision: 4a390a56aeeb521d0eca1fa4cef6837157ea64ab URL: https://github.com/llvm/llvm-project/commit/4a390a56aeeb521d0eca1fa4cef6837157ea64ab DIFF: https://github.com/llvm/llvm-project/commit/4a390a56aeeb521d0eca1fa4cef6837157ea64ab.dif

[Lldb-commits] [PATCH] D158010: [lldb] Allow synthetic providers in C++ and fix linking problems

electriclilies added inline comments. Comment at: lldb/include/lldb/DataFormatters/TypeSynthetic.h:257-262 + virtual bool IsScripted(); - virtual std::string GetDescription() = 0; + virtual std::string GetDescription(); virtual SyntheticChildrenFrontEnd::AutoPointer +

[Lldb-commits] [PATCH] D158010: [lldb] Allow synthetic providers in C++ and fix linking problems

rriddle added a comment. Moving the constructor/destructor to the cpp file makes sense to remove the "undefined reference to vtable" issues that we've seen before, but I don't understand the changes to pure virtual methods or the removal of the LLDB_ENABLE_PYTHON checks. Can you elaborate more?

[Lldb-commits] [PATCH] D158009: [lldb] Enable synthetic providers in C++

electriclilies abandoned this revision. electriclilies added a comment. Abandoning this since I messed up when updating, changes are now at https://reviews.llvm.org/D158010 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158009/new/ https://reviews.

[Lldb-commits] [PATCH] D158010: [lldb] Allow synthetic providers in C++ and fix linking problems

bulbazord added reviewers: jingham, augusto2112, kastiglione. bulbazord added a comment. Herald added a subscriber: JDevlieghere. Adding a few relevant reviewers :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158010/new/ https://reviews.llvm.org/

[Lldb-commits] [PATCH] D158010: [lldb] Allow synthetic providers in C++ and fix linking problems

electriclilies created this revision. Herald added a project: All. electriclilies requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Allow the definition of synthetic formatters in C++, and fix linking problems with the CXXSyntheticChildren

[Lldb-commits] [PATCH] D151567: [LLVM][Support] Report EISDIR when opening a directory on AIX

MaskRay requested changes to this revision. MaskRay added a comment. This revision now requires changes to proceed. Thanks for the patch, but there are two issues that should be fixed: (1) stat => fstat (2) change the subject to mean that this is not AIX specific (`[LLVM][Support] Report EISDIR

[Lldb-commits] [PATCH] D158009: [lldb] Enable synthetic providers in C++

electriclilies added a comment. Hangon reviewers, I forgot to squash my commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158009/new/ https://reviews.llvm.org/D158009 ___ lldb-commits mailing list l

[Lldb-commits] [PATCH] D158009: [lldb] Enable synthetic providers in C++

electriclilies created this revision. Herald added a project: All. electriclilies requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D158009 Files: lldb/include/lldb/Core/Value

[Lldb-commits] [PATCH] D157654: [lldb] Fix data race in PipePosix

This revision was automatically updated to reflect the committed changes. Closed by commit rG22413641e236: [lldb] Fix data race in PipePosix (authored by augusto2112). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157654/new/ https://reviews.llvm.or

[Lldb-commits] [lldb] f2ec73c - [lldb] Move deprecation message from implementation to header (NFC)

Author: Jonas Devlieghere Date: 2023-08-15T10:41:11-07:00 New Revision: f2ec73c746504978cda96914a03952f65a29dd67 URL: https://github.com/llvm/llvm-project/commit/f2ec73c746504978cda96914a03952f65a29dd67 DIFF: https://github.com/llvm/llvm-project/commit/f2ec73c746504978cda96914a03952f65a29dd67.d

[Lldb-commits] [PATCH] D151567: [LLVM][Support] Report EISDIR when opening a directory on AIX

azhan92 updated this revision to Diff 550402. azhan92 added a comment. Address TOCTOU condition (will add updated test later). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151567/new/ https://reviews.llvm.org/D151567 Files: llvm/lib/Support/Uni

[Lldb-commits] [lldb] 23312cd - [lldb] Remove {Get, Set}CloseInputOnEOF and deprecate SB equivalent (NFC)

Author: Jonas Devlieghere Date: 2023-08-15T10:37:04-07:00 New Revision: 23312cde45b964b24b2c9f3aa2ff45a45174a8d9 URL: https://github.com/llvm/llvm-project/commit/23312cde45b964b24b2c9f3aa2ff45a45174a8d9 DIFF: https://github.com/llvm/llvm-project/commit/23312cde45b964b24b2c9f3aa2ff45a45174a8d9.d

[Lldb-commits] [PATCH] D157850: [lldb/crashlog] Fix module loading for crashed thread behaviour

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157850/new/ https://reviews.llvm.org/D157850 ___

[Lldb-commits] [PATCH] D158000: [lldb] Remove {Get, Set}CloseInputOnEOF and deprecate SB equivalent (NFC)

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lldb/source/API/SBDebugger.cpp:1538-1545 +LLDB_DEPRECATED("SBDebugger::GetCloseInputOnEOF() is deprecated.") bool SBDebugger::GetCloseInputOnEOF() const { LLDB_INSTRUMENT_VA(this);

[Lldb-commits] [PATCH] D158000: [lldb] Remove {Get, Set}CloseInputOnEOF and deprecate SB equivalent (NFC)

bulbazord added inline comments. Comment at: lldb/source/API/SBDebugger.cpp:1538-1545 +LLDB_DEPRECATED("SBDebugger::GetCloseInputOnEOF() is deprecated.") bool SBDebugger::GetCloseInputOnEOF() const { LLDB_INSTRUMENT_VA(this); - return (m_opaque_sp ? m_opaque_sp->GetCloseIn

[Lldb-commits] [PATCH] D158000: [lldb] Remove {Get, Set}CloseInputOnEOF and deprecate SB equivalent (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG23312cde45b9: [lldb] Remove {Get,Set}CloseInputOnEOF and deprecate SB equivalent (NFC) (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D158000

[Lldb-commits] [PATCH] D158000: [lldb] Remove {Get, Set}CloseInputOnEOF and deprecate SB equivalent (NFC)

JDevlieghere created this revision. JDevlieghere added reviewers: bulbazord, clayborg. Herald added a project: All. JDevlieghere requested review of this revision. These functions have been NO-OPs since 2014 (44d937820b451). Remove them and deprecate the corresponding functions in SBDebugger. ht

[Lldb-commits] [PATCH] D157992: [lldb][CPlusPlus][NFCI] Remove redundant construction of ClangASTImporter

Michael137 created this revision. Michael137 added a reviewer: aprantl. Herald added a subscriber: martong. Herald added a reviewer: a.sidorin. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The usag

[Lldb-commits] [PATCH] D157883: [lldb][AArch64] Add SME's Array Storage (ZA) and streaming vector length (SVG) registers

DavidSpickett updated this revision to Diff 550290. DavidSpickett added a comment. Remove redundant get process calls in TestSVEThreadedDynamic.py. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157883/new/ https://reviews.llvm.org/D157883 Files:

[Lldb-commits] [PATCH] D157883: [lldb][AArch64] Add SME's Array Storage (ZA) and streaming vector length (SVG) registers

DavidSpickett updated this revision to Diff 550289. DavidSpickett added a comment. Replace missing process variable in TestZAThreadedDynamic. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157883/new/ https://reviews.llvm.org/D157883 Files: lldb/

[Lldb-commits] [PATCH] D157967: [lldb][AArch64] Use atomics to sync threads in SVE threading test

DavidSpickett added a reviewer: omjavaid. DavidSpickett added a comment. I was not able to reproduce the bot's timeout situation with this or the previous implementation, but I did run this on a loop with `stress` in the background and didn't get any failures. I think doing it with atomics is at

[Lldb-commits] [PATCH] D157967: [lldb][AArch64] Use atomics to sync threads in SVE threading test

DavidSpickett added a comment. One recent example of a timeout on the Graviton bot: https://lab.llvm.org/buildbot/#/builders/96/builds/43649 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157967/new/ https://reviews.llvm.org/D157967 __

[Lldb-commits] [PATCH] D157967: [lldb][AArch64] Use atomics to sync threads in SVE threading test

DavidSpickett created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Previously we would "process continue" then wait for the number of thr

[Lldb-commits] [PATCH] D157883: [lldb][AArch64] Add SME's Array Storage (ZA) and streaming vector length (SVG) registers

DavidSpickett updated this revision to Diff 550250. DavidSpickett added a comment. In TestZAThreadedDynamic.py, replace the while < 3 threads check in Python with atomic variables in the program file. This fixes a situation where the first "process continue" hits the breakpoint in thread 2, and w

[Lldb-commits] [PATCH] D157960: [lldb][gui] Update TreeItem children's m_parent on move

kpdev42 created this revision. kpdev42 added reviewers: clayborg, davide, k8stone. kpdev42 added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. kpdev42 requested review of this revision. Herald added a subscriber: lldb-commits. Before this patch, any time Tr

[Lldb-commits] [PATCH] D157609: [lldb] Search debug file paths when looking for split DWARF files

DavidSpickett added a comment. > We are also looking for a way to locate .dwo files at Meta. One idea we came > up with is to add a setting that can be set: > (lldb) settings set symbols.locate-dwo-script /path/to/locate-dwo.py Probably best bring this up on Discourse for a wider audience as I'm

[Lldb-commits] [PATCH] D157609: [lldb] Search debug file paths when looking for split DWARF files

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:1737 + if (!dwo_file.IsRelative()) { +found = FileSystem::Instance().Exists(dwo_file); + } else { clayborg wrote: > Maybe we can also check the debug i