Author: Jonas Devlieghere Date: 2023-08-15T10:37:04-07:00 New Revision: 23312cde45b964b24b2c9f3aa2ff45a45174a8d9
URL: https://github.com/llvm/llvm-project/commit/23312cde45b964b24b2c9f3aa2ff45a45174a8d9 DIFF: https://github.com/llvm/llvm-project/commit/23312cde45b964b24b2c9f3aa2ff45a45174a8d9.diff LOG: [lldb] Remove {Get,Set}CloseInputOnEOF and deprecate SB equivalent (NFC) These functions have been NO-OPs since 2014 (44d937820b451). Remove them and deprecate the corresponding functions in SBDebugger. Differential revision: https://reviews.llvm.org/D158000 Added: Modified: lldb/include/lldb/Core/Debugger.h lldb/source/API/SBDebugger.cpp lldb/source/Core/Debugger.cpp Removed: ################################################################################ diff --git a/lldb/include/lldb/Core/Debugger.h b/lldb/include/lldb/Core/Debugger.h index 35703d6f885aa1..5532cace606bfe 100644 --- a/lldb/include/lldb/Core/Debugger.h +++ b/lldb/include/lldb/Core/Debugger.h @@ -241,10 +241,6 @@ class Debugger : public std::enable_shared_from_this<Debugger>, void ClearIOHandlers(); - bool GetCloseInputOnEOF() const; - - void SetCloseInputOnEOF(bool b); - bool EnableLog(llvm::StringRef channel, llvm::ArrayRef<const char *> categories, llvm::StringRef log_file, uint32_t log_options, diff --git a/lldb/source/API/SBDebugger.cpp b/lldb/source/API/SBDebugger.cpp index b3f36599df47ad..33346c1e304564 100644 --- a/lldb/source/API/SBDebugger.cpp +++ b/lldb/source/API/SBDebugger.cpp @@ -1535,17 +1535,16 @@ bool SBDebugger::SetCurrentPlatformSDKRoot(const char *sysroot) { return false; } +LLDB_DEPRECATED("SBDebugger::GetCloseInputOnEOF() is deprecated.") bool SBDebugger::GetCloseInputOnEOF() const { LLDB_INSTRUMENT_VA(this); - return (m_opaque_sp ? m_opaque_sp->GetCloseInputOnEOF() : false); + return false; } +LLDB_DEPRECATED("SBDebugger::SetCloseInputOnEOF() is deprecated.") void SBDebugger::SetCloseInputOnEOF(bool b) { LLDB_INSTRUMENT_VA(this, b); - - if (m_opaque_sp) - m_opaque_sp->SetCloseInputOnEOF(b); } SBTypeCategory SBDebugger::GetCategory(const char *category_name) { diff --git a/lldb/source/Core/Debugger.cpp b/lldb/source/Core/Debugger.cpp index 690432d4c3dfda..7ec1efc64fe938 100644 --- a/lldb/source/Core/Debugger.cpp +++ b/lldb/source/Core/Debugger.cpp @@ -929,15 +929,6 @@ void Debugger::Clear() { }); } -bool Debugger::GetCloseInputOnEOF() const { - // return m_input_comm.GetCloseOnEOF(); - return false; -} - -void Debugger::SetCloseInputOnEOF(bool b) { - // m_input_comm.SetCloseOnEOF(b); -} - bool Debugger::GetAsyncExecution() { return !m_command_interpreter_up->GetSynchronous(); } _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
