JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land.
LGTM ================ Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:3379-3385 + const char *signal_name = process_sp->GetUnixSignals()->GetSignalAsCString(signo); - if (signal_cstr) - ::snprintf(error_str, sizeof(error_str), - DEBUGSERVER_BASENAME " died with signal %s", signal_cstr); + const char *format_str = DEBUGSERVER_BASENAME " died with signal {0}"; + if (signal_name) + stream.Format(format_str, signal_name); else + stream.Format(format_str, signo); ---------------- Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158017/new/ https://reviews.llvm.org/D158017 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits