[Lldb-commits] [lldb] c5fc780 - [lldb] Fix -Wctad-maybe-unsupported in PathMappingList.cpp (NFC)

Author: Jie Fu Date: 2023-04-21T11:59:38+08:00 New Revision: c5fc7809e05940674424aaed7dd06c6be0639864 URL: https://github.com/llvm/llvm-project/commit/c5fc7809e05940674424aaed7dd06c6be0639864 DIFF: https://github.com/llvm/llvm-project/commit/c5fc7809e05940674424aaed7dd06c6be0639864.diff LOG: [

[Lldb-commits] [PATCH] D148863: Make sure SelectMostRelevantFrame happens only when returning to the user

JDevlieghere added a subscriber: dexonsmith. JDevlieghere added a comment. I looked at all the call sites and they all seemed reasonable in terms of doing work on behalf of the user or not and selecting the most relevant frame respectively. My only concern is that we now have a bunch of places w

[Lldb-commits] [PATCH] D148863: Make sure SelectMostRelevantFrame happens only when returning to the user

jingham created this revision. jingham added reviewers: JDevlieghere, bulbazord, mib. Herald added a project: All. jingham requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This is a user facing action, it is meant to focus the user's attenti

[Lldb-commits] [PATCH] D148548: [lldb] Improve breakpoint management for interactive scripted process

JDevlieghere added a comment. LGTM but I'll hold off on accepting to give Alex a change to take another look as he had more significant comments. Comment at: lldb/source/Interpreter/ScriptInterpreter.cpp:78-91 lldb::DataExtractorSP ScriptInterpreter::GetDataExtractorFromSBDa

[Lldb-commits] [PATCH] D148397: [lldb/Utility] Add opt-in passthrough mode to event listeners

JDevlieghere added a comment. In D148397#4285143 , @mib wrote: > In D148397#4275792 , @JDevlieghere > wrote: > >> I find "passthrough" somewhat confusing in this context. When using a >> listener in this new mod

[Lldb-commits] [PATCH] D145297: [lldb] Add an example of interactive scripted process debugging

mib updated this revision to Diff 515529. mib added a comment. More f-string CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145297/new/ https://reviews.llvm.org/D145297 Files: lldb/test/API/functionalities/interactive_scripted_process/Makefile lldb/test/API/functionalities/interact

[Lldb-commits] [PATCH] D148790: [LLDB] Don't print register fields when asked for a specific format

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. This seems fine to me; it's nice to have a way to quiet these when they get in the way, even if it's maybe not the first thing you'd look for, it's an uncommon enough use case that

[Lldb-commits] [PATCH] D145297: [lldb] Add an example of interactive scripted process debugging

mib updated this revision to Diff 515523. mib added a comment. Fix typo in one of the type annotation CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145297/new/ https://reviews.llvm.org/D145297 Files: lldb/test/API/functionalities/interactive_scripted_process/Makefile lldb/test/API

[Lldb-commits] [PATCH] D148846: [lldb] Let Mangled decide whether a name is mangled or not

JDevlieghere updated this revision to Diff 515522. JDevlieghere added a comment. Add simple test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148846/new/ https://reviews.llvm.org/D148846 Files: lldb/include/lldb/Core/Mangled.h lldb/source/Core/Mangled.cpp lldb/source/Plugins/Obj

[Lldb-commits] [PATCH] D145297: [lldb] Add an example of interactive scripted process debugging

mib added a comment. ping @jingham @JDevlieghere CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145297/new/ https://reviews.llvm.org/D145297 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listi

[Lldb-commits] [PATCH] D145297: [lldb] Add an example of interactive scripted process debugging

mib updated this revision to Diff 515505. mib marked 2 inline comments as done. mib added a comment. Address @bulbazord comments: - f-string everything - remove logs - add type annotations CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145297/new/ https://reviews.llvm.org/D145297 Files

[Lldb-commits] [PATCH] D145297: [lldb] Add an example of interactive scripted process debugging

mib marked 23 inline comments as done. mib added inline comments. Comment at: lldb/test/API/functionalities/interactive_scripted_process/TestInteractiveScriptedProcess.py:102-103 +self.assertState(lldb.SBProcess.GetStateFromEvent(event), lldb.eStateRunning) +eve

[Lldb-commits] [PATCH] D138939: [WIP][clang] adds a way to provide user-oriented reasons

cjdb abandoned this revision. cjdb added a comment. Herald added a subscriber: PiotrZSL. Herald added a project: clang-format. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay. Abandoning since we're heading down a different design path now. Repository: rG LLVM Githu

[Lldb-commits] [PATCH] D148397: [lldb/Utility] Add opt-in passthrough mode to event listeners

mib updated this revision to Diff 515498. mib added a comment. Fix issue when returning a non-initialized passthrough listener from the SBAPI CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148397/new/ https://reviews.llvm.org/D148397 Files: lldb/include/lldb/API/SBAttachInfo.h lldb/

[Lldb-commits] [PATCH] D148397: [lldb/Utility] Add opt-in passthrough mode to event listeners

mib marked 2 inline comments as done. mib added a comment. In D148397#4275792 , @JDevlieghere wrote: > I find "passthrough" somewhat confusing in this context. When using a > listener in this new mode, where does the event go after it has pass trough >

[Lldb-commits] [PATCH] D148846: [lldb] Let Mangled decide whether a name is mangled or not

JDevlieghere created this revision. JDevlieghere added reviewers: jingham, labath, jasonmolenda, aprantl. Herald added a subscriber: kristof.beyls. Herald added a reviewer: shafik. Herald added a project: All. JDevlieghere requested review of this revision. We have a handful of places in LLDB wher

[Lldb-commits] [PATCH] D148546: Reland: [Demangle] replace use of llvm::StringView w/ std::string_view

nickdesaulniers added a comment. llvm/test/Demangle/ms-cxx14.test is now crashing on windows, working on a fix forward for llvm::microsoftDemangle which I think is missing a nullptr check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148546/new/

[Lldb-commits] [PATCH] D148399: [lldb] Improve logging for process state change (NFC)

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148399/new/ https://reviews.llvm.org/D148399 ___ lldb-commits mailing list lldb-c

[Lldb-commits] [PATCH] D148395: [lldb] Unify default/hijack listener between Process{Attach, Launch}Info (NFC)

mib added a comment. In D148395#4270508 , @bulbazord wrote: > Creating a ProcessAttachInfo from a ProcessLaunchInfo with this change means > they'll have different listeners. Is that ProcessLaunchInfo kept around for > any other reason? Or is it just ma

[Lldb-commits] [PATCH] D148399: [lldb] Improve logging for process state change (NFC)

mib updated this revision to Diff 515473. mib edited the summary of this revision. mib added a comment. Address @JDevlieghere @bulbazord comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148399/new/ https://reviews.llvm.org/D148399 Files: lldb/source/Target/Process.cpp Index: l

[Lldb-commits] [PATCH] D148399: [lldb] Improve logging for process state change (NFC)

mib added a comment. In D148399#4284809 , @bulbazord wrote: > We'd go from: > > LLDB_LOGF(log, > "Process::SetPrivateState (plugin = %s, state = %s) state didn't " > "change. Ignoring...", > GetPluginName().data(), St

[Lldb-commits] [PATCH] D148399: [lldb] Improve logging for process state change (NFC)

bulbazord added a comment. We'd go from: LLDB_LOGF(log, "Process::SetPrivateState (plugin = %s, state = %s) state didn't " "change. Ignoring...", GetPluginName().data(), StateAsCString(new_state)); to LLDB_LOG(log, "(plugin = %s, state = %s) state didn't

[Lldb-commits] [PATCH] D148399: [lldb] Improve logging for process state change (NFC)

mib added a comment. In D148399#4274470 , @JDevlieghere wrote: > I think a lot of this can be simplified by using `LLDB_LOG` instead of > `LLDB_LOGF`. In D148399#4275219 , @bulbazord wrote: > +1 to what Jona

[Lldb-commits] [PATCH] D148823: Make diagnostics API safer to use

mib accepted this revision. mib added a comment. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148823/new/ https://reviews.llvm.org/D148823 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman

[Lldb-commits] [PATCH] D148823: Make diagnostics API safer to use

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148823/new/ https://reviews.llvm.org/D148823 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D148546: Reland: [Demangle] replace use of llvm::StringView w/ std::string_view

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7c59e8001a3b: Reland: [Demangle] replace use of llvm::StringView w/ std::string_view (authored by nickdesaulniers). Repository: rG LLVM Github Mon

[Lldb-commits] [lldb] 7c59e80 - Reland: [Demangle] replace use of llvm::StringView w/ std::string_view

Author: Nick Desaulniers Date: 2023-04-20T11:22:20-07:00 New Revision: 7c59e8001a3b66be545a890a26ad8a24a6c9fe4b URL: https://github.com/llvm/llvm-project/commit/7c59e8001a3b66be545a890a26ad8a24a6c9fe4b DIFF: https://github.com/llvm/llvm-project/commit/7c59e8001a3b66be545a890a26ad8a24a6c9fe4b.di

[Lldb-commits] [PATCH] D148823: Make diagnostics API safer to use

aprantl created this revision. aprantl added reviewers: kastiglione, JDevlieghere, Michael137. Herald added a project: All. aprantl requested review of this revision. I received a crash report in DiagnosticManager that was causes by a nullptr diagnostic having been added. The API allows passing i

[Lldb-commits] [PATCH] D148546: Reland: [Demangle] replace use of llvm::StringView w/ std::string_view

nickdesaulniers added a comment. Thanks for the help testing on Windows @ayzhao . Those warnings look potentially interesting to follow up; none appear to be introduced from this diff. Landing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148546/

[Lldb-commits] [PATCH] D148546: Reland: [Demangle] replace use of llvm::StringView w/ std::string_view

ayzhao accepted this revision. ayzhao added a comment. This revision is now accepted and ready to land. LGTM, looks like this builds on Windows now: C:\src\llvm-project\build-ninja>ninja all [3498/6597] Building CXX object tools\clang\lib\AST\CMakeFiles\obj.clangAST.dir\AttrDocTable.cpp.obj

[Lldb-commits] [PATCH] D148546: Reland: [Demangle] replace use of llvm::StringView w/ std::string_view

nickdesaulniers updated this revision to Diff 515391. nickdesaulniers added a comment. - fix another conversion issue for msvc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148546/new/ https://reviews.llvm.org/D148546 Files: lldb/source/Plugins/

[Lldb-commits] [PATCH] D148546: Reland: [Demangle] replace use of llvm::StringView w/ std::string_view

ayzhao added a comment. A new conversion issue popped up: C:\src\llvm-project\build-ninja>ninja all [376/3206] Building CXX object lib\ProfileData\CMakeFiles\LLVMProfileData.dir\ItaniumManglingCanonicalizer.cpp.obj FAILED: lib/ProfileData/CMakeFiles/LLVMProfileData.dir/ItaniumManglingCano

[Lldb-commits] [PATCH] D148546: Reland: [Demangle] replace use of llvm::StringView w/ std::string_view

nickdesaulniers updated this revision to Diff 515387. nickdesaulniers marked 3 inline comments as done. nickdesaulniers added a comment. - git clang-format HEAD~, fix 2 more conversion issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148546/new/

[Lldb-commits] [PATCH] D148546: Reland: [Demangle] replace use of llvm::StringView w/ std::string_view

ayzhao requested changes to this revision. ayzhao added a comment. This revision now requires changes to proceed. This still fails to build on Windows with MSVC's `cl.exe` compiler: C:\src\llvm-project\build-ninja>ninja all [49/4908] Building CXX object lib\Demangle\CMakeFiles\LLVMDemangle.d

[Lldb-commits] [PATCH] D148752: lldb: Fix usage of sve functions on arm64

manojgupta added a comment. I am building on ChromeOS. We only have headers from linux kernel 4.14 available in our build system (The actual running kernel could be a higher version). But given these functions/struct definitions (sve::) are already available and used, why are they not used cons

[Lldb-commits] [PATCH] D144390: [lldb] Send QPassSignals packet on attach, and at start for remote platforms

DavidSpickett resigned from this revision. DavidSpickett added a comment. This is probably an obvious change, but I have no experience with this area so I don't feel comfortable approving. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144390/new/

[Lldb-commits] [PATCH] D144392: [lldb] Skip signal handlers for ignored signals on lldb-server's side when stepping

kpdev42 added a comment. Herald added a subscriber: asb. @jingham could you please take a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144392/new/ https://reviews.llvm.org/D144392 ___ lldb-commits

[Lldb-commits] [PATCH] D144390: [lldb] Send QPassSignals packet on attach, and at start for remote platforms

kpdev42 added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144390/new/ https://reviews.llvm.org/D144390 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/c

[Lldb-commits] [PATCH] D148790: [LLDB] Don't print register fields when asked for a specific format

DavidSpickett added a comment. One alternative was to come up with a list of formats where printing fields afterwards makes sense. Hex makes sense, instruction does not. However it would be hard to judge and it doesn't solve the main issue where you want to see what you asked for without extras

[Lldb-commits] [PATCH] D148790: [LLDB] Don't print register fields when asked for a specific format

DavidSpickett updated this revision to Diff 515271. DavidSpickett added a comment. Herald added a subscriber: JDevlieghere. Use the getter for the format value instead of adding a WasSet to the group class. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[Lldb-commits] [PATCH] D148790: [LLDB] Don't print register fields when asked for a specific format

DavidSpickett created this revision. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Previously if a register had fields we would always print them after the value if the register was asked for by

[Lldb-commits] [PATCH] D148715: [LLDB] Discard register flags where the size doesn't match the register

This revision was automatically updated to reflect the committed changes. Closed by commit rGdbc34e2bed10: [LLDB] Discard register flags where the size doesn't match the register (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[Lldb-commits] [lldb] dbc34e2 - [LLDB] Discard register flags where the size doesn't match the register

Author: David Spickett Date: 2023-04-20T08:36:49Z New Revision: dbc34e2bed10c18c78100a9e8517d9a0b2f6639d URL: https://github.com/llvm/llvm-project/commit/dbc34e2bed10c18c78100a9e8517d9a0b2f6639d DIFF: https://github.com/llvm/llvm-project/commit/dbc34e2bed10c18c78100a9e8517d9a0b2f6639d.diff LOG