mib marked 23 inline comments as done. mib added inline comments.
================ Comment at: lldb/test/API/functionalities/interactive_scripted_process/TestInteractiveScriptedProcess.py:102-103 + self.assertState(lldb.SBProcess.GetStateFromEvent(event), lldb.eStateRunning) + event = lldbutil.fetch_next_event(self, mux_process_listener, mux_process.GetBroadcaster()) + self.assertState(lldb.SBProcess.GetStateFromEvent(event), lldb.eStateStopped) + ---------------- bulbazord wrote: > Did you mean to get info from the `mux_process_listener` twice? Was one of > these supposed to be for the real process? We're only listening to the `mux_process` events so this is how its supposed to be. ================ Comment at: lldb/test/API/functionalities/interactive_scripted_process/interactive_scripted_process.py:9 + +import os,json,struct,signal +import time ---------------- bulbazord wrote: > nit: import these all on different lines why :p ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145297/new/ https://reviews.llvm.org/D145297 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
