JDevlieghere added a comment. In D148397#4285143 <https://reviews.llvm.org/D148397#4285143>, @mib wrote:
> In D148397#4275792 <https://reviews.llvm.org/D148397#4275792>, @JDevlieghere > wrote: > >> I find "passthrough" somewhat confusing in this context. When using a >> listener in this new mode, where does the event go after it has pass trough >> this event listener? Maybe my understanding of how the event listeners is >> incomplete, but I was under the impression that normally there's a single >> listener for a certain kind of event. IIUC, in this new mode, you can have >> multiple listeners, where you can set one (or as Alex pointed out, possibly >> more) listeners that can observe events but not necessary deal with them. If >> that's an accurate description of the interactions, then it seems like >> there's more of a one-to-many relationship between events and listeners >> rather than what passthrough implies. I think a better name would be >> something like "passive listener" or "non-handling" listener or something. > > @JDevlieghere You could also have multiple listeners for a certain type of > event, but events would be considered "handled" only when they're popped from > the listener passed during the process creation (or the debugger listener if > no listener is provided in the {launch,attach}info). The idea behind > passthrough listener was to have a side channel where all the events would be > funneled to, that would never interfere with the default listener and > therefore not change the process execution behavior. If you really feel > strongly about the "passthrough" name, I can rename it to whatever you like > but I feel like it's pretty self explanatory. To me, passthrough means something sitting in-between something else. It's still not clear to me what the passthrough listener is sitting in between. It sounds like it's meant to be a side channel, so maybe shadow listener would be a better name? I don't care so much about the name per se but rather about making it obvious what it does. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148397/new/ https://reviews.llvm.org/D148397 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
