[Lldb-commits] [lldb] f009241 - [lldb] Fix -Wdangling-else warning in CommunicationTest

Author: Jonas Devlieghere Date: 2023-03-08T22:21:00-08:00 New Revision: f009241ae595ae6db5a859e498f72fd7e5dc6ce8 URL: https://github.com/llvm/llvm-project/commit/f009241ae595ae6db5a859e498f72fd7e5dc6ce8 DIFF: https://github.com/llvm/llvm-project/commit/f009241ae595ae6db5a859e498f72fd7e5dc6ce8.d

[Lldb-commits] [lldb] 73058e3 - [lldb] Fix typo in SymbolVendorELF

Author: Jonas Devlieghere Date: 2023-03-08T22:15:36-08:00 New Revision: 73058e330134d275070d49dba80e5fda50ec015b URL: https://github.com/llvm/llvm-project/commit/73058e330134d275070d49dba80e5fda50ec015b DIFF: https://github.com/llvm/llvm-project/commit/73058e330134d275070d49dba80e5fda50ec015b.d

[Lldb-commits] [lldb] 12f709d - lldb] Re-enable TestSymbolFileJSON on non Darwin platforms

Author: Jonas Devlieghere Date: 2023-03-08T22:12:34-08:00 New Revision: 12f709db0d0e7e8145175e12965c4e3db592143a URL: https://github.com/llvm/llvm-project/commit/12f709db0d0e7e8145175e12965c4e3db592143a DIFF: https://github.com/llvm/llvm-project/commit/12f709db0d0e7e8145175e12965c4e3db592143a.d

[Lldb-commits] [lldb] 15653dc - [lldb] Temporarily disable TestSymbolFileJSON on non Darwin platforms

Author: Jonas Devlieghere Date: 2023-03-08T21:32:45-08:00 New Revision: 15653dcb62dff58ec5f653d0a2884b1299f971d6 URL: https://github.com/llvm/llvm-project/commit/15653dcb62dff58ec5f653d0a2884b1299f971d6 DIFF: https://github.com/llvm/llvm-project/commit/15653dcb62dff58ec5f653d0a2884b1299f971d6.d

[Lldb-commits] [PATCH] D145180: [lldb] Introduce new SymbolFileJSON and ObjectFileJSON

This revision was automatically updated to reflect the committed changes. Closed by commit rGcf3524a5746f: [lldb] Introduce new SymbolFileJSON and ObjectFileJSON (authored by JDevlieghere). Changed prior to commit: https://reviews.llvm.org/D145180?vs=503575&id=503611#toc Repository: rG LLVM

[Lldb-commits] [lldb] cf3524a - [lldb] Introduce new SymbolFileJSON and ObjectFileJSON

Author: Jonas Devlieghere Date: 2023-03-08T20:56:11-08:00 New Revision: cf3524a5746f9498280b3a9180b75575c0065d1a URL: https://github.com/llvm/llvm-project/commit/cf3524a5746f9498280b3a9180b75575c0065d1a DIFF: https://github.com/llvm/llvm-project/commit/cf3524a5746f9498280b3a9180b75575c0065d1a.d

[Lldb-commits] [lldb] 8db8a4e - Clean up conditional, don't set load binaries twice

Author: Jason Molenda Date: 2023-03-08T18:02:20-08:00 New Revision: 8db8a4e8eddf91bfaee62f83ff10a51e7125d4e4 URL: https://github.com/llvm/llvm-project/commit/8db8a4e8eddf91bfaee62f83ff10a51e7125d4e4 DIFF: https://github.com/llvm/llvm-project/commit/8db8a4e8eddf91bfaee62f83ff10a51e7125d4e4.diff

[Lldb-commits] [PATCH] D145624: [lldb] Make MemoryCache::Read more resilient

clayborg added a comment. There was a fix that was never submitted for Google Stadia for the memory cache here: https://github.com/googlestadia/vsi-lldb/tree/master/patches/llvm-project Might be worth checking what they did to ensure we have all of the same abilities. Comme

[Lldb-commits] [PATCH] D145547: When setting load addresses on darwin kernel kexts, handle case where in-memory load commands are not updated

bulbazord added inline comments. Comment at: lldb/source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.cpp:816-819 + ObjectFileMachO *ondisk_objfile_macho = + llvm::dyn_cast_or_null( + m_module_sp ? m_module_sp->GetObjectFile() : nullpt

[Lldb-commits] [PATCH] D145180: [lldb] Introduce new SymbolFileJSON and ObjectFileJSON

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Thanks for the changes! LGTM. Just one missed EXPECT_THAT_EXPECTED, but accepted. Comment at: lldb/unittests/Symbol/JSONSymbolTest.cpp:144-145 + Expected symbol = Symbo

[Lldb-commits] [PATCH] D145180: [lldb] Introduce new SymbolFileJSON and ObjectFileJSON

JDevlieghere updated this revision to Diff 503575. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145180/new/ https://reviews.llvm.org/D145180 Files: lldb/include/lldb/Symbol/Symbol.h lldb/source/Plugins/ObjectFile/CMakeLists.txt lldb/source/Plugins/ObjectFile/JSON/CMakeLists.txt

[Lldb-commits] [PATCH] D145629: When a ValueObjectDynamicValue fails to update, return a not valid ValueObject so the static one is used instead

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. LGTM with a comment. Comment at: lldb/source/Core/ValueObject.cpp:1862 } - if (m_dynamic_value) + if (m_dynamic_value && m_dynamic_value->GetError().Success()) return m_d

[Lldb-commits] [PATCH] D145569: [lldb][InstrumentationRuntime] Make 'data' struct anonymous in order to avoid collisions with types in the debuggee

Michael137 added a comment. In D145569#4179648 , @jingham wrote: > The TSAN instrumenter has the same `struct data` definition. I actually got > a report of this crashing in TSAN yesterday. You should do that one as well. > Otherwise, LGTM and I don'

[Lldb-commits] [PATCH] D145569: [lldb][InstrumentationRuntime] Make 'data' struct anonymous in order to avoid collisions with types in the debuggee

Michael137 updated this revision to Diff 503572. Michael137 edited the summary of this revision. Michael137 added a comment. - Apply fix to TSAN structure as well Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145569/new/ https://reviews.llvm.org/D1

[Lldb-commits] [PATCH] D145547: When setting load addresses on darwin kernel kexts, handle case where in-memory load commands are not updated

This revision was automatically updated to reflect the committed changes. Closed by commit rG794d2089cd74: Don't load non-kexts in darwin kernel debug; handle unslid segs (authored by jasonmolenda). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14554

[Lldb-commits] [lldb] 794d208 - Don't load non-kexts in darwin kernel debug; handle unslid segs

Author: Jason Molenda Date: 2023-03-08T16:51:27-08:00 New Revision: 794d2089cd741135b60e94ac2495174a03b38143 URL: https://github.com/llvm/llvm-project/commit/794d2089cd741135b60e94ac2495174a03b38143 DIFF: https://github.com/llvm/llvm-project/commit/794d2089cd741135b60e94ac2495174a03b38143.diff

[Lldb-commits] [PATCH] D145547: When setting load addresses on darwin kernel kexts, handle case where in-memory load commands are not updated

jasonmolenda updated this revision to Diff 503569. jasonmolenda marked an inline comment as done. jasonmolenda added a comment. Update for Jonas' suggestions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145547/new/ https://reviews.llvm.org/D14554

[Lldb-commits] [PATCH] D145624: [lldb] Make MemoryCache::Read more resilient

mib added inline comments. Comment at: lldb/source/Target/Memory.cpp:175 - if (dst && bytes_left > 0) { -const uint32_t cache_line_byte_size = m_L2_cache_line_byte_size; -uint8_t *dst_buf = (uint8_t *)dst; -addr_t curr_addr = addr - (addr % cache_line_byte_size); -

[Lldb-commits] [PATCH] D145547: When setting load addresses on darwin kernel kexts, handle case where in-memory load commands are not updated

jasonmolenda marked an inline comment as done. jasonmolenda added inline comments. Comment at: lldb/source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.cpp:835 + m_name.c_str(), m_uuid.GetAsString().c_str()); +m_module_sp.reset()

[Lldb-commits] [PATCH] D145629: When a ValueObjectDynamicValue fails to update, return a not valid ValueObject so the static one is used instead

jingham created this revision. jingham added reviewers: JDevlieghere, kastiglione, mib, delcypher. Herald added a project: All. jingham requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. When we can't find a valid type for a dynamic value (for

[Lldb-commits] [PATCH] D145547: When setting load addresses on darwin kernel kexts, handle case where in-memory load commands are not updated

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Some code style nits but the change itself LGTM. Comment at: lldb/source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.cpp:819-821 +if (ondis

[Lldb-commits] [PATCH] D143695: [lldb] Make repeat commands work for regex commands

This revision was automatically updated to reflect the committed changes. Closed by commit rG5e0ee1b395fa: [lldb] Make repeat commands work for regex commands (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143695/new/ https

[Lldb-commits] [lldb] 5e0ee1b - [lldb] Make repeat commands work for regex commands

Author: Dave Lee Date: 2023-03-08T16:21:42-08:00 New Revision: 5e0ee1b395fa6fca9f23f278885c5949277de666 URL: https://github.com/llvm/llvm-project/commit/5e0ee1b395fa6fca9f23f278885c5949277de666 DIFF: https://github.com/llvm/llvm-project/commit/5e0ee1b395fa6fca9f23f278885c5949277de666.diff LOG:

[Lldb-commits] [PATCH] D143695: [lldb] Make repeat commands work for regex commands

kastiglione added a comment. thanks for the feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143695/new/ https://reviews.llvm.org/D143695 ___ lldb-commits mailing list lldb-commits@lists.llvm.org h

[Lldb-commits] [PATCH] D145624: [lldb] Make MemoryCache::Read more resilient

JDevlieghere added inline comments. Comment at: lldb/source/Target/Memory.cpp:131 + size_t bytes_left = dst_len; This isn't used until line 180. I'd move it down, closer to where it is being used. Comment at: lldb/source/Target/Memory.cpp

[Lldb-commits] [PATCH] D145294: [lldb/API] Introduce SBProcess::ForceScriptedState method

jingham added a comment. The code seems fine, but I don't think "private state" is a concept that people who aren't intimately familiar with lldb are likely to understand. I think you could just leave out private and just say it changes the process state to the new state. That's all people us

[Lldb-commits] [PATCH] D145547: When setting load addresses on darwin kernel kexts, handle case where in-memory load commands are not updated

jasonmolenda updated this revision to Diff 503550. jasonmolenda added a comment. Add an additional bit to the "don't load non-kexts, non-kernels" addition. I refined this by checking to see if the binary is already registered in the Target, and already has a load address set. If the binary is,

[Lldb-commits] [PATCH] D145569: [lldb][InstrumentationRuntime] Make 'data' struct anonymous in order to avoid collisions with types in the debuggee

jingham added a comment. The TSAN instrumenter has the same `struct data` definition. I actually got a report of this crashing in TSAN yesterday. You should do that one as well. Otherwise, LGTM and I don't think you need to add a test with "struct data" in it on the off chance that someone r

[Lldb-commits] [PATCH] D145624: [lldb] Make MemoryCache::Read more resilient

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, clayborg, jasonmolenda, jingham, labath. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. MemoryCache::Read is not resilie

[Lldb-commits] [PATCH] D143695: [lldb] Make repeat commands work for regex commands

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143695/new/ https://reviews.llvm.org/D143695 _

[Lldb-commits] [PATCH] D145181: Revert "Remove the LINK_COMPONENTS entry from lldb-instr CMakery"

aheejin added a comment. Thanks for the info. I asked questions in https://github.com/llvm/llvm-project/issues/60314 but they were not answered either. What should I do with this CL? Can you at least let me know why this wouldn't work given that there are many files like this? Repository: r

[Lldb-commits] [PATCH] D145180: [lldb] Introduce new SymbolFileJSON and ObjectFileJSON

JDevlieghere added inline comments. Comment at: lldb/include/lldb/Core/Debugger.h:594 lldb::TargetSP m_dummy_target_sp; + Diagnostics::CallbackID m_diagnostics_callback_id; clayborg wrote: > I am guessing these changes are in Debugger.h and Debugger.cpp are

[Lldb-commits] [PATCH] D145180: [lldb] Introduce new SymbolFileJSON and ObjectFileJSON

JDevlieghere updated this revision to Diff 503543. JDevlieghere marked 21 inline comments as done. JDevlieghere added a comment. - Remove 9d311dd6a71b from patch - Use `EXPECT_THAT_EXPECTED` CHANGES SINCE LAST ACTION https:

[Lldb-commits] [PATCH] D145180: [lldb] Introduce new SymbolFileJSON and ObjectFileJSON

clayborg added inline comments. Comment at: lldb/include/lldb/Core/Debugger.h:594 lldb::TargetSP m_dummy_target_sp; + Diagnostics::CallbackID m_diagnostics_callback_id; I am guessing these changes are in Debugger.h and Debugger.cpp are not related to this

[Lldb-commits] [PATCH] D145612: [lldb] Only replace valobj with persisted one if not null in DWIMPrint

This revision was automatically updated to reflect the committed changes. Closed by commit rG581ac50d58b9: [lldb] Only replace valobj with persisted one if not null in DWIMPrint (authored by augusto2112). Changed prior to commit: https://reviews.llvm.org/D145612?vs=503503&id=503518#toc Reposit

[Lldb-commits] [lldb] 581ac50 - [lldb] Only replace valobj with persisted one if not null in DWIMPrint

Author: Augusto Noronha Date: 2023-03-08T14:18:40-08:00 New Revision: 581ac50d58b99a37244e9d4e0d8d12c9c810f472 URL: https://github.com/llvm/llvm-project/commit/581ac50d58b99a37244e9d4e0d8d12c9c810f472 DIFF: https://github.com/llvm/llvm-project/commit/581ac50d58b99a37244e9d4e0d8d12c9c810f472.dif

[Lldb-commits] [PATCH] D145612: [lldb] Only replace valobj with persisted one if not null in DWIMPrint

kastiglione accepted this revision. kastiglione added a comment. This revision is now accepted and ready to land. thank you Comment at: lldb/source/Commands/CommandObjectDWIMPrint.cpp:92-94 +auto persisted_valobj = valobj_sp->Persist(); +if (persisted_valobj) +

[Lldb-commits] [PATCH] D145609: [lldb] Change dwim-print to default to disabled persistent results

kastiglione updated this revision to Diff 503515. kastiglione added a comment. Cleanup TestDWIMPrint Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145609/new/ https://reviews.llvm.org/D145609 Files: lldb/source/Commands/CommandObjectDWIMPrint.cp

[Lldb-commits] [PATCH] D145547: When setting load addresses on darwin kernel kexts, handle case where in-memory load commands are not updated

jasonmolenda updated this revision to Diff 503497. jasonmolenda added a comment. Show an alternate approach, where we check the file types of everything in the kernel+kext list, and if something is not a kernel/kext, don't try to load it at all. v. the first change in `DynamicLoaderDarwinKerne

[Lldb-commits] [PATCH] D145612: [lldb] Only replace valobj with persisted one if not null in DWIMPrint

augusto2112 created this revision. augusto2112 added a reviewer: kastiglione. Herald added a project: All. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D145612

[Lldb-commits] [PATCH] D145609: [lldb] Change dwim-print to default to disabled persistent results

kastiglione created this revision. kastiglione added reviewers: aprantl, jingham. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Change `dwim-print` to now disable persistent results by default, unl

[Lldb-commits] [PATCH] D143695: [lldb] Make repeat commands work for regex commands

kastiglione updated this revision to Diff 503462. kastiglione added a comment. Rename variable to force_repeat_command and add comment block Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143695/new/ https://reviews.llvm.org/D143695 Files: lldb/i

[Lldb-commits] [PATCH] D143695: [lldb] Make repeat commands work for regex commands

kastiglione added a comment. > But `allow_repeat_command` is a misleading name for that. It makes is sound > like if I don't pass that flag I won't get a repeat command. > `force_repeat_command` would be a better name I agree. I did have some loose thoughts matching this, when writing it, yet

[Lldb-commits] [PATCH] D145276: [lldb] Let 'v' command directly access ivars of _any_ self/this

This revision was automatically updated to reflect the committed changes. Closed by commit rG6c599b1e9b7e: [lldb] Let 'v' command directly access ivars of _any_ self/this (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145276

[Lldb-commits] [lldb] 6c599b1 - [lldb] Let 'v' command directly access ivars of _any_ self/this

Author: Dave Lee Date: 2023-03-08T11:19:43-08:00 New Revision: 6c599b1e9b7e1b57952565468aed2de16af21082 URL: https://github.com/llvm/llvm-project/commit/6c599b1e9b7e1b57952565468aed2de16af21082 DIFF: https://github.com/llvm/llvm-project/commit/6c599b1e9b7e1b57952565468aed2de16af21082.diff LOG:

[Lldb-commits] [lldb] 632c396 - [lldb] Change default value of dwim-print-verbosity setting

Author: Dave Lee Date: 2023-03-08T11:10:50-08:00 New Revision: 632c396499eb4f6f7a36ba0246ba57e011357a55 URL: https://github.com/llvm/llvm-project/commit/632c396499eb4f6f7a36ba0246ba57e011357a55 DIFF: https://github.com/llvm/llvm-project/commit/632c396499eb4f6f7a36ba0246ba57e011357a55.diff LOG:

[Lldb-commits] [PATCH] D145529: [lldb] Change default value of dwim-print-verbosity setting

This revision was automatically updated to reflect the committed changes. Closed by commit rG632c396499eb: [lldb] Change default value of dwim-print-verbosity setting (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145529/new

[Lldb-commits] [PATCH] D145529: [lldb] Change default value of dwim-print-verbosity setting

kastiglione added a comment. Clarification: `TestDWIMPrint.py` uses and tests with this setting, but it explicitly sets the value to "full". The default value doesn't affect tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145529/new/ https://

[Lldb-commits] [PATCH] D145529: [lldb] Change default value of dwim-print-verbosity setting

kastiglione added a comment. > This doesn't affect any tests? nope Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145529/new/ https://reviews.llvm.org/D145529 ___ lldb-commits mailing list lldb-commits@l

[Lldb-commits] [PATCH] D145180: [lldb] Introduce new SymbolFileJSON and ObjectFileJSON

JDevlieghere updated this revision to Diff 503432. JDevlieghere added a comment. - Add unit tests for JSON deserialization - Add unit tests for converting JSONSymbol to Symbol CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145180/new/ https://reviews.llvm.org/D145180 Files: lldb/inclu

[Lldb-commits] [PATCH] D145580: [lldb] Show register fields using bitfield struct types

DavidSpickett updated this revision to Diff 503379. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145580/new/ https://reviews.llvm.org/D145580 Files: lldb/include/lldb/Core/DumpRegisterValue.h lldb/include

[Lldb-commits] [PATCH] D145566: [lldb] Add RegisterFlags class

DavidSpickett updated this revision to Diff 503378. DavidSpickett marked an inline comment as done. DavidSpickett added a comment. Add newline at end of file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145566/new/ https://reviews.llvm.org/D14556

[Lldb-commits] [PATCH] D145580: [lldb] Show register fields using bitfield struct types

DavidSpickett updated this revision to Diff 503377. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145580/new/ https://reviews.llvm.org/D145580 Files: lldb/include/lldb/Core/DumpRegisterValue.h lldb/include

[Lldb-commits] [PATCH] D145574: [lldb] Read register fields from target XML

DavidSpickett updated this revision to Diff 503376. DavidSpickett added a comment. Use StringRef instead of std::string. Though an empty StringRef is morally equivalent to optional, I've stuck with optional to keep the code looking consistent. Repository: rG LLVM Github Monorepo CHANGES SINC

[Lldb-commits] [PATCH] D145566: [lldb] Add RegisterFlags class

DavidSpickett updated this revision to Diff 503374. DavidSpickett added a comment. Use StringRef for parameters. This is what the XML parser gives you by default in any case. Internally we want to keep a copy of the string because the XML document will go away after parsing. Repository: rG LL

[Lldb-commits] [PATCH] D145566: [lldb] Add RegisterFlags class

tschuett added a comment. My only comment is: views look more modern than const-ref. The efficiency is not affected at all. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145566/new/ https://reviews.llvm.org/D145566 ___

[Lldb-commits] [PATCH] D145566: [lldb] Add RegisterFlags class

DavidSpickett added inline comments. Comment at: lldb/include/lldb/Target/RegisterFlags.h:20 + public: +Field(const std::string &name, unsigned start, unsigned end, + const std::string &type) DavidSpickett wrote: > tschuett wrote: > > There are a lo

[Lldb-commits] [PATCH] D145566: [lldb] Add RegisterFlags class

DavidSpickett added inline comments. Comment at: lldb/include/lldb/Target/RegisterFlags.h:20 + public: +Field(const std::string &name, unsigned start, unsigned end, + const std::string &type) tschuett wrote: > There are a lot of `const std::string&

[Lldb-commits] [lldb] b7217a8 - [lldb] Remove unused CrashReasonAsString function

Author: David Spickett Date: 2023-03-08T14:27:59Z New Revision: b7217a8fc94d33f44ec8a2e695e75f70a6eeea1e URL: https://github.com/llvm/llvm-project/commit/b7217a8fc94d33f44ec8a2e695e75f70a6eeea1e DIFF: https://github.com/llvm/llvm-project/commit/b7217a8fc94d33f44ec8a2e695e75f70a6eeea1e.diff LOG

[Lldb-commits] [PATCH] D145561: [lldb] Remove unused CrashReasonAsString function

This revision was automatically updated to reflect the committed changes. Closed by commit rGb7217a8fc94d: [lldb] Remove unused CrashReasonAsString function (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145561/new/ https

[Lldb-commits] [PATCH] D145566: [lldb] Add RegisterFlags class

tschuett added inline comments. Comment at: lldb/include/lldb/Target/RegisterFlags.h:20 + public: +Field(const std::string &name, unsigned start, unsigned end, + const std::string &type) There are a lot of `const std::string& ` . Are you allowed to

[Lldb-commits] [PATCH] D145566: [lldb] Add RegisterFlags class

tschuett added inline comments. Comment at: lldb/unittests/Target/RegisterFlagsTest.cpp:125 +} \ No newline at end of file Missing line. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145566/new/ https://reviews.l

[Lldb-commits] [PATCH] D145559: [lldb] Remove unused POSIX ProcessMessage files

This revision was automatically updated to reflect the committed changes. Closed by commit rG8fe114428551: [lldb] Remove unused POSIX ProcessMessage files (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145559/new/ https:/

[Lldb-commits] [lldb] 8fe1144 - [lldb] Remove unused POSIX ProcessMessage files

Author: David Spickett Date: 2023-03-08T13:18:52Z New Revision: 8fe11442855151a790e1a1ffa92442c5ee5203c1 URL: https://github.com/llvm/llvm-project/commit/8fe11442855151a790e1a1ffa92442c5ee5203c1 DIFF: https://github.com/llvm/llvm-project/commit/8fe11442855151a790e1a1ffa92442c5ee5203c1.diff LOG

[Lldb-commits] [PATCH] D145574: [lldb] Read register fields from target XML

DavidSpickett added a comment. Tests are added in https://reviews.llvm.org/D145580, because they use the formatting code added there. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145574/new/ https://reviews.llvm.org/D145574 _

[Lldb-commits] [PATCH] D145580: [lldb] Show register fields using bitfield struct types

DavidSpickett created this revision. Herald added subscribers: ChuanqiXu, kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added projects: LLDB, LLVM. Herald added subscribers: llvm-commits, lldb-commits. This change uses the information from targ

[Lldb-commits] [PATCH] D145569: [lldb][InstrumentationRuntime] Make 'data' struct anonymous in order to avoid collisions with types in the debuggee

Michael137 updated this revision to Diff 503308. Michael137 added a comment. - Update commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145569/new/ https://reviews.llvm.org/D145569 Files: lldb/source/Plugins/InstrumentationRuntime/UB

[Lldb-commits] [PATCH] D145569: [lldb][InstrumentationRuntime] Make 'data' struct anonymous in order to avoid collisions with types in the debuggee

Michael137 added a comment. Not sure there's a test to be added here. Of course I could add a dummy data type to the API tests called `struct data {};` and confirm that it doesn't crash (I did this manually locally), but it doesn't seem like something that would catch regressions in the future.

[Lldb-commits] [PATCH] D145574: [lldb] Read register fields from target XML

DavidSpickett created this revision. Herald added a subscriber: mgrang. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This teaches ProcessGDBRemote to look for "flags" nodes in the target XML tha

[Lldb-commits] [PATCH] D145571: [LLDB][ObjectFileELF] Correct the return type of Reloc{Offset, Addend}32

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145571/new/ https://reviews.llvm.org/D145571 __

[Lldb-commits] [PATCH] D145571: [LLDB][ObjectFileELF] Correct the return type of Reloc{Offset, Addend}32

SixWeining created this revision. SixWeining added a reviewer: DavidSpickett. Herald added a subscriber: emaste. Herald added a project: All. SixWeining requested review of this revision. Herald added subscribers: lldb-commits, MaskRay. Herald added a project: LLDB. This is a follow up of D145550

[Lldb-commits] [PATCH] D145569: [lldb][InstrumentationRuntime] Make 'data' struct anonymous in order to avoid collisions with types in the debuggee

Michael137 created this revision. Michael137 added reviewers: aprantl, jingham. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The `UBSAN`/`ASAN` plugins would previously call the internal helper str

[Lldb-commits] [PATCH] D145566: [lldb] Add RegisterFlags class

DavidSpickett created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This models the "flags" node from GDB's target XML: https://sourceware

[Lldb-commits] [lldb] 2857eeb - [lldb][test][NFC] TestDataFormatterCpp.py: Remove redundant FIXME

Author: Michael Buch Date: 2023-03-08T10:45:20Z New Revision: 2857eeb5f4f7b147a90d6b223f6aa7f90fd53f1c URL: https://github.com/llvm/llvm-project/commit/2857eeb5f4f7b147a90d6b223f6aa7f90fd53f1c DIFF: https://github.com/llvm/llvm-project/commit/2857eeb5f4f7b147a90d6b223f6aa7f90fd53f1c.diff LOG:

[Lldb-commits] [PATCH] D145377: [LLDB] Show sub type of memory tagging SEGV when reading a core file

DavidSpickett added a comment. This should build anywhere now. I looked at `thread siginfo` and I see what you mean, but it'll take me some time to confirm exactly how much of siginfo is in the core file. I did get it to work using the full type, but I'm pretty sure some of the values were inv

[Lldb-commits] [PATCH] D145377: [LLDB] Show sub type of signals for ELF core files

DavidSpickett updated this revision to Diff 503274. DavidSpickett added a comment. Add code functionality to UnixSignals instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145377/new/ https://reviews.llvm.org/D145377 Files: lldb/include/lldb

[Lldb-commits] [PATCH] D145561: [lldb] Remove unused CrashReasonAsString function

DavidSpickett created this revision. Herald added a subscriber: emaste. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The last user was ProcessMessage, which has itself been removed. Repository

[Lldb-commits] [PATCH] D145550: [LLDB][ObjectFileELF] Correct the return type of RelocOffset64 and RelocAddend64

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145550/new/ https://reviews.llvm.org/D145550

[Lldb-commits] [PATCH] D145559: [lldb] Remove unused POSIX ProcessMessage files

DavidSpickett created this revision. Herald added a subscriber: emaste. Herald added a project: All. DavidSpickett requested review of this revision. Herald added projects: LLDB, LLVM. Herald added subscribers: llvm-commits, lldb-commits. The last use of these was removed in cd443398566b953642ead7

[Lldb-commits] [PATCH] D145550: [LLDB][ObjectFileELF] Correct the return type of RelocOffset64 and RelocAddend64

SixWeining updated this revision to Diff 503264. SixWeining added a comment. Address @DavidSpickett's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145550/new/ https://reviews.llvm.org/D145550 Files: lldb/source/Plugins/ObjectFile/ELF/

[Lldb-commits] [PATCH] D145550: [LLDB][ObjectFileELF] Correct the return type of RelocOffset64 and RelocAddend64

SixWeining added a comment. In D145550#4177291 , @DavidSpickett wrote: > Seems to me that member functions of `ELFRelocation` should use the typedefs > from `lldb/source/Plugins/ObjectFile/ELF/ELFHeader.h` where there is one. > `elf_sxword` for example

[Lldb-commits] [PATCH] D145550: [LLDB][ObjectFileELF] Correct the return type of RelocOffset64 and RelocAddend64

DavidSpickett added a comment. Seems to me that member functions of `ELFRelocation` should use the typedefs from `lldb/source/Plugins/ObjectFile/ELF/ELFHeader.h` where there is one. `elf_sxword` for example. If you want to do that in another patch, that's fine. Just in case some test case is r

[Lldb-commits] [PATCH] D145462: [LLDB][ObjectFileELF] Support LoongArch64 in ApplyReloctions

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM. Comment at: lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:2623 +(is_signed && + ((int64_t)value > INT32_MAX && (int64_t)value < INT