[Lldb-commits] [lldb] e07e1d4 - [test] Increase test assertion for reasonable auxv values.

Author: Jordan Rupprecht Date: 2022-09-12T19:41:06-07:00 New Revision: e07e1d4425f837e5b38336664a24650834b3 URL: https://github.com/llvm/llvm-project/commit/e07e1d4425f837e5b38336664a24650834b3 DIFF: https://github.com/llvm/llvm-project/commit/e07e1d4425f837e5b38336664a24650834b3.di

[Lldb-commits] [PATCH] D133240: [Formatters][NFCI] Replace 'is_regex' arguments with an enum.

jgorbe updated this revision to Diff 459618. jgorbe added a comment. Fixed mis-spelled member name in comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133240/new/ https://reviews.llvm.org/D133240 Files: lldb/bindings/interface/SBTypeNameSpecifier.i lldb/include/lldb/API/SBTyp

[Lldb-commits] [PATCH] D133240: [Formatters][NFCI] Replace 'is_regex' arguments with an enum.

jgorbe marked an inline comment as done. jgorbe added inline comments. Comment at: lldb/include/lldb/DataFormatters/FormattersContainer.h:46 /// just matching by comparing with m_type_name string. - bool m_is_regex; + lldb::FormatterMatchType m_match_type;

[Lldb-commits] [PATCH] D133240: [Formatters][NFCI] Replace 'is_regex' arguments with an enum.

jgorbe updated this revision to Diff 459610. jgorbe added a comment. Updated comment above the declaration of TypeMatcher::m_match_type that referred to the old m_is_regex boolean, to address review feedback CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133240/new/ https://reviews.llvm

[Lldb-commits] [PATCH] D133623: Fix DW_OP_convert to resolve the CU relative offset correctly.

This revision was automatically updated to reflect the committed changes. Closed by commit rG376c7bd92aff: Fix DW_OP_convert to resolve the CU relative offset correctly. (authored by clayborg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133623/new

[Lldb-commits] [lldb] 376c7bd - Fix DW_OP_convert to resolve the CU relative offset correctly.

Author: Greg Clayton Date: 2022-09-12T16:53:19-07:00 New Revision: 376c7bd92aff0e4256b2842400936a9b29343045 URL: https://github.com/llvm/llvm-project/commit/376c7bd92aff0e4256b2842400936a9b29343045 DIFF: https://github.com/llvm/llvm-project/commit/376c7bd92aff0e4256b2842400936a9b29343045.diff

[Lldb-commits] [lldb] c9ccaf1 - Fix make invocation to pass in the correct source file

Author: Adrian Prantl Date: 2022-09-12T16:51:17-07:00 New Revision: c9ccaf176de7d7104492e19484f18e4b3ec1ba42 URL: https://github.com/llvm/llvm-project/commit/c9ccaf176de7d7104492e19484f18e4b3ec1ba42 DIFF: https://github.com/llvm/llvm-project/commit/c9ccaf176de7d7104492e19484f18e4b3ec1ba42.diff

[Lldb-commits] [lldb] 455aff7 - Force system C++ stdlib in test that forces system clang.

Author: Adrian Prantl Date: 2022-09-12T16:47:46-07:00 New Revision: 455aff72ce45982ae94e88d8b5474411a520047d URL: https://github.com/llvm/llvm-project/commit/455aff72ce45982ae94e88d8b5474411a520047d DIFF: https://github.com/llvm/llvm-project/commit/455aff72ce45982ae94e88d8b5474411a520047d.diff

[Lldb-commits] [lldb] 1910eeb - Fix make invocation to pass in the correct source file

Author: Adrian Prantl Date: 2022-09-12T16:36:56-07:00 New Revision: 1910eeb59f38f32a3ab25e3fb6f555cb35f4e5ed URL: https://github.com/llvm/llvm-project/commit/1910eeb59f38f32a3ab25e3fb6f555cb35f4e5ed DIFF: https://github.com/llvm/llvm-project/commit/1910eeb59f38f32a3ab25e3fb6f555cb35f4e5ed.diff

[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

davrec added inline comments. Comment at: clang/include/clang/AST/Type.h:5530-5537 /// Represents a type that was referred to using an elaborated type /// keyword, e.g., struct S, or via a qualified name, e.g., N::M::type, /// or both. /// /// This type is used to keep track

[Lldb-commits] [PATCH] D133164: Add the ability to show when variables fails to be available when debug info is valid.

This revision was automatically updated to reflect the committed changes. Closed by commit rG4763200ec95c: Add the ability to show when variables fails to be available when debug info is… (authored by clayborg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[Lldb-commits] [lldb] 4763200 - Add the ability to show when variables fails to be available when debug info is valid.

Author: Greg Clayton Date: 2022-09-12T13:59:05-07:00 New Revision: 4763200ec95ce6514403176017f29b87757b292a URL: https://github.com/llvm/llvm-project/commit/4763200ec95ce6514403176017f29b87757b292a DIFF: https://github.com/llvm/llvm-project/commit/4763200ec95ce6514403176017f29b87757b292a.diff

[Lldb-commits] [PATCH] D133623: Fix DW_OP_convert to resolve the CU relative offset correctly.

clayborg added a comment. Adrian: I added an extra compile unit into the YAML and verified it would fail without the fix. I also added the ability to select a different compile unit by index in the YAMLModuleTester so it can select the second compile unit in the test. Should be good to go now!

[Lldb-commits] [PATCH] D133623: Fix DW_OP_convert to resolve the CU relative offset correctly.

clayborg updated this revision to Diff 459551. clayborg added a comment. - Added the ability to select a compile unit by index to YAMLModuleTester - Added an extra empty compile unit to the yaml for DWARFExpression::DW_OP_convert test to make sure we can trigger the previous bug - Select the seco

[Lldb-commits] [PATCH] D133164: Add the ability to show when variables fails to be available when debug info is valid.

clayborg added a comment. If anyone can accept this diff again it would be most appreciated, the only failing buildbot was windows and I added @skipIfWindows to the failing test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133164/new/ https://re

[Lldb-commits] [PATCH] D133164: Add the ability to show when variables fails to be available when debug info is valid.

clayborg added inline comments. Comment at: lldb/test/API/commands/frame/var/TestFrameVar.py:166 +@skipIfRemote +@skipIfWindows # Windows can't set breakpoints by name 'main' in this case. +def test_gline_tables_only(self): This is the line that will

[Lldb-commits] [PATCH] D133164: Add the ability to show when variables fails to be available when debug info is valid.

clayborg updated this revision to Diff 459545. clayborg added a comment. Added a @skipIfWindows to make on TestFrameVar.test_gline_tables_only as windows doesn't seem to be able to set a breakpoint by function name 'main' when debug info is -gline-tables-only Repository: rG LLVM Github Monor

[Lldb-commits] [PATCH] D133164: Add the ability to show when variables fails to be available when debug info is valid.

clayborg reopened this revision. clayborg added a comment. This revision is now accepted and ready to land. Reopen for submission with windows fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133164/new/ https://reviews.llvm.org/D133164

[Lldb-commits] [PATCH] D133623: Fix DW_OP_convert to resolve the CU relative offset correctly.

aprantl added a comment. unless yaml2obj doesn't support multi-CU `.debug_info` sections. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133623/new/ https://reviews.llvm.org/D133623 ___ lldb-commits maili

[Lldb-commits] [PATCH] D133623: Fix DW_OP_convert to resolve the CU relative offset correctly.

aprantl added a comment. In D133623#3784604 , @clayborg wrote: > In D133623#378 , @aprantl wrote: > >> You would need to modify or clone the existing test >> https://github.com/llvm/llvm-project/blob/38ffa2bb

[Lldb-commits] [lldb] 67c73d8 - Reland "[lldb] Use just-built libcxx for tests when available"

Author: Felipe de Azevedo Piovezan Date: 2022-09-12T15:32:25-04:00 New Revision: 67c73d88de0e6b095a5eca46016277e4ac66d52d URL: https://github.com/llvm/llvm-project/commit/67c73d88de0e6b095a5eca46016277e4ac66d52d DIFF: https://github.com/llvm/llvm-project/commit/67c73d88de0e6b095a5eca46016277e4a

[Lldb-commits] [lldb] aedad60 - [LLDB][NativePDB] Add local variables with no location info.

Author: Zequan Wu Date: 2022-09-12T12:01:24-07:00 New Revision: aedad60231fcfd967f041616573caa7ff229e2b2 URL: https://github.com/llvm/llvm-project/commit/aedad60231fcfd967f041616573caa7ff229e2b2 DIFF: https://github.com/llvm/llvm-project/commit/aedad60231fcfd967f041616573caa7ff229e2b2.diff LOG

[Lldb-commits] [PATCH] D133626: [LLDB][NativePDB] Add local variables with no location info.

This revision was automatically updated to reflect the committed changes. Closed by commit rGaedad60231fc: [LLDB][NativePDB] Add local variables with no location info. (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133626/new/

[Lldb-commits] [PATCH] D133164: Add the ability to show when variables fails to be available when debug info is valid.

clayborg added a comment. Yikes, looks like you can't set a breakpoint by name 'main' on windows... I will add a skipIfWindows to the failing test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133164/new/ https://reviews.llvm.org/D133164 ___

[Lldb-commits] [PATCH] D133623: Fix DW_OP_convert to resolve the CU relative offset correctly.

clayborg added a comment. In D133623#378 , @aprantl wrote: > You would need to modify or clone the existing test > https://github.com/llvm/llvm-project/blob/38ffa2bb963714cd117b6d4534d328fa6a0fb875/lldb/unittests/Expression/DWARFExpressionTest.cpp#L1

[Lldb-commits] [lldb] 3271466 - Revert "Add the ability to show when variables fails to be available when debug info is valid."

Author: Stella Stamenova Date: 2022-09-12T11:31:17-07:00 New Revision: 327146639c049f3cff13c94ec44c12aa718b9fe4 URL: https://github.com/llvm/llvm-project/commit/327146639c049f3cff13c94ec44c12aa718b9fe4 DIFF: https://github.com/llvm/llvm-project/commit/327146639c049f3cff13c94ec44c12aa718b9fe4.di

[Lldb-commits] [PATCH] D131122: [lldb] Fixed a number of typos

GabrielRavier added a comment. Btw just so you know, I do not have commit access to LLVM so I cannot land this revision myself (I've also been told I should tell you my usual handle on git is `Gabriel Ravier ` w.r.t. that) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[Lldb-commits] [PATCH] D133623: Fix DW_OP_convert to resolve the CU relative offset correctly.

tschuett added inline comments. Comment at: lldb/source/Expression/DWARFExpression.cpp:2379 +// offset is compile unit relative so we need to fix it up. +die_offset += dwarf_cu->GetOffset(); // FIXME: the constness has annoying ripple effects. ---

[Lldb-commits] [PATCH] D133689: [lldb] Add SBBreakpointLocation::SetCallback

This revision was automatically updated to reflect the committed changes. Closed by commit rG6f5d109fca23: [lldb] Add SBBreakpointLocation::SetCallback (authored by lauralcg, committed by werat). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133689/n

[Lldb-commits] [lldb] 6f5d109 - [lldb] Add SBBreakpointLocation::SetCallback

Author: Laura Chaparro-Gutierrez Date: 2022-09-12T17:44:02Z New Revision: 6f5d109fca23056dd74d673d2e3439ece22c80b4 URL: https://github.com/llvm/llvm-project/commit/6f5d109fca23056dd74d673d2e3439ece22c80b4 DIFF: https://github.com/llvm/llvm-project/commit/6f5d109fca23056dd74d673d2e3439ece22c80b4

[Lldb-commits] [PATCH] D133623: Fix DW_OP_convert to resolve the CU relative offset correctly.

aprantl added a comment. You would need to modify or clone the existing test https://github.com/llvm/llvm-project/blob/38ffa2bb963714cd117b6d4534d328fa6a0fb875/lldb/unittests/Expression/DWARFExpressionTest.cpp#L153 and add a second CU to it. The inlined text is just the output of obj2yaml. Rep

[Lldb-commits] [PATCH] D133038: Add SBDebugger::GetSetting() public API

yinghuitan added inline comments. Comment at: lldb/include/lldb/Interpreter/OptionValue.h:86-87 + // TODO: make this function pure virtual after implementing it in all + // child classes. + virtual llvm::json::Value ToJSON(const ExecutionContext *exe_ctx) {

[Lldb-commits] [PATCH] D132954: lldb: Add support for R_386_32 relocations to ObjectFileELF

dmlary added a comment. Could someone please merge this? I do not have commit access. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132954/new/ https://reviews.llvm.org/D132954 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https:

[Lldb-commits] [lldb] 8599cb0 - Skip crashing test

Author: Adrian Prantl Date: 2022-09-12T09:48:42-07:00 New Revision: 8599cb002b635bb6bedeaebe622be333d579697b URL: https://github.com/llvm/llvm-project/commit/8599cb002b635bb6bedeaebe622be333d579697b DIFF: https://github.com/llvm/llvm-project/commit/8599cb002b635bb6bedeaebe622be333d579697b.diff

[Lldb-commits] [PATCH] D133639: [lldb] Fix detection of existing libcxx

This revision was automatically updated to reflect the committed changes. Closed by commit rGfc04749957f1: [lldb] Fix detection of existing libcxx (authored by fdeazeve). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133639/new/ https://reviews.llvm

[Lldb-commits] [lldb] fc04749 - [lldb] Fix detection of existing libcxx

Author: Felipe de Azevedo Piovezan Date: 2022-09-12T12:34:11-04:00 New Revision: fc04749957f17f42b1eab538fa3e68857034facb URL: https://github.com/llvm/llvm-project/commit/fc04749957f17f42b1eab538fa3e68857034facb DIFF: https://github.com/llvm/llvm-project/commit/fc04749957f17f42b1eab538fa3e68857

[Lldb-commits] [PATCH] D133639: [lldb] Fix detection of existing libcxx

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133639/new/ https://reviews.llvm.org/D133639 __

[Lldb-commits] [PATCH] D133639: [lldb] Fix detection of existing libcxx

fdeazeve updated this revision to Diff 459474. fdeazeve edited the summary of this revision. fdeazeve added a comment. Addressed review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133639/new/ https://reviews.llvm.org/D133639 Files: lld

[Lldb-commits] [PATCH] D133038: Add SBDebugger::GetSetting() public API

JDevlieghere added inline comments. Comment at: lldb/include/lldb/Core/UserSettingsController.h:62-64 virtual void DumpAllPropertyValues(const ExecutionContext *exe_ctx, - Stream &strm, uint32_t dump_mask); +

[Lldb-commits] [PATCH] D133689: [lldb] Add SBBreakpointLocation::SetCallback

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133689/new/ https://reviews.llvm.org/D133689 ___ lldb-commits mailing list lldb-commi

[Lldb-commits] [PATCH] D133639: [lldb] Fix detection of existing libcxx

JDevlieghere added inline comments. Comment at: lldb/test/API/lit.cfg.py:181-184 +if is_configured_and_true('has_libcxx') and platform.system() != 'Windows': if is_configured('llvm_include_dir') and is_configured('llvm_libs_dir'): dotest_cmd += ['--libcxx-include-dir', o

[Lldb-commits] [PATCH] D133689: [lldb] Add SBBreakpointLocation::SetCallback

werat accepted this revision. werat added a comment. This revision is now accepted and ready to land. Look good to me, but giving some time for others to take a look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133689/new/ https://reviews.llvm.or

[Lldb-commits] [PATCH] D133639: [lldb] Fix detection of existing libcxx

fdeazeve updated this revision to Diff 459441. fdeazeve added a comment. Addressed review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133639/new/ https://reviews.llvm.org/D133639 Files: lldb/test/API/lit.cfg.py Index: lldb/test/API/l

[Lldb-commits] [PATCH] D133689: LLDB: Add SBBreakpointLocation::SetCallback

lauralcg created this revision. lauralcg added a reviewer: werat. Herald added a project: All. lauralcg requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. - Include SetCallback in SBBreakpointLocation, similar as in SBBreakpointLocation. - A

[Lldb-commits] [PATCH] D133639: [lldb] Fix detection of existing libcxx

fdeazeve added inline comments. Comment at: lldb/test/API/lit.cfg.py:181-184 +if is_configured_and_true('has_libcxx') and platform.system() != 'Windows': if is_configured('llvm_include_dir') and is_configured('llvm_libs_dir'): dotest_cmd += ['--libcxx-include-dir', os.pa

[Lldb-commits] [PATCH] D133680: Add support for mach-o corefile loading of a platform binary

DavidSpickett added inline comments. Comment at: lldb/include/lldb/Target/DynamicLoader.h:231 + /// Name of the binary, if available. If an empty StringRef is + /// passed here, a name will be constructed for the module. + /// Can you list what it mig