yinghuitan added inline comments.
================
Comment at: lldb/include/lldb/Interpreter/OptionValue.h:86-87
+ // TODO: make this function pure virtual after implementing it in all
+ // child classes.
+ virtual llvm::json::Value ToJSON(const ExecutionContext *exe_ctx) {
----------------
JDevlieghere wrote:
> Is this done?
No. My goal is simply adding a public API for testing auto deduce source map
feature, this patch is much larger than I wanted to achieve so it focuses
adding skeleton of the API and implements a subset of OptionValue child classes
leaving the remaining for future patches (the implementation is not hard but
adding test coverage takes some time).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133038/new/
https://reviews.llvm.org/D133038
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
