jgorbe marked an inline comment as done. jgorbe added inline comments.
================ Comment at: lldb/include/lldb/DataFormatters/FormattersContainer.h:46 /// just matching by comparing with m_type_name string. - bool m_is_regex; + lldb::FormatterMatchType m_match_type; ---------------- hawkinsw wrote: > I am really intrigued by this entire patchset and just wanted to drop by to > help, if I could. I hope that I am not upsetting you by commenting on > something so trivial, but it seems like we would want to change the comment > for this data member while we are at it? > > Again, I think this work is great and I hope I am helping! Good catch! I have updated the comment. Thanks for pointing it out :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133240/new/ https://reviews.llvm.org/D133240 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
