[Lldb-commits] [PATCH] D128250: [LLDB][RISCV]Add initial support for lldb-server.

Emmmer abandoned this revision. Emmmer added a comment. Done in D130342 and D131566 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128250/new/ https://reviews.llvm.org/D128250

[Lldb-commits] [lldb] 0247b5a - [LLDB][RISCV] Add riscv software breakpoint trap code

Author: Emmmer Date: 2022-08-11T14:26:22+08:00 New Revision: 0247b5aaae7ae02f140ca9509dc68078cfe55898 URL: https://github.com/llvm/llvm-project/commit/0247b5aaae7ae02f140ca9509dc68078cfe55898 DIFF: https://github.com/llvm/llvm-project/commit/0247b5aaae7ae02f140ca9509dc68078cfe55898.diff LOG: [

[Lldb-commits] [PATCH] D131566: [LLDB][RISCV] Add riscv software breakpoint trap code

This revision was automatically updated to reflect the committed changes. Closed by commit rG0247b5aaae7a: [LLDB][RISCV] Add riscv software breakpoint trap code (authored by Emmmer). Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[Lldb-commits] [PATCH] D130342: [LLDB][RISCV] Add riscv register definition and read/write

This revision was automatically updated to reflect the committed changes. Closed by commit rG7bece0f03bf6: [LLDB][RISCV] Add riscv register definition and read/write (authored by Emmmer). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130342/new/ htt

[Lldb-commits] [lldb] 7bece0f - [LLDB][RISCV] Add riscv register definition and read/write

Author: Emmmer Date: 2022-08-11T14:24:06+08:00 New Revision: 7bece0f03bf6cbf7f98812b7cff0e789709c9982 URL: https://github.com/llvm/llvm-project/commit/7bece0f03bf6cbf7f98812b7cff0e789709c9982 DIFF: https://github.com/llvm/llvm-project/commit/7bece0f03bf6cbf7f98812b7cff0e789709c9982.diff LOG: [

[Lldb-commits] [PATCH] D51387: Allow Template argument accessors to automatically unwrap parameter packs

JDevlieghere added a comment. In D51387#1387074 , @clayborg wrote: > Do we have any callers that call GetNumTemplateArguments with false? If not, > remove the argument? Yup, there's a bunch of uses in `Language/CPlusPlus/LibCxx*.cpp` CHANGES SINCE LAST

[Lldb-commits] [PATCH] D51387: Allow Template argument accessors to automatically unwrap parameter packs

JDevlieghere updated this revision to Diff 451714. JDevlieghere added a comment. - Rebase - Address Jim's code review feedback CHANGES SINCE LAST ACTION https://reviews.llvm.org/D51387/new/ https://reviews.llvm.org/D51387 Files: lldb/include/lldb/Symbol/CompilerType.h lldb/include/lldb/S

[Lldb-commits] [PATCH] D51387: Allow Template argument accessors to automatically unwrap parameter packs

JDevlieghere commandeered this revision. JDevlieghere added a reviewer: friss. JDevlieghere added a comment. Herald added a reviewer: shafik. Herald added a project: All. Commandeering this from Fred CHANGES SINCE LAST ACTION https://reviews.llvm.org/D51387/new/ https://reviews.llvm.org/D5138

[Lldb-commits] [PATCH] D131615: [LLDB][NFC] Reliability fixes for IOHandlerCursesGUI

clayborg added inline comments. Comment at: lldb/source/Core/IOHandlerCursesGUI.cpp:391-394 + uint32_t GetMaxX() const { return getmaxx(m_window); } + uint32_t GetMaxY() const { return getmaxy(m_window); } + uint32_t GetWidth() const { return GetMaxX(); } + uint32_t GetHeight

[Lldb-commits] [PATCH] D131554: [LLDB][NFC] Reliability fixes for ObjectFileMachO.cpp

clayborg added inline comments. Comment at: lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp:540 +for (uint32_t i = 0; + count > 0 && count <= sizeof(gpr.r) && i < count - 1; ++i) { gpr.r[i] = data.GetU32(&offset); =

[Lldb-commits] [PATCH] D113155: [lldb] Remove nested switches from ARMGetSupportedArchitectureAtIndex (NFC)

fixathon added a comment. Added a comment about a failing test. Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp:561 + default: +LLVM_FALLTHROUGH; + case ArchSpec::eCore_arm_arm64: { JDevlieghere wrote: > fixathon wrote: > > This will de

[Lldb-commits] [PATCH] D130796: [LLDB][NativePDB] Switch to use DWARFLocationList.

zequanwu added inline comments. Comment at: lldb/source/Plugins/SymbolFile/NativePDB/PdbUtil.cpp:843-846 +std::map offset_to_size; +// Get the size of each fields if it's udt. +if (!FindMembersSize::GetMemberSizesForUdt(result.type, index.tpi(), 0, +

[Lldb-commits] [PATCH] D131335: WIP: [lldb] abi_tag support 3/3 - Use mangle tree API to determine approximate mangled matches

Michael137 added a comment. In D131335#3712243 , @labath wrote: > In D131335#3710236 , @Michael137 > wrote: > >> In D131335#3709788 , @labath wrote: >> >>> I haven't been

[Lldb-commits] [PATCH] D131630: [trace][intel pt] Fix per-psb packet decoding

wallace updated this revision to Diff 451685. wallace added a comment. improve documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131630/new/ https://reviews.llvm.org/D131630 Files: lldb/include/lldb/Target/TraceCursor.h lldb/include/

[Lldb-commits] [PATCH] D124314: lldb: Disable unittests if llvm_gtest target does not exist

This revision was automatically updated to reflect the committed changes. Closed by commit rG9c6c4d675bd1: lldb: Disable unittests if llvm_gtest target does not exist (authored by tstellar). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124314/new/

[Lldb-commits] [lldb] 9c6c4d6 - lldb: Disable unittests if llvm_gtest target does not exist

Author: Tom Stellard Date: 2022-08-10T16:56:08-07:00 New Revision: 9c6c4d675bd1c17cfbfb9aaa18a05e5f0a0ca634 URL: https://github.com/llvm/llvm-project/commit/9c6c4d675bd1c17cfbfb9aaa18a05e5f0a0ca634 DIFF: https://github.com/llvm/llvm-project/commit/9c6c4d675bd1c17cfbfb9aaa18a05e5f0a0ca634.diff

[Lldb-commits] [PATCH] D131630: [trace][intel pt] Fix per-psb packet decoding

wallace updated this revision to Diff 451670. wallace edited the summary of this revision. wallace added a comment. nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131630/new/ https://reviews.llvm.org/D131630 Files: lldb/include/lldb/Target/Tr

[Lldb-commits] [PATCH] D131328: [lldb] Support fetching symbols with dsymForUUID in the background

jasonmolenda added a comment. This is an awesome enhancement for environments where the dSYM can be located programmatically --- downloading only the dSYMs that are actually being used in a debug session makes it low overhead versus grabbing everything, and it's great to have them loaded for yo

[Lldb-commits] [PATCH] D131542: [lldb/crashlog] Add `-V|--version` option

This revision was automatically updated to reflect the committed changes. Closed by commit rG3f3db135251c: [lldb/crashlog] Add `-V|--version` option (authored by mib). Changed prior to commit: https://reviews.llvm.org/D131542?vs=451358&id=451669#toc Repository: rG LLVM Github Monorepo CHANG

[Lldb-commits] [lldb] 3f3db13 - [lldb/crashlog] Add `-V|--version` option

Author: Med Ismail Bennani Date: 2022-08-10T16:18:46-07:00 New Revision: 3f3db135251c85503fde681dd34e8ced0606aee2 URL: https://github.com/llvm/llvm-project/commit/3f3db135251c85503fde681dd34e8ced0606aee2 DIFF: https://github.com/llvm/llvm-project/commit/3f3db135251c85503fde681dd34e8ced0606aee2.

[Lldb-commits] [PATCH] D131630: [trace][intel pt] Fix per-psb packet decoding

wallace created this revision. wallace added reviewers: jj10306, persona0220. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The per-PSB packet decoding logic was wrong because it was assuming that pt_

[Lldb-commits] [PATCH] D131613: [LLDB][NFC] Clean up dead code

This revision was automatically updated to reflect the committed changes. Closed by commit rGf4c21ab8b32d: [LLDB][NFC] Clean up dead code (authored by fixathon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131613/new/ https://reviews.llvm.org/D131

[Lldb-commits] [lldb] f4c21ab - [LLDB][NFC] Clean up dead code

Author: Slava Gurevich Date: 2022-08-10T15:22:15-07:00 New Revision: f4c21ab8b32d57d6db643b5f230b8ceb7b06c84c URL: https://github.com/llvm/llvm-project/commit/f4c21ab8b32d57d6db643b5f230b8ceb7b06c84c DIFF: https://github.com/llvm/llvm-project/commit/f4c21ab8b32d57d6db643b5f230b8ceb7b06c84c.diff

[Lldb-commits] [PATCH] D131554: [LLDB][NFC] Reliability fixes for ObjectFileMachO.cpp

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. fixathon marked 2 inline comments as done. Closed by commit rGdb9322b2066c: [LLDB][NFC] Reliability fixes for ObjectFileMachO.cpp (authored by fixathon). Repository:

[Lldb-commits] [lldb] db9322b - [LLDB][NFC] Reliability fixes for ObjectFileMachO.cpp

Author: Slava Gurevich Date: 2022-08-10T15:16:37-07:00 New Revision: db9322b2066c55254e7691efeab863f43bfcc084 URL: https://github.com/llvm/llvm-project/commit/db9322b2066c55254e7691efeab863f43bfcc084 DIFF: https://github.com/llvm/llvm-project/commit/db9322b2066c55254e7691efeab863f43bfcc084.diff

[Lldb-commits] [PATCH] D131554: [LLDB][NFC] Reliability fixes for ObjectFileMachO.cpp

fixathon updated this revision to Diff 451652. fixathon marked 4 inline comments as done. fixathon added a comment. Fix some nits in comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131554/new/ https://reviews.llvm.org/D131554 Files: lldb/

[Lldb-commits] [PATCH] D131554: [LLDB][NFC] Reliability fixes for ObjectFileMachO.cpp

jasonmolenda accepted this revision. jasonmolenda added a comment. LGTM. fwiw it's nul-terminated ("NUL" being the '\0' character), not null-terminated ((void*)0). i don't really care, but nb. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131554/n

[Lldb-commits] [PATCH] D131613: [LLDB][NFC] Clean up dead code

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131613/new/ https://reviews.llvm.org/D131613 __

[Lldb-commits] [PATCH] D131554: [LLDB][NFC] Reliability fixes for ObjectFileMachO.cpp

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp:6344 segment_vmaddr seg_vmaddr; +// this is the uncommon case where strncpy is exactly +// the right one, doesn't need to be nul terminated.

[Lldb-commits] [PATCH] D131554: [LLDB][NFC] Reliability fixes for ObjectFileMachO.cpp

fixathon updated this revision to Diff 451629. fixathon added a comment. Addressing reviewer comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131554/new/ https://reviews.llvm.org/D131554 Files: lldb/source/Plugins/ObjectFile/Mach-O/ObjectF

[Lldb-commits] [PATCH] D131554: [LLDB][NFC] Reliability fixes for ObjectFileMachO.cpp

fixathon added inline comments. Comment at: lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp:540 +for (uint32_t i = 0; + count > 0 && count <= sizeof(gpr.r) && i < count - 1; ++i) { gpr.r[i] = data.GetU32(&offset); jasonmol

[Lldb-commits] [PATCH] D131554: [LLDB][NFC] Reliability fixes for ObjectFileMachO.cpp

jasonmolenda added inline comments. Comment at: lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp:540 +for (uint32_t i = 0; + count > 0 && count <= sizeof(gpr.r) && i < count - 1; ++i) { gpr.r[i] = data.GetU32(&offset); jaso

[Lldb-commits] [PATCH] D131543: [LLDB][NFC] Fix the style issue in TCPSocket

jasonmolenda added a comment. Ah, I think ChrisB added these `-1 ==` lines in TCPSocket.cpp when he was adding ipv6 support years ago. I was only thinking of the two new ones you added in https://reviews.llvm.org/D131294 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[Lldb-commits] [PATCH] D131605: [lldb][tests] Test queue-specific breakpoints

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. This looks good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131605/new/ https://reviews.llvm.org/D131605 _

[Lldb-commits] [PATCH] D131554: [LLDB][NFC] Reliability fixes for ObjectFileMachO.cpp

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Looks good to me with a few suggestions inlined. Comment at: lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp:537 + +// Prevent static analysis w

[Lldb-commits] [PATCH] D131554: [LLDB][NFC] Reliability fixes for ObjectFileMachO.cpp

fixathon added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131554/new/ https://reviews.llvm.org/D131554 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/

[Lldb-commits] [PATCH] D131531: [lldb] Allow DataFileCache to be constructed with a different policy

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/source/Core/DataFileCache.cpp:23-46 +llvm::CachePruningPolicy DataFileCache::GetLLDBIndexCachePolicy() { + static llvm::CachePruningPolicy

[Lldb-commits] [PATCH] D131543: [LLDB][NFC] Fix the style issue in TCPSocket

fixathon added a comment. I'd prefer to not reformat the pre-existing 13 instances of (-1 ==) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131543/new/ https://reviews.llvm.org/D131543 ___ lldb-commits m

[Lldb-commits] [PATCH] D131615: [LLDB][NFC] Reliability fixes for IOHandlerCursesGUI

fixathon created this revision. fixathon added reviewers: clayborg, JDevlieghere, DavidSpickett, jasonmolenda. Herald added a project: All. fixathon requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. - checking retval of function calls - signe

[Lldb-commits] [PATCH] D131543: [LLDB][NFC] Fix the style issue in TCPSocket

jasonmolenda added a comment. Did you also want to adjust the `if (-1 == SetOptionNoDelay()) {` line from that patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131543/new/ https://reviews.llvm.org/D131543 _

[Lldb-commits] [PATCH] D131613: [LLDB][NFC] Clean up dead code

fixathon created this revision. fixathon added reviewers: clayborg, JDevlieghere, DavidSpickett, jasonmolenda. Herald added a project: All. fixathon requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Remove unreachable code that will never exe

[Lldb-commits] [PATCH] D130796: [LLDB][NativePDB] Switch to use DWARFLocationList.

rnk added inline comments. Comment at: lldb/source/Plugins/SymbolFile/NativePDB/PdbUtil.cpp:843-846 +std::map offset_to_size; +// Get the size of each fields if it's udt. +if (!FindMembersSize::GetMemberSizesForUdt(result.type, index.tpi(), 0, +

[Lldb-commits] [PATCH] D131605: [lldb][tests] Test queue-specific breakpoints

cassanova created this revision. cassanova added reviewers: JDevlieghere, mib, jingham. cassanova added a project: LLDB. Herald added a project: All. cassanova requested review of this revision. Herald added a subscriber: lldb-commits. This commit adds tests to ensure that queue-specific breakpoin

[Lldb-commits] [PATCH] D131531: [lldb] Allow DataFileCache to be constructed with a different policy

augusto2112 updated this revision to Diff 451565. augusto2112 added a comment. Made GetLLDBIndexCachePolicy public Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131531/new/ https://reviews.llvm.org/D131531 Files: lldb/include/lldb/Core/DataFileC

[Lldb-commits] [PATCH] D131531: [lldb] Allow DataFileCache to be constructed with a different policy

JDevlieghere added inline comments. Comment at: lldb/include/lldb/Core/DataFileCache.h:82 private: + /// Gets the default LLDB index cache policy, which is s It's a little weird that `GetLLDBIndexCachePolicy` would be private, if only from a documentation p

[Lldb-commits] [PATCH] D131542: [lldb/crashlog] Add `-V|--version` option

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Makes sense Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131542/new/ https://reviews.llvm.org/D131542

[Lldb-commits] [PATCH] D131531: [lldb] Allow DataFileCache to be constructed with a different policy

augusto2112 updated this revision to Diff 451549. augusto2112 added a comment. Added a static 'GetLLDBIndexCachePolicy' function, removed the constructor without any policies Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131531/new/ https://review

[Lldb-commits] [PATCH] D131407: [lldb] Flush the global thread pool in Debugger::Terminate

JDevlieghere added a comment. @labath Ping in case it got pushed down your review queue. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131407/new/ https://reviews.llvm.org/D131407 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http

[Lldb-commits] [PATCH] D131531: [lldb] Allow DataFileCache to be constructed with a different policy

augusto2112 added a comment. In D131531#3711618 , @clayborg wrote: > Is this new constructor going to be used elsewhere? It would be great to get > more description on why this is desired/needed? I'm implementing a cache for swift type metadata for down

[Lldb-commits] [PATCH] D130342: [LLDB][RISCV] Add riscv register stuff

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. > we can add them back if required in the future. Sounds good to me. Certainly SVE for Arm required a bunch of changes, a lot easier to do it later. This LGTM, but: [LLDB][RI

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added a comment. Hi - I tried to incorporate all the feedback here and added a post to discourse suggesting tweaks to the developer policy - please have a look and review it: https://discourse.llvm.org/t/rfc-updates-to-developer-policy-around-c-standards-bump/64383 Repository: rG LLVM

[Lldb-commits] [PATCH] D131333: [lldb] abi_tag support 2/3 - Make FindBestAlternateFunctionMangledName local to the C++ language plugin

aprantl added inline comments. Comment at: lldb/include/lldb/Target/Language.h:317 + /// function names. + /// + /// \param[in] mangled_names List of mangled names to generate JDevlieghere wrote: > I was wondering the same. I think it's wor

[Lldb-commits] [PATCH] D131539: [lldb] Make sure all Python API tests are marked as NO_DEBUG_INFO_TESTCASE

JDevlieghere added a comment. In D131539#3711835 , @labath wrote: > In D131539#3711518 , @JDevlieghere > wrote: > >> In D131539#3711488 , @kastiglione >> wrote: >> >>> t

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

thakis added a comment. Re rollout: I suggested further up to put this behind an opt-in variable. That would've allowed people to test this on their setups. I still think that's a good suggestion, and it would've identified the MSVC issue at least. Repository: rG LLVM Github Monorepo CHANGE

[Lldb-commits] [PATCH] D130342: [LLDB][RISCV] Add riscv register stuff

Emmmer updated this revision to Diff 451442. Emmmer marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130342/new/ https://reviews.llvm.org/D130342 Files: lldb/source/Host/common/HostInfoBase.cpp lldb/source/Plugins/Process/Linux/CMakeLists.txt lldb/sou

[Lldb-commits] [PATCH] D130342: [LLDB][RISCV] Add riscv register stuff

Emmmer updated this revision to Diff 451441. Emmmer retitled this revision from "[LLDB][RISCV] Add register stuff and make breakpoint work" to "[LLDB][RISCV] Add riscv register stuff". Emmmer edited the summary of this revision. Emmmer added a comment. Address review comments: - Split the softwa

[Lldb-commits] [PATCH] D126359: [LLDB] Add basic floating point ops to IR interpreter

This revision was automatically updated to reflect the committed changes. Closed by commit rGf63e2cfb7f52: [LLDB] Add basic floating point ops to IR interpreter (authored by kpdev42). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126359/new/ https:/

[Lldb-commits] [lldb] f63e2cf - [LLDB] Add basic floating point ops to IR interpreter

Author: Pavel Kosov Date: 2022-08-10T16:34:52+03:00 New Revision: f63e2cfb7f5235d4d5148988e8a0ef86004da66e URL: https://github.com/llvm/llvm-project/commit/f63e2cfb7f5235d4d5148988e8a0ef86004da66e DIFF: https://github.com/llvm/llvm-project/commit/f63e2cfb7f5235d4d5148988e8a0ef86004da66e.diff L

[Lldb-commits] [PATCH] D131335: WIP: [lldb] abi_tag support 3/3 - Use mangle tree API to determine approximate mangled matches

labath added a comment. In D131335#3710236 , @Michael137 wrote: > In D131335#3709788 , @labath wrote: > >> I haven't been able to keep up with all the lldb happenings lately, so it's >> possible I have missed so

[Lldb-commits] [PATCH] D131335: WIP: [lldb] abi_tag support 3/3 - Use mangle tree API to determine approximate mangled matches

Michael137 added a comment. Another interesting example of how the fallback mechanism produces unexpected result: namespace A { struct B {}; template [[gnu::abi_tag ("vTest")]] int insideNS(T t) { return 0; } [[gnu::abi_tag ("vTest")]] int inside

[Lldb-commits] [PATCH] D131159: [lldb] Use WSAEventSelect for MainLoop polling on windows

alvinhochun added a comment. I gave this a spin with `LLDB_USE_LLDB_SERVER=1`, but there looks to be some pre-existing issues with the lldb-server implementation so I can't really test much normally using builds of Krita: - Manually set breakpoints don't work (they stay unresolved?) - Debugger

[Lldb-commits] [PATCH] D130342: [LLDB][RISCV] Add register stuff and make breakpoint work

DavidSpickett added a comment. Can "and make breakpoint work" be made into its own patch? I'd much rather see "register read and write" and "software breakpoints" in their own changes (and please differentiate in commit title/messages between hardware break and software break). (otherwise the

[Lldb-commits] [PATCH] D131554: [LLDB][NFC] Reliability fixes for ObjectFileMachO.cpp

fixathon added a comment. Added inline comments to clarify the fixes. Specifically need feedback on the null-termination of strings since it seems possible this may not be needed based on existing comments. Comment at: lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp

[Lldb-commits] [lldb] 552dccf - [LLDB][AArch64][NFC] Fix some clang-format annotations

Author: David Spickett Date: 2022-08-10T10:22:21Z New Revision: 552dccf311c6134c6c895328602172821e3efaed URL: https://github.com/llvm/llvm-project/commit/552dccf311c6134c6c895328602172821e3efaed DIFF: https://github.com/llvm/llvm-project/commit/552dccf311c6134c6c895328602172821e3efaed.diff LOG

[Lldb-commits] [PATCH] D131554: [LLDB][NFC] Reliability fixes for ObjectFileMachO.cpp

fixathon created this revision. fixathon added reviewers: clayborg, JDevlieghere, DavidSpickett, jasonmolenda. Herald added a project: All. fixathon requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Static code inspection guided fixes for the

[Lldb-commits] [PATCH] D130342: [LLDB][RISCV] Add register stuff and make breakpoint work

Emmmer added a comment. In D130342#3711534 , @tzb99 wrote: > In D130342#3710299 , @Emmmer wrote: > >> In D130342#3710122 , @tzb99 wrote: >> >>> In D130342#3709772

[Lldb-commits] [PATCH] D131159: [lldb] Use WSAEventSelect for MainLoop polling on windows

mstorsjo added a comment. In D131159#3711024 , @mstorsjo wrote: > In D131159#3709965 , @labath wrote: > >>> Can @alvinhochun take the patch for a spin? I think you've got more >>> realistic usecases of lldb to tr

[Lldb-commits] [PATCH] D131472: [LLDB] Add multi value test for const static enum

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5e538c669c76: [LLDB] Add multi value test for const static enum (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[Lldb-commits] [lldb] 5e538c6 - [LLDB] Add multi value test for const static enum

Author: David Spickett Date: 2022-08-10T08:50:12Z New Revision: 5e538c669c76d26642f64cd03a6c09e5eee436b0 URL: https://github.com/llvm/llvm-project/commit/5e538c669c76d26642f64cd03a6c09e5eee436b0 DIFF: https://github.com/llvm/llvm-project/commit/5e538c669c76d26642f64cd03a6c09e5eee436b0.diff LOG

[Lldb-commits] [PATCH] D131472: [LLDB] Add multi value test for const static enum

DavidSpickett updated this revision to Diff 451386. DavidSpickett added a comment. invalid -> not_enumerator Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131472/new/ https://reviews.llvm.org/D131472 Files: lldb/test/API/lang/cpp/const_static_i

[Lldb-commits] [PATCH] D131539: [lldb] Make sure all Python API tests are marked as NO_DEBUG_INFO_TESTCASE

labath added a comment. In D131539#3711518 , @JDevlieghere wrote: > In D131539#3711488 , @kastiglione > wrote: > >> this diff has made me wonder: should we have a `NoDebugInfoTestCase` that >> can be used by an

[Lldb-commits] [PATCH] D130062: [lldb][DWARF5] Enable macro evaluation

kpdev42 updated this revision to Diff 451364. kpdev42 added a comment. Address review notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130062/new/ https://reviews.llvm.org/D130062 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFContext.cpp