fixathon added a comment.
Added a comment about a failing test.
================
Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp:561
+ default:
+ LLVM_FALLTHROUGH;
+ case ArchSpec::eCore_arm_arm64: {
----------------
JDevlieghere wrote:
> fixathon wrote:
> > This will default to the ArchSpec::eCore_arm_arm64 case if no matching
> > ArchSpec is specified. Double-checking if this by intent.
> I'm sure it was intentional when I wrote it, but I can't figure out for which
> core this would actually make sense. If the test suite passes with returning
> an empty array here, that works for me.
When this is fixed, one test is failing, and I think that might be a problem
with the test itself: test_ios in
test/API/functionalities/gdb_remote_client/TestPlatformMacOSX.py running on
MacOS.
File
"lvm-project/lldb/test/API/functionalities/gdb_remote_client/TestPlatformMacOSX.py",
line 48, in test_ios
self.platform_test(host="ios",
File
"llvm-project/lldb/test/API/functionalities/gdb_remote_client/TestPlatformMacOSX.py",
line 44, in platform_test
self.assertEqual(platform.GetName(), expected_platform)
AssertionError: 'host' != 'remote-ios'
- host+ remote-ios
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D113155/new/
https://reviews.llvm.org/D113155
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
