[Lldb-commits] [PATCH] D85993: [lldb] Set the access property on member function decls

teemperor added a comment. In D85993#2253465 , @amccarth wrote: > In D85993#2220724 , @labath wrote: > >> Dwarf parser uses `TypeSystemClang::AddMethodToCXXRecordType` instead of >> this function to create methods

[Lldb-commits] [PATCH] D86497: [lldb] Add reproducer verifier

This revision was automatically updated to reflect the committed changes. Closed by commit rG3746906193c1: [lldb] Add reproducer verifier (authored by JDevlieghere). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86497/new/ https://reviews.llvm.org/D

[Lldb-commits] [lldb] 3746906 - [lldb] Add reproducer verifier

Author: Jonas Devlieghere Date: 2020-09-02T22:00:00-07:00 New Revision: 3746906193c1be913fe60072de9d4feb80f9c461 URL: https://github.com/llvm/llvm-project/commit/3746906193c1be913fe60072de9d4feb80f9c461 DIFF: https://github.com/llvm/llvm-project/commit/3746906193c1be913fe60072de9d4feb80f9c461.d

[Lldb-commits] [lldb] fa95e35 - [lldb] Pass -fno-objc-exceptions for objcxx targets

Author: Jonas Devlieghere Date: 2020-09-02T21:59:48-07:00 New Revision: fa95e35593353810c1b26e3641451fa82089d792 URL: https://github.com/llvm/llvm-project/commit/fa95e35593353810c1b26e3641451fa82089d792 DIFF: https://github.com/llvm/llvm-project/commit/fa95e35593353810c1b26e3641451fa82089d792.d

[Lldb-commits] [PATCH] D86497: [lldb] Add reproducer verifier

JDevlieghere added a comment. Thanks, should be fixed by 426fa35b655ffb8647d9d69580a69627c0d19024 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86497/new/ https://reviews.llvm.o

[Lldb-commits] [lldb] 426fa35 - [lldb] Always record both the working and home directory.

Author: Jonas Devlieghere Date: 2020-09-02T20:53:11-07:00 New Revision: 426fa35b655ffb8647d9d69580a69627c0d19024 URL: https://github.com/llvm/llvm-project/commit/426fa35b655ffb8647d9d69580a69627c0d19024 DIFF: https://github.com/llvm/llvm-project/commit/426fa35b655ffb8647d9d69580a69627c0d19024.d

[Lldb-commits] [PATCH] D86825: [lldb/Gui] zero-initialize children_stop_id

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf7e04b710d2d: [lldb/Gui] zero-initialize children_stop_id (authored by rupprecht). Changed prior to commit: https://reviews.llvm.org/D86825?vs=288

[Lldb-commits] [lldb] f7e04b7 - [lldb/Gui] zero-initialize children_stop_id

Author: Jordan Rupprecht Date: 2020-09-02T20:05:17-07:00 New Revision: f7e04b710d2d90ae913e737550f7eec03d2c9f37 URL: https://github.com/llvm/llvm-project/commit/f7e04b710d2d90ae913e737550f7eec03d2c9f37 DIFF: https://github.com/llvm/llvm-project/commit/f7e04b710d2d90ae913e737550f7eec03d2c9f37.di

[Lldb-commits] [PATCH] D86825: [lldb/Gui] zero-initialize children_stop_id

rupprecht marked an inline comment as done. rupprecht added a comment. SG, will land momentarily with the one formatting change. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86825/new/ https://reviews.llvm.org/D86825 _

[Lldb-commits] [PATCH] D86899: [trace][RFC] create skeleton for thread decoder

clayborg added a comment. I am not sure we need any of the classes in Trace.h: TraceInstruction, TraceDecodedThread, or TraceThread. We should be able to use history thread objects for threads that are currently vended by TraceThread. Each thread will have a current set of hard coded stack fra

[Lldb-commits] [PATCH] D86670: [intel-pt] Add a basic implementation of the dump command

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. I think we should remove the "Stream *s;" from the TraceDumpOptions struct since we have a "Stream &s" as an argument already. We can't use a reference in the TraceDumpOptions wi

[Lldb-commits] [PATCH] D86825: [lldb/Gui] zero-initialize children_stop_id

clayborg added inline comments. Comment at: lldb/source/Core/IOHandlerCursesGUI.cpp:1500-1513 uint32_t children_stop_id; int row_idx; int x; int y; bool might_have_children; bool expanded; bool calculated_children; Or we can inline the simple

[Lldb-commits] [lldb] 5f6ca06 - Revert de6caf871be79dc7549aebe4e4fb57d52f6ed202 and 51128b670d4f757132e927c4f3dd78d257d37f70 (https://reviews.llvm.org/D84974)

Author: Walter Erquinigo Date: 2020-09-02T17:06:48-07:00 New Revision: 5f6ca065a55fcbd2b39e3d32b3eb3deb04aa3e97 URL: https://github.com/llvm/llvm-project/commit/5f6ca065a55fcbd2b39e3d32b3eb3deb04aa3e97 DIFF: https://github.com/llvm/llvm-project/commit/5f6ca065a55fcbd2b39e3d32b3eb3deb04aa3e97.di

[Lldb-commits] [PATCH] D85993: [lldb] Set the access property on member function decls

amccarth added a comment. In D85993#2220724 , @labath wrote: > Dwarf parser uses `TypeSystemClang::AddMethodToCXXRecordType` instead of this > function to create methods (which is why there are no assertions like this > when using dwarf). Maybe it would

[Lldb-commits] [PATCH] D87051: scan-build-py: fix multiprocessing error

ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land. From the docs: > `multiprocessing.freeze_support()` > Add support for when a program which uses multiprocessing has been frozen to > produce a Windows executable. (Has been tested with py2ex

[Lldb-commits] [lldb] 51128b6 - Fix de6caf871be79dc7549aebe4e4fb57d52f6ed202

Author: Walter Erquinigo Date: 2020-09-02T15:05:33-07:00 New Revision: 51128b670d4f757132e927c4f3dd78d257d37f70 URL: https://github.com/llvm/llvm-project/commit/51128b670d4f757132e927c4f3dd78d257d37f70 DIFF: https://github.com/llvm/llvm-project/commit/51128b670d4f757132e927c4f3dd78d257d37f70.di

[Lldb-commits] [lldb] de6caf8 - run in terminal

Author: Walter Erquinigo Date: 2020-09-02T14:38:00-07:00 New Revision: de6caf871be79dc7549aebe4e4fb57d52f6ed202 URL: https://github.com/llvm/llvm-project/commit/de6caf871be79dc7549aebe4e4fb57d52f6ed202 DIFF: https://github.com/llvm/llvm-project/commit/de6caf871be79dc7549aebe4e4fb57d52f6ed202.di

[Lldb-commits] [PATCH] D86667: [lldb/Target] Add custom interpreter option to `platform shell`

mib added a comment. Should be fixed with 0e86f390457a2b4dd1f2d1770db912963a36f240 . @max-kudr I'll keep an eye on the Windows bot to make sure it worked :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[Lldb-commits] [lldb] 0e86f39 - [lldb/test] Fix TestPlatform*.py Windows failures (NFC)

Author: Med Ismail Bennani Date: 2020-09-02T21:41:35+02:00 New Revision: 0e86f390457a2b4dd1f2d1770db912963a36f240 URL: https://github.com/llvm/llvm-project/commit/0e86f390457a2b4dd1f2d1770db912963a36f240 DIFF: https://github.com/llvm/llvm-project/commit/0e86f390457a2b4dd1f2d1770db912963a36f240.

[Lldb-commits] [PATCH] D86667: [lldb/Target] Add custom interpreter option to `platform shell`

max-kudr added inline comments. Comment at: lldb/test/API/commands/platform/basic/myshell.c:11 + +#ifdef WIN32 + char *cmd_opt = "/C"; mib wrote: > @max-kudr It seems I'm missing the leading `_` (correct me if I'm wrong but > IIUC the macro should be `_WIN32`),

[Lldb-commits] [PATCH] D84974: Enable Launching the Debugee in VSCode Terminal

wallace updated this revision to Diff 289542. wallace added a comment. Now this feature is fully functional. Besiding adding a test, I was able to debug LLDB from an integrated terminal in VSCode. Stdin and stdout work correctly. I'm attaching asynchronously to the inferior using the wait-for l

[Lldb-commits] [PATCH] D86667: [lldb/Target] Add custom interpreter option to `platform shell`

mib added inline comments. Comment at: lldb/test/API/commands/platform/basic/myshell.c:11 + +#ifdef WIN32 + char *cmd_opt = "/C"; @max-kudr It seems I'm missing the leading `_` (correct me if I'm wrong but IIUC the macro should be `_WIN32`), explaining the fail

[Lldb-commits] [PATCH] D87051: scan-build-py: fix multiprocessing error

lawrence_danna created this revision. lawrence_danna added reviewers: ldionne, chandlerc, jasonmolenda, JDevlieghere. Herald added subscribers: cfe-commits, dexonsmith, whisperity. Herald added a project: clang. lawrence_danna requested review of this revision. Recent versions of python3's multipr

[Lldb-commits] [PATCH] D86996: [lldb] Add -l/--language option to script command

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lldb/source/Commands/CommandObjectScript.cpp:37 +"default", +"The default scripting language.", +}, kastiglione wrote: > is the default's name avail

[Lldb-commits] [PATCH] D86996: [lldb] Add -l/--language option to script command

kastiglione added inline comments. Comment at: lldb/source/Commands/CommandObjectScript.cpp:37 +"default", +"The default scripting language.", +}, is the default's name available in a `define`? If maybe it'd be good to include it here? I don'

[Lldb-commits] [PATCH] D86667: [lldb/Target] Add custom interpreter option to `platform shell`

mib added a comment. @max-kudr Looking, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86667/new/ https://reviews.llvm.org/D86667 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://

[Lldb-commits] [PATCH] D86667: [lldb/Target] Add custom interpreter option to `platform shell`

max-kudr added a comment. Hi @mib, Windows buildbot is broken after this commit. Please fix or revert. Failed Tests (2): lldb-api :: commands/platform/basic/TestPlatformCommand.py lldb-api :: commands/platform/basic/TestPlatformPython.py http://lab.llvm.org:8011/builders/lldb-x64-windows-ni

[Lldb-commits] [PATCH] D86996: [lldb] Add -l/--language option to script command

JDevlieghere added a comment. In D86996#2252520 , @JDevlieghere wrote: > In D86996#2252246 , @labath wrote: > >> I agree that silly, but maybe the same fix should then be applied to the >> `expr` command (and any

[Lldb-commits] [PATCH] D86821: [lldb] Make the majority of the lit configuration values optional for the API tests

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lldb/test/API/lit.cfg.py:88-91 +def is_configured(attr): + """Return the configuration attribute if it exists and None otherwise. + + This allows us to check if the attribute exists b

[Lldb-commits] [PATCH] D86821: [lldb] Make the majority of the lit configuration values optional for the API tests

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lldb/test/API/lit.cfg.py:88-91 +def is_configured(attr): + """Return the configuration attribute if it exists and None otherwise. + + This allows us to check if the attribute exists b

[Lldb-commits] [PATCH] D86996: [lldb] Add -l/--language option to script command

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86996/new/ https://reviews.llvm.org/D86996 ___ lldb-commits mailing list lldb-com

[Lldb-commits] [PATCH] D86996: [lldb] Add -l/--language option to script command

JDevlieghere added a comment. In D86996#2252246 , @labath wrote: > I agree that silly, but maybe the same fix should then be applied to the > `expr` command (and any other command with similar behavior). Sure, we can use the same trick in other places th

[Lldb-commits] [PATCH] D86818: [lldb/Host] Add missing proc states

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc5aa63dd560b: [lldb/Host] Add missing proc states (authored by rupprecht). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[Lldb-commits] [lldb] c5aa63d - [lldb/Host] Add missing proc states

Author: Jordan Rupprecht Date: 2020-09-02T08:24:06-07:00 New Revision: c5aa63dd560b9cf5825c1e4da2a9ee53dbd772f3 URL: https://github.com/llvm/llvm-project/commit/c5aa63dd560b9cf5825c1e4da2a9ee53dbd772f3 DIFF: https://github.com/llvm/llvm-project/commit/c5aa63dd560b9cf5825c1e4da2a9ee53dbd772f3.di

[Lldb-commits] [PATCH] D82855: [LLDB] Send SVE vg register in custom expedited registerset

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/test/API/tools/lldb-server/TestGdbRemoteExpeditedRegisters.py:185 +if not self.isAArch64SVE(): +self.skipTest('SVE registers must be

[Lldb-commits] [PATCH] D86996: [lldb] Add -l/--language option to script command

labath added a comment. In D86996#2251508 , @JDevlieghere wrote: > because I thought it would be silly to require you to type `script --language > lua --` to launch the interactive Lua interpreter. For better or worse, this is how `expr` works: (lldb

[Lldb-commits] [PATCH] D86792: [lldb] Improve test failure reporting for expect()

labath added a comment. Awesome. In D86792#2252243 , @DavidSpickett wrote: > Combined two functions into one single run command > and check message function. > > With some odd kwargs, but I think it helps to be able > to put the expected lines on the end

[Lldb-commits] [PATCH] D86792: [lldb] Improve test failure reporting for expect()

DavidSpickett updated this revision to Diff 289448. DavidSpickett added a comment. Combined two functions into one single run command and check message function. With some odd kwargs, but I think it helps to be able to put the expected lines on the end. Repository: rG LLVM Github Monorepo CH

[Lldb-commits] [PATCH] D86962: [LLDB] Move NativeRegisterContextLinux/RegisterContextPOSIX*_arm to RegisterInfoAndSetInterface

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. This is great, thanks for doing this. Just a couple of minor comments inline. Comment at: lldb/source/Plugins/Process/FreeBSD/FreeBSDThread.cpp:167 case llvm::Triple::aa

[Lldb-commits] [PATCH] D85820: Use find_library for ncurses

gkistanova accepted this revision. gkistanova added a comment. This revision is now accepted and ready to land. Statically linked LLVM + LLD builds with this patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85820/new/ https://reviews.llvm.org/D85820

[Lldb-commits] [PATCH] D85820: Use find_library for ncurses

haampie updated this revision to Diff 288864. haampie added a comment. Herald added a subscriber: danielkiss. Another take on this isuse, incorporating @phosek's comment on making find_library not find shared libs when compiling with `LLVM_BUILD_STATIC=ON`, and making sure that `get_system_libna

[Lldb-commits] [PATCH] D85820: Use find_library for ncurses

This revision was automatically updated to reflect the committed changes. Closed by commit rG3c7bfbd6831b: [CMake] Use find_library for ncurses (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85820/new/ https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D85820: Use find_library for ncurses

phosek accepted this revision. phosek added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85820/new/ https://reviews.llvm.org/D85820 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[Lldb-commits] [PATCH] D86821: [lldb] Make the majority of the lit configuration values optional for the API tests

labath added inline comments. Comment at: lldb/test/API/lit.cfg.py:88-91 +def is_configured(attr): + """Return the configuration attribute if it exists and None otherwise. + + This allows us to check if the attribute exists before trying to access it.""" I don

[Lldb-commits] [PATCH] D86667: [lldb/Target] Add custom interpreter option to `platform shell`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaddb5148f58d: [lldb/Target] Add custom interpreter option to `platform shell` (authored by mib). Changed prior to commit: https://reviews.llvm.org

[Lldb-commits] [lldb] addb514 - [lldb/Target] Add custom interpreter option to `platform shell`

Author: Med Ismail Bennani Date: 2020-09-02T16:36:10+02:00 New Revision: addb5148f58d710fcaba04bb2afec8006ae8ac15 URL: https://github.com/llvm/llvm-project/commit/addb5148f58d710fcaba04bb2afec8006ae8ac15 DIFF: https://github.com/llvm/llvm-project/commit/addb5148f58d710fcaba04bb2afec8006ae8ac15.

[Lldb-commits] [PATCH] D86817: [lldb] Get rid of LLDB_LIB_DIR and LLDB_IMPLIB_DIR in dotest

labath added a comment. Yay Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86817/new/ https://reviews.llvm.org/D86817 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[Lldb-commits] [PATCH] D86667: [lldb/Target] Add custom interpreter option to `platform shell`

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Thanks, this looks good to me now. Comment at: lldb/test/API/commands/platform/basic/TestPlatformPython.py:16 mydir = TestBase.compute_mydir(__file__) +NO_DEBUG_INFO

[Lldb-commits] [PATCH] D86792: [lldb] Improve test failure reporting for expect()

labath added a comment. I like this. And a big thank-you for writing the tests. We don't usually bother to write self-tests for the test infrastructure, but we definitely should be doing that. The place is slightly weird, but I think it will do for now -- it's easy to move this around if we fin

[Lldb-commits] [PATCH] D86497: [lldb] Add reproducer verifier

davezarzycki added a comment. And just to be clear, the source directory in my setup is in the home directory. My cron job / "bot" build just builds in /tmp. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86497/new/ https://reviews.llvm.org/D86497

[Lldb-commits] [PATCH] D86497: [lldb] Add reproducer verifier

davezarzycki added a comment. Line 18 fails: `%lldb -x -b --replay %t.repro >> %t.txt 2>&1` error: reproducer replay failed: warning: home directory '/home/dave' not in VFS I tried rebuilding in my home directory as opposed to /tmp and the error went away. Did you try building outside of yo

[Lldb-commits] [PATCH] D82857: [LLDB] Add per-thread register infos shared pointer in gdb-remote

omjavaid added a comment. @labath ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82857/new/ https://reviews.llvm.org/D82857 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-co

[Lldb-commits] [PATCH] D82863: [LLDB] Add support to resize SVE registers at run-time

omjavaid added a comment. @labath ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82863/new/ https://reviews.llvm.org/D82863 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-co

[Lldb-commits] [PATCH] D86996: [lldb] Add -l/--language option to script command

JDevlieghere added a comment. In D86996#2251485 , @teemperor wrote: > So CommandObjectRaw does support arguments, but they way it works is that you > need to have a delimiter for the 'raw' part which is `--`. If you have that, > then you can just use inv

[Lldb-commits] [PATCH] D86996: [lldb] Add -l/--language option to script command

JDevlieghere updated this revision to Diff 289369. JDevlieghere marked 2 inline comments as done. JDevlieghere added a comment. Herald added a subscriber: dang. - Remove custom parsing and use the command options insofar possible. - Require `--` as a delimiter when language and code are specified

[Lldb-commits] [PATCH] D86996: [lldb] Add -l/--language option to script command

teemperor requested changes to this revision. teemperor added a comment. So CommandObjectRaw does support arguments, but they way it works is that you need to have a delimiter for the 'raw' part which is `--`. If you have that, then you can just use invoke the normal option parsing like Command

[Lldb-commits] [PATCH] D86962: [LLDB] Move NativeRegisterContextLinux/RegisterContextPOSIX*_arm to RegisterInfoAndSetInterface

omjavaid updated this revision to Diff 289362. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86962/new/ https://reviews.llvm.org/D86962 Files: lldb/source/Plugins/Process/FreeBSD/FreeBSDThread.cpp lldb/source/Plugins/Process/FreeBSD/RegisterContextPOSIXProcessMonitor_arm.cpp lldb/s

[Lldb-commits] [PATCH] D86962: [LLDB] Move NativeRegisterContextLinux/RegisterContextPOSIX*_arm to RegisterInfoAndSetInterface

omjavaid updated this revision to Diff 289361. omjavaid added a comment. Herald added a subscriber: emaste. Adding changes to FreeBSD/* missed earlier. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86962/new/ https://reviews.llvm.org/D86962 Files: lldb/source/Plugins/Process/FreeBSD/