max-kudr added inline comments.

================
Comment at: lldb/test/API/commands/platform/basic/myshell.c:11
+
+#ifdef WIN32
+  char *cmd_opt = "/C";
----------------
mib wrote:
> @max-kudr It seems I'm missing the leading `_` (correct me if I'm wrong but 
> IIUC the macro should be `_WIN32`), explaining the failure, I'll send a fix 
> now.
Yes, at least `_WIN32` is used in clang. Thank you!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86667/new/

https://reviews.llvm.org/D86667

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to