labath added a comment.

I like this. And a big thank-you for writing the tests. We don't usually bother 
to write self-tests for the test infrastructure, but we definitely should be 
doing that. The place is slightly weird, but I think it will do for now -- it's 
easy to move this around if we find a better place for it.



================
Comment at: lldb/test/API/assert_messages_test/TestAssertMessages.py:37-38
+        # Will stop at startstr fail
+        e = self.catch_assert_fail("help", startstr="dog", endstr="cat")
+        self.expect_assert_msg(e, [dedent("""\
+                Ran command:
----------------
These two calls always come in pairs, right? Might be nice to make this a 
single function which gets both the command to run, and the error message it is 
expected to fail with.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86792/new/

https://reviews.llvm.org/D86792

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to