[Lldb-commits] [PATCH] D86825: [lldb/Gui] zero-initialize children_stop_id

[Greg Clayton via Phabricator via lldb-commits]

clayborg added inline comments.


================
Comment at: lldb/source/Core/IOHandlerCursesGUI.cpp:1500-1513
   uint32_t children_stop_id;
   int row_idx;
   int x;
   int y;
   bool might_have_children;
   bool expanded;
   bool calculated_children;
----------------
Or we can inline the simple hard coded values into the definitions:
```
  uint32_t children_stop_id = 0;
  int row_idx = 0;
  int x = 1;
  int y = 1;
  bool might_have_children = false;
  bool expanded = false;
  bool calculated_children = false;
  std::vector<Row> children;


  Row(const ValueObjectSP &v, Row *p)
      : value(v, lldb::eDynamicDontRunTarget, true), parent(p),
        might_have_children(v ? v->MightHaveChildren() : false) {}
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86825/new/

https://reviews.llvm.org/D86825

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits