[Lldb-commits] [PATCH] D69422: [lldb][Docs] Add extra lldb aliases to gdb->lldb map

kastiglione created this revision. kastiglione added reviewers: aprantl, JDevlieghere. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Adds a few more aliases to the lldb translations. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D69422 Files: lldb/do

[Lldb-commits] [PATCH] D68961: Add support for DW_AT_export_symbols for anonymous structs

shafik updated this revision to Diff 226366. shafik added a comment. - Updated test to add dwarfdump test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68961/new/ https://reviews.llvm.org/D68961 Files: include/lldb/Symbol/ClangASTContext.h packages/Python/lldbsuite/test/python_api/

[Lldb-commits] [PATCH] D68961: Add support for DW_AT_export_symbols for anonymous structs

aprantl added a comment. aprantl added inline comments. Comment at: test/Shell/SymbolFile/DWARF/anon_class_w_and_wo_export_symbols.ll:1 +; This test verifies that we do the right thing with DIFlagExportSymbols which is the new +; behavioir and without the DIFlagExportSymbols whi

[Lldb-commits] [PATCH] D68961: Add support for DW_AT_export_symbols for anonymous structs

aprantl added a comment. I think in this case LLVM IR could be superior to x86 assembler since it is much shorter and easier to understand — even if we have to upgrade it from time to time. However, since this is explicitly testing for a DWARF feature, should we check the dwarfdump output that

[Lldb-commits] [PATCH] D68961: Add support for DW_AT_export_symbols for anonymous structs

shafik updated this revision to Diff 226349. shafik added a comment. -Add test to clarify what we depending wrt to debug info CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68961/new/ https://reviews.llvm.org/D68961 Files: include/lldb/Symbol/ClangASTContext.h packages/Python/lldbsu

[Lldb-commits] [PATCH] D69401: [CMake] Remove unused variable LLDB_TEST_CXX_COMPILER

This revision was automatically updated to reflect the committed changes. Closed by commit rGd52b36e354e9: [CMake] Remove unused variable LLDB_TEST_CXX_COMPILER (authored by JDevlieghere). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69401/new/ htt

[Lldb-commits] [lldb] 220cce1 - [CMake] Don't set LLDB_TEST_* in the top-level CMakeLists

Author: Jonas Devlieghere Date: 2019-10-24T14:47:07-07:00 New Revision: 220cce1e7274e1d4b015965fad82ccd79d03b305 URL: https://github.com/llvm/llvm-project/commit/220cce1e7274e1d4b015965fad82ccd79d03b305 DIFF: https://github.com/llvm/llvm-project/commit/220cce1e7274e1d4b015965fad82ccd79d03b305.d

[Lldb-commits] [lldb] d52b36e - [CMake] Remove unused variable LLDB_TEST_CXX_COMPILER

Author: Jonas Devlieghere Date: 2019-10-24T14:47:07-07:00 New Revision: d52b36e354e94f518985833231375365a7cc334b URL: https://github.com/llvm/llvm-project/commit/d52b36e354e94f518985833231375365a7cc334b DIFF: https://github.com/llvm/llvm-project/commit/d52b36e354e94f518985833231375365a7cc334b.d

[Lldb-commits] [PATCH] D69401: [CMake] Remove unused variable LLDB_TEST_CXX_COMPILER

xiaobai accepted this revision. xiaobai added a comment. In D69401#1720494 , @JDevlieghere wrote: > In D69401#1720432 , @xiaobai wrote: > > > I thought this option was so that you could specify which compilers to u

[Lldb-commits] [PATCH] D69401: [CMake] Remove unused variable LLDB_TEST_CXX_COMPILER

JDevlieghere added a comment. In D69401#1720432 , @xiaobai wrote: > I thought this option was so that you could specify which compilers to use to > build from a cache or command line? I don't think you just want to set > `LLDB_TEST_COMPILER` to `clang` s

[Lldb-commits] [PATCH] D69341: [zorg] Port LLDB cmake build factory to git

labath marked 7 inline comments as done. labath added a comment. Thanks for your help Jan. Unfortunately, it looks like I don't know how to commit this to zorg. Does anyone know what's the process for that? @gkistanova, could you advise? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69

[Lldb-commits] [PATCH] D69401: [CMake] Remove unused variable LLDB_TEST_CXX_COMPILER

xiaobai added a comment. I thought this option was so that you could specify which compilers to use to build from a cache or command line? I don't think you just want to set `LLDB_TEST_COMPILER` to `clang` since `clang++` is what is used to compile C++ code. Maybe I'm mis-remembering or mistake

[Lldb-commits] [PATCH] D69401: [CMake] Remove unused variable LLDB_TEST_CXX_COMPILER

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Overall, I think it would be better to just pass the c++ compiler instead of having dotest try to guess it from the c compiler name. But, it's easy to reintroduce this option once we get to th

[Lldb-commits] [PATCH] D69403: [Driver] Force llvm to install its handlers before lldb's

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Herald added a subscriber: dexonsmith. Not ideal, but better than adding a new llvm api, which doesn't even really do what we want. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69403

[Lldb-commits] [PATCH] D69366: [LLDB] [PECOFF] Use FindSectionByID to associate symbols to sections

mstorsjo updated this revision to Diff 226321. mstorsjo retitled this revision from "[LLDB] [PECOFF] Fix symbols to refer to the right section" to "[LLDB] [PECOFF] Use FindSectionByID to associate symbols to sections". mstorsjo edited the summary of this revision. mstorsjo added a comment. Using

[Lldb-commits] [PATCH] D69210: [Disassembler] Simplify MCInst predicates

vsk added a comment. I don't think it should be necessary to read the class in its entirety to understand when `m_opcode` is safe to use. However, as I'm not sure how the disassembler is called in to, I don't think it's a good idea to refactor the whole thing right away. Let's start with this

[Lldb-commits] [PATCH] D69403: [Driver] Force llvm to install its handlers before lldb's

vsk created this revision. vsk added reviewers: labath, JDevlieghere. Herald added a reviewer: jfb. Install llvm's signal handlers up front to prevent lldb's handlers from being ignored. This is (hopefully) a stopgap workaround. When lldb invokes an llvm API that installs signal handlers (e.g. ll

[Lldb-commits] [PATCH] D69401: [CMake] Remove unused variable LLDB_TEST_CXX_COMPILER

JDevlieghere added a comment. I did a bit of digging and there's more context in https://reviews.llvm.org/D39215. It sounds to me like the motivation for the two variables isn't relevant anymore, so I still think removing the CXX variant is desirable. Repository: rLLDB LLDB CHANGES SINCE L

[Lldb-commits] [PATCH] D69148: Disable exit-on-SIGPIPE in lldb

vsk added a comment. Reverted in d0bd3fc88be . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69148/new/ https://reviews.llvm.org/D69148 ___

[Lldb-commits] [lldb] d0bd3fc - Revert "Disable exit-on-SIGPIPE in lldb"

Author: Vedant Kumar Date: 2019-10-24T13:19:49-07:00 New Revision: d0bd3fc88be54c4e11f49cfa31e427700bb1e9af URL: https://github.com/llvm/llvm-project/commit/d0bd3fc88be54c4e11f49cfa31e427700bb1e9af DIFF: https://github.com/llvm/llvm-project/commit/d0bd3fc88be54c4e11f49cfa31e427700bb1e9af.diff

[Lldb-commits] [PATCH] D69401: [CMake] Remove unused variable LLDB_TEST_CXX_COMPILER

JDevlieghere created this revision. JDevlieghere added reviewers: LLDB, teemperor, labath, mgorny. Herald added a project: LLDB. CMake allows you to set a custom CXX compiler for the API test suite. However, this variable is never used, because dotest uses the same compiler to build C and CXX sour

[Lldb-commits] [PATCH] D69400: [lldb] [Host/netbsd] Set Arg0 for 'platform process list -v'

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. cool! thanks!! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69400/new/ https://reviews.llvm.org/D69400 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D69230: RFC: specialized Optional for T that can represent its own invalid state

dblaikie added a comment. In D69230#1720255 , @labath wrote: > In D69230#1720246 , @dblaikie wrote: > > > In D69230#1720048 , @labath wrote: > > > > > That said, I think you

[Lldb-commits] [PATCH] D69400: [lldb] [Host/netbsd] Set Arg0 for 'platform process list -v'

mgorny updated this revision to Diff 226309. mgorny retitled this revision from "[lldb] [Host/netbsd] Include argv[0] in process_info.GetArguments()" to "[lldb] [Host/netbsd] Set Arg0 for 'platform process list -v'". mgorny edited the summary of this revision. mgorny added a comment. Ok, how doe

[Lldb-commits] [PATCH] D69400: [lldb] [Host/netbsd] Include argv[0] in process_info.GetArguments()

mgorny added a comment. Hmm, I think I see how it's supposed to work. I'm going to update the patch after I test it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69400/new/ https://reviews.llvm.org/D69400 ___ lldb-commits mailing list lld

[Lldb-commits] [PATCH] D69230: RFC: specialized Optional for T that can represent its own invalid state

labath added a comment. In D69230#1720246 , @dblaikie wrote: > In D69230#1720048 , @labath wrote: > > > That said, I think you have convinced me that having different optional > > representations for a single type

[Lldb-commits] [PATCH] D69230: RFC: specialized Optional for T that can represent its own invalid state

dblaikie added a comment. In D69230#1720048 , @labath wrote: > In D69230#1718191 , @lawrence_danna > wrote: > > > Seems like there's a consensus that if we have something like this it > > should be called `DenseOp

[Lldb-commits] [PATCH] D69320: [lldb] [Python] Do not attempt to flush() a read-only fd

This revision was automatically updated to reflect the committed changes. Closed by commit rG267cc3292ec4: [lldb] [Python] Do not attempt to flush() a read-only fd (authored by mgorny, committed by labath). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[Lldb-commits] [PATCH] D69400: [lldb] [Host/netbsd] Include argv[0] in process_info.GetArguments()

wallace added a comment. Supposedly Arguments shouldn't contain Arg0 (https://reviews.llvm.org/source/llvm-github/browse/master/lldb/include/lldb/Utility/ProcessInfo.h$96) I think you just need to change the dump method that prints to platform process list. I don't know if NetBSD is doing somet

[Lldb-commits] [lldb] 267cc32 - [lldb] [Python] Do not attempt to flush() a read-only fd

Author: Michal Gorny Date: 2019-10-24T11:29:00-07:00 New Revision: 267cc3292ec4f6a7ea062b3551d20ea4692b6b78 URL: https://github.com/llvm/llvm-project/commit/267cc3292ec4f6a7ea062b3551d20ea4692b6b78 DIFF: https://github.com/llvm/llvm-project/commit/267cc3292ec4f6a7ea062b3551d20ea4692b6b78.diff

[Lldb-commits] [PATCH] D69394: [CMake] Move specific logic into API, shell and unittest sub-directories.

This revision was automatically updated to reflect the committed changes. Closed by commit rG0c798aa4483e: [CMake] Split logic across test suite subdirectories (NFC) (authored by JDevlieghere). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69394/new/

[Lldb-commits] [lldb] 0c798aa - [CMake] Split logic across test suite subdirectories (NFC)

Author: Jonas Devlieghere Date: 2019-10-24T10:58:22-07:00 New Revision: 0c798aa4483e103e67231c279aed00cd16154e33 URL: https://github.com/llvm/llvm-project/commit/0c798aa4483e103e67231c279aed00cd16154e33 DIFF: https://github.com/llvm/llvm-project/commit/0c798aa4483e103e67231c279aed00cd16154e33.d

[Lldb-commits] [PATCH] D69400: [lldb] [Host/netbsd] Include argv[0] in process_info.GetArguments()

mgorny created this revision. mgorny added reviewers: krytarowski, labath, wallace. Include argv[0] in GetArguments(), not only in GetExecutableFile(). This fixes 'process list -v' to report the executable name, and therefore to pass TestProcessList. https://reviews.llvm.org/D69400 Files: lld

[Lldb-commits] [PATCH] D69394: [CMake] Move specific logic into API, shell and unittest sub-directories.

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69394/new/ https://reviews.llvm.org/D69394 _

[Lldb-commits] [PATCH] D69366: [LLDB] [PECOFF] Fix symbols to refer to the right section

amccarth added inline comments. Comment at: lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:691 + // so we should use section index "symbol.sect - 1 + 1". + Address symbol_addr(sect_list->GetSectionAtIndex(symbol.sect),

[Lldb-commits] [PATCH] D69394: [CMake] Move specific logic into API, shell and unittest sub-directories.

JDevlieghere created this revision. JDevlieghere added reviewers: LLDB, labath, davide, teemperor. Herald added a subscriber: mgorny. Herald added a project: LLDB. The top-level CMake file in the test directory can be simplified by moving relevant configuration options into the subdirectories. Th

[Lldb-commits] [PATCH] D69230: RFC: specialized Optional for T that can represent its own invalid state

labath added a comment. In D69230#1718191 , @lawrence_danna wrote: > Seems like there's a consensus that if we have something like this it should > be called `DenseOptional`, and changes to `Optional` should only make it more > like `std::optional` I

[Lldb-commits] [PATCH] D67793: new api class: SBFile

labath added inline comments. Comment at: lldb/trunk/source/Host/common/File.cpp:74 + .Case("r", File::eOpenOptionRead) + .Case("w", File::eOpenOptionWrite) + .Case("a", File::eOpenOptionWrite | File::eOpenOptionAppend | mgorny wrote: > Shouldn't t

[Lldb-commits] [PATCH] D66795: [Mips] Use appropriate private label prefix based on Mips ABI

This revision was automatically updated to reflect the committed changes. Closed by commit rG4b63ca1379a8: [Mips] Use appropriate private label prefix based on Mips ABI (authored by mbrkusanin). Changed prior to commit: https://reviews.llvm.org/D66795?vs=224603&id=226112#toc Repository: rG L

[Lldb-commits] [PATCH] D62732: [RISCV] Add SystemV ABI

simoncook updated this revision to Diff 225998. simoncook retitled this revision from "[WIP][RISCV] Initial port of LLDB for RISC-V" to "[RISCV] Add SystemV ABI". simoncook edited the summary of this revision. simoncook added a comment. Herald added subscribers: pzheng, s.egerton, lenary, arichard

[Lldb-commits] [PATCH] D69366: [LLDB] [PECOFF] Fix symbols to refer to the right section

labath added inline comments. Comment at: lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:691 + // so we should use section index "symbol.sect - 1 + 1". + Address symbol_addr(sect_list->GetSectionAtIndex(symbol.sect),

[Lldb-commits] [PATCH] D69341: [zorg] Port LLDB cmake build factory to git

jankratochvil accepted this revision. jankratochvil added inline comments. This revision is now accepted and ready to land. Comment at: zorg/buildbot/builders/LLDBBuilder.py:71 +is_legacy_mode=False, +depends_on_projects=["llvm", "clang", "lldb", "lld"])

[Lldb-commits] [PATCH] D69371: [ARM64] Cleanup and speedup NativeRegisterContextLinux_arm64

labath added a comment. The idea seems nice, however I am wondering, if it is not going a bit too far. In not sure of the exact situation on arm64, but in general, there are registers which only accept some bit patterns. What exactly does ptrace do in this situation? Postponing the write until

[Lldb-commits] [PATCH] D62931: [lldb-server] Add setting to force 'g' packet use

labath added a comment. I'm sorry, this dropped off my radar. The code looks fine, but it could use some more tests. For instance, one test when you set the setting value to the non-default , and then check that lldb does _not_ use the `g` packet . Comment at: lldb/source/Pl

[Lldb-commits] [PATCH] D69341: [zorg] Port LLDB cmake build factory to git

labath marked 5 inline comments as done. labath added inline comments. Comment at: zorg/buildbot/builders/LLDBBuilder.py:71 +is_legacy_mode=False, +depends_on_projects=["llvm", "clang", "lldb", "lld"]) sivachandra wrote: > jankratochvil

[Lldb-commits] [PATCH] D69341: [zorg] Port LLDB cmake build factory to git

sivachandra added inline comments. Comment at: zorg/buildbot/builders/LLDBBuilder.py:71 +is_legacy_mode=False, +depends_on_projects=["llvm", "clang", "lldb", "lld"]) jankratochvil wrote: > sivachandra wrote: > > labath wrote: > > > sivac

[Lldb-commits] [PATCH] D62931: [lldb-server] Add setting to force 'g' packet use

guiandrade added a comment. Hey @labath, Have you had a chance to take a look at the last revision of this? Tks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62931/new/ https://reviews.llvm.org/D62931 _

[Lldb-commits] [PATCH] D69341: [zorg] Port LLDB cmake build factory to git

jankratochvil added inline comments. Comment at: zorg/buildbot/builders/LLDBBuilder.py:71 +is_legacy_mode=False, +depends_on_projects=["llvm", "clang", "lldb", "lld"]) sivachandra wrote: > labath wrote: > > sivachandra wrote: > > > sivac

[Lldb-commits] [PATCH] D69371: [ARM64] Cleanup and speedup NativeRegisterContextLinux_arm64

omjavaid created this revision. omjavaid added reviewers: labath, clayborg. Herald added a subscriber: kristof.beyls. This patch simplifies register accesses in NativeRegisterContextLinux_arm64 and also adds some bare minimum caching to avoid multiple calls to ptrace during a stop. Linux ptrace

[Lldb-commits] [PATCH] D69366: [LLDB] [PECOFF] Fix symbols to refer to the right section

mstorsjo updated this revision to Diff 226216. mstorsjo added a comment. Updated the testcase to check for symbols in more than one section. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69366/new/ https://reviews.llvm.org/D69366 Files: lldb/source/Plugins/ObjectFile/PECOFF/ObjectFil

[Lldb-commits] [PATCH] D69366: [LLDB] [PECOFF] Fix symbols to refer to the right section

mstorsjo created this revision. mstorsjo added reviewers: labath, amccarth. Herald added a subscriber: JDevlieghere. Herald added a project: LLDB. The virtual container/header section causes the section list to be offset by one. Previously, symbols in the first section were given addresses in the