vsk added a comment.

I don't think it should be necessary to read the class in its entirety to 
understand when `m_opcode` is safe to use. However, as I'm not sure how the 
disassembler is called in to, I don't think it's a good idea to refactor the 
whole thing right away.

Let's start with this simple change to drop some redundant code, and maybe 
revisit things later?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69210/new/

https://reviews.llvm.org/D69210



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to