xiaobai accepted this revision. xiaobai added a comment. In D69401#1720494 <https://reviews.llvm.org/D69401#1720494>, @JDevlieghere wrote:
> In D69401#1720432 <https://reviews.llvm.org/D69401#1720432>, @xiaobai wrote: > > > I thought this option was so that you could specify which compilers to use > > to build from a cache or command line? I don't think you just want to set > > `LLDB_TEST_COMPILER` to `clang` since `clang++` is what is used to compile > > C++ code. Maybe I'm mis-remembering or mistaken here. > > > Yes, that's indeed the point. However, dotest expects you to set the C > compiler and then infers the C++ compiler from it, which for clang is just > appending `++` at the end. I'm sure it must do something sensible for `gcc` > as well, as I believe people are running the test suite with that compiler. Right, I see. I'm not sure I like the inference in dotest, and I assume cl is left untouched here (if it's even possible to use cl as the compiler on windows for tests). I do like the simplification to the build though so ship it! Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69401/new/ https://reviews.llvm.org/D69401 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
