[Lldb-commits] [PATCH] D68622: IOHandler: fall back on File::Read if a FILE* isn't available.

lawrence_danna updated this revision to Diff 223983. lawrence_danna added a comment. rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68622/new/ https://reviews.llvm.org/D68622 Files: lldb/include/lldb/Core/IOHandler.h lldb/packages/Pytho

[Lldb-commits] [PATCH] D68444: remove a smattering of isolated, unnecessary uses of FILE*

lawrence_danna updated this revision to Diff 223981. lawrence_danna added a comment. rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68444/new/ https://reviews.llvm.org/D68444 Files: lldb/source/API/SBDebugger.cpp lldb/source/Core/IOHand

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna updated this revision to Diff 223978. lawrence_danna added a comment. rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68188/new/ https://reviews.llvm.org/D68188 Files: lldb/include/lldb/API/SBFile.h lldb/packages/Python/ll

[Lldb-commits] [PATCH] D68434: SBFile support in SBCommandReturnObject

lawrence_danna updated this revision to Diff 223980. lawrence_danna added a comment. rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68434/new/ https://reviews.llvm.org/D68434 Files: lldb/include/lldb/API/SBCommandReturnObject.h lldb/inc

[Lldb-commits] [PATCH] D68546: remove FILE* usage from ReportEventState() and HandleProcessEvent()

lawrence_danna updated this revision to Diff 223982. lawrence_danna added a comment. rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68546/new/ https://reviews.llvm.org/D68546 Files: lldb/include/lldb/API/SBDebugger.h lldb/include/lldb/A

[Lldb-commits] [PATCH] D68677: protect libedit and LLDB gui from receiving null FILE* streams

lawrence_danna updated this revision to Diff 223984. lawrence_danna added a comment. rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68677/new/ https://reviews.llvm.org/D68677 Files: lldb/source/Commands/CommandObjectGUI.cpp lldb/source/

[Lldb-commits] [PATCH] D68433: SBFile: add a bunch of tests that should eventually work.

lawrence_danna updated this revision to Diff 223979. lawrence_danna added a comment. rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68433/new/ https://reviews.llvm.org/D68433 Files: lldb/packages/Python/lldbsuite/test/python_api/file_hand

[Lldb-commits] [PATCH] D68674: Remove the is_mangled flag from Mangled and Symbol

JDevlieghere accepted this revision. JDevlieghere added a comment. Neat! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68674/new/ https://reviews.llvm.org/D68674 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.o

[Lldb-commits] [PATCH] D68679: [CMake] Add a cache for iOS.

davide created this revision. davide added reviewers: friss, jasonmolenda. Herald added a subscriber: mgorny. Herald added a project: LLDB. rdar://problem/55916729 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D68679 Files: lldb/cmake/caches/Apple-lldb-iOS.cmake Index: lld

[Lldb-commits] [PATCH] D68678: WIP: Speed up accelerator table lookups

aprantl created this revision. aprantl added reviewers: JDevlieghere, friss, jasonmolenda, jingham. Herald added a subscriber: arphaman. When debugging a large program like clang and doing "frame variable *this", the ValueObject pretty printer is doing hundreds of scoped FindTypes lookups. The o

[Lldb-commits] [PATCH] D68677: protect libedit and LLDB gui from receiving null FILE* streams

lawrence_danna created this revision. lawrence_danna added reviewers: JDevlieghere, jasonmolenda, labath. Herald added a project: LLDB. lawrence_danna added a parent revision: D68188: allow arbitrary python streams to be converted to SBFile. We now have valid files that will return NULL from GetS

[Lldb-commits] [PATCH] D68674: Remove the is_mangled flag from Mangled and Symbol

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68674/new/ https://reviews.llvm.org/D68674 ___ lldb-commits mailing list lldb-commits

[Lldb-commits] [PATCH] D68674: Remove the is_mangled flag from Mangled and Symbol

aprantl updated this revision to Diff 223965. aprantl added a comment. Updated unit test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68674/new/ https://reviews.llvm.org/D68674 Files: lldb/include/lldb/Core/Mangled.h lldb/include/lldb/Symbol/Function.h lldb/include/lldb/Symbol/

[Lldb-commits] [PATCH] D68674: Remove the is_mangled flag from Mangled and Symbol

aprantl created this revision. aprantl added reviewers: JDevlieghere, jasonmolenda, labath. Herald added subscribers: MaskRay, arichardson, emaste. Herald added a reviewer: espindola. Testing whether a name is mangled or not is extremely cheap and can be done by looking at the first two character

[Lldb-commits] [PATCH] D68671: Add the ability to pass extra args to a Python breakpoint command function

shafik added inline comments. Comment at: lldb/include/lldb/API/SBBreakpointLocation.h:59 + void SetScriptCallbackFunction(const char *callback_function_name, + SBStructuredData &extra_args); + Could this be a `const &`

[Lldb-commits] [PATCH] D68533: Explicitly set entry point arch when it's thumb [Second Try]

This revision was automatically updated to reflect the committed changes. Closed by commit rGad6690afa3e6: Explicitly set entry point arch when it's thumb [Second Try] (authored by aadsm). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68533/new/ htt

[Lldb-commits] [lldb] r374132 - Explicitly set entry point arch when it's thumb [Second Try]

Author: aadsm Date: Tue Oct 8 16:44:49 2019 New Revision: 374132 URL: http://llvm.org/viewvc/llvm-project?rev=374132&view=rev Log: Explicitly set entry point arch when it's thumb [Second Try] Summary: This is a redo of D68069 because I reverted it due to some concerns that were now addressed al

[Lldb-commits] [PATCH] D68622: IOHandler: fall back on File::Read if a FILE* isn't available.

lawrence_danna updated this revision to Diff 223958. lawrence_danna added a comment. factor out string splitting stuff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68622/new/ https://reviews.llvm.org/D68622 Files: lldb/include/lldb/Core/IOHandl

[Lldb-commits] [PATCH] D68671: Add the ability to pass extra args to a Python breakpoint command function

jingham created this revision. jingham added reviewers: JDevlieghere, clayborg. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. For example, it is pretty easy to write a breakpoint command that implements "stop when my caller is Foo", and it is pretty easy to write a breakp

[Lldb-commits] [PATCH] D67994: Modify lldb-test to print out ASTs from symbol file

shafik added a comment. In D67994#1697981 , @labath wrote: > In D67994#1695172 , @shafik wrote: > > > In D67994#1692645 , @labath wrote: > > > > > Maybe this is my fault sinc

[Lldb-commits] [PATCH] D68655: Trust the arange accelerator tables in dSYMs

aprantl added a comment. I had to revert this. Apparently for very small / gapless programs, clang emits single-value DW_AT_low_pc/high_pc in the compile unit, and dsymutil does not rewrite that into DW_AT_ranges. Would be a nice speedup though. Repository: rG LLVM Github Monorepo CHANGES S

[Lldb-commits] [PATCH] D68614: [LLDB] Remove standalone build dep on llvm-strip

gmittert added a comment. Thanks! Can someone commit this for me? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68614/new/ https://reviews.llvm.org/D68614 ___ lldb-commits mailing list lldb-commits@lists.llvm.org h

[Lldb-commits] [PATCH] D68613: [CMake] Fix building without python on Windows

xiaobai closed this revision. xiaobai added a comment. rL374100 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68613/new/ https://reviews.llvm.org/D68613 ___ lldb-com

[Lldb-commits] [PATCH] D68614: [LLDB] Remove standalone build dep on llvm-strip

xiaobai accepted this revision. xiaobai added a comment. This revision is now accepted and ready to land. LGTM Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68614/new/ https://reviews.llvm.org/D68614 ___ lldb-commi

[Lldb-commits] [lldb] r374121 - Revert Trust the arange accelerator tables in dSYMs

Author: adrian Date: Tue Oct 8 14:34:22 2019 New Revision: 374121 URL: http://llvm.org/viewvc/llvm-project?rev=374121&view=rev Log: Revert Trust the arange accelerator tables in dSYMs This reverts r374117 (git commit 6399db2f6fd64fa250093368be40eb5ae3af513b) while inspecting bot breakage. Modif

[Lldb-commits] [PATCH] D68134: [LLDB] Use the llvm microsoft demangler instead of the windows dbghelp api

amccarth accepted this revision. amccarth added a comment. LGTM after one question. Comment at: lldb/lit/SymbolFile/PDB/udt-layout.test:1 REQUIRES: system-windows, lld RUN: %build --compiler=clang-cl --output=%t.exe %S/Inputs/UdtLayoutTest.cpp Is `system-wind

[Lldb-commits] [PATCH] D68258: [Windows] Introduce a switch for the `lldb-server` mode on Windows

amccarth accepted this revision. amccarth added a comment. Given Pavel's comment, this LGTM. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68258/new/ https://reviews.llvm.org/D68258 ___ lldb-commits mailing list ll

[Lldb-commits] [PATCH] D68655: Trust the arange accelerator tables in dSYMs

This revision was automatically updated to reflect the committed changes. Closed by commit rG6399db2f6fd6: Trust the arange accelerator tables in dSYMs (authored by aprantl). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[Lldb-commits] [PATCH] D61886: Support member functions construction and lookup in PdbAstBuilder

amccarth added a comment. Herald added a subscriber: JDevlieghere. Is this still an active review or has this been abandoned? Comment at: lldb/source/Plugins/SymbolFile/NativePDB/PdbAstBuilder.cpp:1047 +function_decl = m_clang.CreateFunctionDeclaration( parent, proc_

[Lldb-commits] [PATCH] D68655: Trust the arange accelerator tables in dSYMs

aprantl added a comment. In D68655#1700314 , @jasonmolenda wrote: > Nice fix. The real cost of computing the aranges manually is expanding all > the line tables and calling GetContiguousFileAddressRanges on them. I wonder > if avoiding the full lineta

[Lldb-commits] [lldb] r374117 - Trust the arange accelerator tables in dSYMs

Author: adrian Date: Tue Oct 8 14:14:36 2019 New Revision: 374117 URL: http://llvm.org/viewvc/llvm-project?rev=374117&view=rev Log: Trust the arange accelerator tables in dSYMs When ingesting aranges from a dSYM it makes sense to always trust the contents of the accelerator table since it always

[Lldb-commits] [PATCH] D68541: Implement 'up' and 'down' shortcuts in lldb gui

clayborg added a comment. In D68541#1700398 , @llunak wrote: > In D68541#1700359 , @clayborg wrote: > > > It would be fine to remove the 'd' shortcut for detach and resume if we > > need to by moving this functiona

[Lldb-commits] [PATCH] D68270: DWARFDebugLoc: Add a function to get the address range of an entry

clayborg added a comment. In D68270#1700108 , @probinson wrote: > Do we care whether llvm-dwarfdump's output bears any similarities to the > output from GNU readelf or objdump? There has been a push lately to get the > LLVM "binutils" to behave more lik

[Lldb-commits] [PATCH] D68541: Implement 'up' and 'down' shortcuts in lldb gui

llunak added a comment. In D68541#1700359 , @clayborg wrote: > It would be fine to remove the 'd' shortcut for detach and resume if we need > to by moving this functionality up into the menu bar. Right now the Process > menu has "Detach" only, so it migh

[Lldb-commits] [PATCH] D68661: StopInfo/Mach: Delete PPC support

This revision was automatically updated to reflect the committed changes. vsk marked an inline comment as done. Closed by commit rG4805c817c3fa: StopInfo/Mach: Delete PPC support (authored by vsk). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D68661?vs=223924&

[Lldb-commits] [lldb] r374114 - StopInfo/Mach: Delete PPC support

Author: vedantk Date: Tue Oct 8 13:47:44 2019 New Revision: 374114 URL: http://llvm.org/viewvc/llvm-project?rev=374114&view=rev Log: StopInfo/Mach: Delete PPC support LLDB appears to have at least partial support for PPC, but PPC on Mach isn't a thing AFAIK. Differential Revision: https://revie

[Lldb-commits] [PATCH] D68549: make ConstString allocate memory in non-tiny chunks

clayborg accepted this revision. clayborg added a comment. Nice! If we run into any issues we can make this a global debugger setting. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68549/new/ https://reviews.llvm.org/D68549 __

[Lldb-commits] [PATCH] D68541: Implement 'up' and 'down' shortcuts in lldb gui

clayborg added a comment. It would be fine to remove the 'd' shortcut for detach and resume if we need to by moving this functionality up into the menu bar. Right now the Process menu has "Detach" only, so it might be good to first change the "Process" menu to have "Detach" or "Detach suspended

[Lldb-commits] [PATCH] D68662: Redo D68354 - [platform process list] add a flag for showing the processes of all users

wallace created this revision. wallace added reviewers: labath, clayborg, aadsm. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. I don't know how the previous version worked on my machine. Maybe something changed in the meantime regarding the lldb's communication layer. An

[Lldb-commits] [PATCH] D68354: [platform process list] add a flag for showing the processes of all users

wallace closed this revision. wallace added a comment. this was reverted Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68354/new/ https://reviews.llvm.org/D68354 ___ lldb-commits mailing list lldb-comm

[Lldb-commits] [PATCH] D68655: Trust the arange accelerator tables in dSYMs

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Nice fix. The real cost of computing the aranges manually is expanding all the line tables and calling GetContiguousFileAddressRanges on them. I wonder if avoiding the full linet

[Lldb-commits] [PATCH] D68661: StopInfo/Mach: Delete PPC support

jingham added a comment. Yes, I don't think we need to support this anymore. Comment at: lldb/source/Plugins/Process/Utility/StopInfoMachException.cpp:387 case 1: // EXC_BAD_ACCESS break; Might as well remove this break too. CHANGES SINCE LAST ACTIO

[Lldb-commits] [PATCH] D68661: StopInfo/Mach: Delete PPC support

vsk created this revision. vsk added reviewers: jingham, jasonmolenda, JDevlieghere. LLDB appears to have at least partial support for PPC, but PPC on Mach isn't a thing AFAIK. https://reviews.llvm.org/D68661 Files: lldb/source/Plugins/Process/Utility/StopInfoMachException.cpp Index: lldb/s

[Lldb-commits] [lldb] r374108 - Add test coverage to printing of enums and fix display of unsigned values

Author: friss Date: Tue Oct 8 12:52:01 2019 New Revision: 374108 URL: http://llvm.org/viewvc/llvm-project?rev=374108&view=rev Log: Add test coverage to printing of enums and fix display of unsigned values TestCPP11EnumTypes.py should have covered all our bases when it comes to typed enums, but i

[Lldb-commits] [PATCH] D68546: remove FILE* usage from ReportEventState() and HandleProcessEvent()

lawrence_danna added a comment. So what's the conclusion here? Should `HandleProcessEvent` get a SBStream variant as well? I say "as well", because the `FileSP` variant is required in order to remove the python binding to the `FILE*` variant, and once we have the `FileSP` it seems like

[Lldb-commits] [lldb] r374106 - StopInfo/Mach: Use early-exits, reflow messy comments, NFCI

Author: vedantk Date: Tue Oct 8 12:40:13 2019 New Revision: 374106 URL: http://llvm.org/viewvc/llvm-project?rev=374106&view=rev Log: StopInfo/Mach: Use early-exits, reflow messy comments, NFCI Modified: lldb/trunk/include/lldb/Target/StopInfo.h lldb/trunk/source/Plugins/Process/Utility/S

[Lldb-commits] [PATCH] D68546: remove FILE* usage from ReportEventState() and HandleProcessEvent()

lawrence_danna added a comment. In D68546#1699397 , @labath wrote: > Yeah, the %extends are somewhat ugly, but I also find the FileSP overloads in > the "public" sections of the SB classes unnerving too, because they are not > really public -- no user ca

[Lldb-commits] [PATCH] D68541: Implement 'up' and 'down' shortcuts in lldb gui

llunak added a comment. In D68541#1698127 , @JDevlieghere wrote: > Would it be possible to add a test for this? Maybe you can extend > `TestGuiBasic.py`. I can, although to me it looks like a new test would be better. But first of all I wanted some fe

[Lldb-commits] [PATCH] D68549: make ConstString allocate memory in non-tiny chunks

llunak added a comment. In D68549#1700019 , @aprantl wrote: > This makes sense to me. We may need to make this configurable for low-memory > hosts at some point. Note that the memory usage shouldn't be as bad as it might look. As long as the BumpPtrAll

[Lldb-commits] [PATCH] D68641: [LLDB] Fix for synthetic children memory leak

cameron314 updated this revision to Diff 223919. cameron314 added a comment. Added comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68641/new/ https://reviews.llvm.org/D68641 Files: source/Plugins/Language/CPlusPlus/LibCxxBitset.cpp source/Plugins/Language/CPlusPlus/LibCxxOp

[Lldb-commits] [lldb] r374104 - [Reproducer] Don't isntrument methods that get called from the signal handler.

Author: jdevlieghere Date: Tue Oct 8 12:17:42 2019 New Revision: 374104 URL: http://llvm.org/viewvc/llvm-project?rev=374104&view=rev Log: [Reproducer] Don't isntrument methods that get called from the signal handler. LLDB's signal handlers call SBDebugger methods, which themselves try to be real

[Lldb-commits] [PATCH] D68658: LLDB: Use LLVM's type for minidump ExceptionStream

JosephTremoulet created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. JosephTremoulet added a parent revision: D68657: Update MinidumpYAML to use minidump::Exception for exception stream. JosephTremoulet added reviewers: labath, clayborg. The types defined

[Lldb-commits] [PATCH] D68641: [LLDB] Fix for synthetic children memory leak

cameron314 added a comment. Right, I'll add comments on the pointer declarations. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68641/new/ https://reviews.llvm.org/D68641 ___ lldb-commits mailing list lldb-commits@

[Lldb-commits] [lldb] r374100 - [CMake] Fix building without python on Windows

Author: xiaobai Date: Tue Oct 8 11:38:46 2019 New Revision: 374100 URL: http://llvm.org/viewvc/llvm-project?rev=374100&view=rev Log: [CMake] Fix building without python on Windows Summary: find_python_libs_windows might set LLDB_DISABLE_PYTHON to ON. Unfortunately we do not re-check this variabl

[Lldb-commits] [PATCH] D68655: Trust the arange accelerator tables in dSYMs

aprantl created this revision. aprantl added reviewers: jasonmolenda, jingham, friss. Herald added a subscriber: JDevlieghere. Herald added a reviewer: JDevlieghere. When ingesting aranges from a dSYM it makes sense to always trust the contents of the accelerator table since it always comes from

[Lldb-commits] [PATCH] D68270: DWARFDebugLoc: Add a function to get the address range of an entry

probinson added a comment. Do we care whether llvm-dwarfdump's output bears any similarities to the output from GNU readelf or objdump? There has been a push lately to get the LLVM "binutils" to behave more like GNU's, although AFAIK it hasn't gotten to the DWARF dumping part. Repository:

[Lldb-commits] [PATCH] D68641: [LLDB] Fix for synthetic children memory leak

shafik accepted this revision. shafik added a comment. LGTM Comment at: source/Plugins/Language/CPlusPlus/LibCxxBitset.cpp:34 std::vector m_elements; - ValueObjectSP m_first; + ValueObject* m_first = nullptr; CompilerType m_bool_type; I feel like each o

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna updated this revision to Diff 223902. lawrence_danna added a comment. rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68188/new/ https://reviews.llvm.org/D68188 Files: lldb/include/lldb/API/SBFile.h lldb/packages/Python/ll

[Lldb-commits] [PATCH] D68614: [LLDB] Remove standalone build dep on llvm-strip

gmittert updated this revision to Diff 223903. gmittert added a comment. Alright, rebased and added a comment to it Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68614/new/ https://reviews.llvm.org/D68614 Files: lit/CMakeLists.txt Index: lit/CMakeLists.txt

[Lldb-commits] [lldb] r374096 - Reflow/fix doxygen comments.

Author: adrian Date: Tue Oct 8 11:04:49 2019 New Revision: 374096 URL: http://llvm.org/viewvc/llvm-project?rev=374096&view=rev Log: Reflow/fix doxygen comments. Modified: lldb/trunk/include/lldb/Symbol/ObjectFile.h Modified: lldb/trunk/include/lldb/Symbol/ObjectFile.h URL: http://llvm.org/

Re: [Lldb-commits] [PATCH] D68597: Replace static const StringRef with StringRef (NFC)

We actually call the libc++abi guard functions even for const static StringRefs, so that patch actually saves us a lot. > On Oct 7, 2019, at 11:43 PM, Adrian Prantl via Phabricator via lldb-commits > wrote: > > aprantl created this revision. > aprantl added a reviewer: JDevlieghere. > > I jus

[Lldb-commits] [PATCH] D68547: exception handling in PythonDataObjects.

lawrence_danna updated this revision to Diff 223900. lawrence_danna marked 2 inline comments as done. lawrence_danna added a comment. style fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68547/new/ https://reviews.llvm.org/D68547 Files: lld

[Lldb-commits] [PATCH] D68547: exception handling in PythonDataObjects.

This revision was automatically updated to reflect the committed changes. Closed by commit rG085328ba: exception handling in PythonDataObjects. (authored by lawrence_danna). Changed prior to commit: https://reviews.llvm.org/D68547?vs=223900&id=223901#toc Repository: rG LLVM Github Monore

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna added a comment. @labath anything else for this one? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68188/new/ https://reviews.llvm.org/D68188 ___ lldb-commits mailing list lldb-commits@l

[Lldb-commits] [lldb] r374095 - Fix sign extension handling in DumpEnumValue

Author: friss Date: Tue Oct 8 10:59:02 2019 New Revision: 374095 URL: http://llvm.org/viewvc/llvm-project?rev=374095&view=rev Log: Fix sign extension handling in DumpEnumValue When an enumerator has an unsigned type and its high bit set, the code introduced in r374067 would fail to match it due

[Lldb-commits] [lldb] r374094 - exception handling in PythonDataObjects.

Author: lawrence_danna Date: Tue Oct 8 10:56:18 2019 New Revision: 374094 URL: http://llvm.org/viewvc/llvm-project?rev=374094&view=rev Log: exception handling in PythonDataObjects. Summary: Python APIs nearly all can return an exception. They do this by returning NULL, or -1, or some such valu

[Lldb-commits] [PATCH] D68289: [lldb-server/android] Show more processes by relaxing some checks

wallace added a comment. thanks, @labath ! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68289/new/ https://reviews.llvm.org/D68289 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-

[Lldb-commits] [PATCH] D68312: [gdb-remote] process properly effective uid

wallace closed this revision. wallace added a comment. already committed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68312/new/ https://reviews.llvm.org/D68312 ___ lldb-commits mailing list lldb-comm

[Lldb-commits] [PATCH] D68546: remove FILE* usage from ReportEventState() and HandleProcessEvent()

jingham added a comment. In D68546#1699390 , @labath wrote: > Thanks for weighing in, Jim. My responses are inline. > > In D68546#1698430 , @jingham wrote: > > > SBProcess::ReportEventState was introduced in r112221

[Lldb-commits] [PATCH] D68549: make ConstString allocate memory in non-tiny chunks

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. This makes sense to me. We may need to make this configurable for low-memory hosts at some point. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68549/new/

[Lldb-commits] [PATCH] D68631: ProcessInstanceInfoMatch: Don't match processes with no name if a name match was requested, take 2

JDevlieghere added a comment. Looks reasonable to me, but I'll defer to the people that actually know this code. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68631/new/ https://reviews.llvm.org/D68631 ___ lldb-commits mailing list lldb-co

[Lldb-commits] [PATCH] D68549: make ConstString allocate memory in non-tiny chunks

aprantl added a comment. I assume you experimented with many different values, and these are the best tradeoff? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68549/new/ https://reviews.llvm.org/D68549 ___ lldb-com

Re: [Lldb-commits] [PATCH] D67520: Add pretty printing of Clang "bitfield" enums

So I should see this on my machine, but I don’t... > On Oct 8, 2019, at 10:06 AM, Shafik Yaghmour via Phabricator > wrote: > > shafik added a comment. > > See the same break on green dragon as well: > http://lab.llvm.org:8080/green/view/LLDB/job/lldb-cmake/2360/testReport/LLDB/SymbolFile_Nati

[Lldb-commits] [PATCH] D68641: [LLDB] Fix for synthetic children memory leak

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Cool. May be nice to put a comment on the pointer why this is safe. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68641/new/ https://reviews.llvm.org/D6864

[Lldb-commits] [PATCH] D67520: Add pretty printing of Clang "bitfield" enums

shafik added a comment. See the same break on green dragon as well: http://lab.llvm.org:8080/green/view/LLDB/job/lldb-cmake/2360/testReport/LLDB/SymbolFile_NativePDB/s_constant_cpp/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67520/new/ https://

Re: [Lldb-commits] [PATCH] D67520: Add pretty printing of Clang "bitfield" enums

Taking a look > On Oct 8, 2019, at 9:47 AM, Stella Stamenova via Phabricator > wrote: > > stella.stamenova added a comment. > > It looks like this broke one of the tests on the Windows LLDB bot: > > http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/9628/steps/test/logs/stdio >

[Lldb-commits] [PATCH] D68605: ObjectFileMachO: Replace std::map with llvm::DenseMap (NFC)

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG8db229e28771: ObjectFileMachO: Replace std::map with llvm::DenseMap (NFC) (authored by aprantl). Herald added a project: L

[Lldb-commits] [lldb] r374084 - ObjectFileMachO: Replace std::map with llvm::DenseMap (NFC)

Author: adrian Date: Tue Oct 8 09:59:24 2019 New Revision: 374084 URL: http://llvm.org/viewvc/llvm-project?rev=374084&view=rev Log: ObjectFileMachO: Replace std::map with llvm::DenseMap (NFC) This makes parsing the symbol table of clang marginally faster. (Hashtable versus tree). Differential

[Lldb-commits] [PATCH] D68641: [LLDB] Fix for synthetic children memory leak

cameron314 added a comment. @aprantl No. A weak pointer would still fix the memory leak, but it's safe to use a raw pointer because we only reference objects which are in the same cluster as the synthetic children front-end itself. The other (leak-free) synthetic front-ends do this as well. We

[Lldb-commits] [PATCH] D67520: Add pretty printing of Clang "bitfield" enums

stella.stamenova added a comment. It looks like this broke one of the tests on the Windows LLDB bot: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/9628/steps/test/logs/stdio The bot was already red because of a change from yesterday, so you probably didn't get a notification.

[Lldb-commits] [PATCH] D68612: [CMake] Track test dependencies with add_lldb_test_dependency

jankratochvil added a comment. On Linux OS (Fedora 30 x86_64) with GIT monorepo: After rL374000 : #rm -rf * cmake ~/redhat/llvm-monorepo2/llvm/ -DCMAKE_BUILD_TYPE=Release -DLLVM_USE_LINKER=gold -DLLVM_ENABLE_PROJECTS="lldb;clang;lld" -DCMAKE_C_COMPILER=c

[Lldb-commits] [PATCH] D68609: Replace regex match with rfind (NFCish)

This revision was automatically updated to reflect the committed changes. Closed by commit rGea6377505435: Replace regex match with rfind (NFCish) (authored by aprantl). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D68609?vs=223695&id=223887#toc Repository:

[Lldb-commits] [PATCH] D68597: Replace static const StringRef with StringRef (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG917b8df0e531: Replace static const StringRef with StringRef (NFC) (authored by aprantl). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D68597?vs=223664&id=223886#toc R

[Lldb-commits] [PATCH] D68595: Remove constructor and unused function (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rGbde5a6a45a3c: Remove constructor and unused method (NFC). (authored by aprantl). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D68605: ObjectFileMachO: Replace std::map with llvm::DenseMap (NFC)

aprantl abandoned this revision. aprantl added a comment. Pavel correctly pointed out that this isn't necessarily correct, because the addresses could conflict with the Tombstone/Empty keys. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68605/new/ https://reviews.llvm.org/D68605 ___

[Lldb-commits] [lldb] r374081 - Replace static const StringRef with StringRef (NFC)

Author: adrian Date: Tue Oct 8 09:29:36 2019 New Revision: 374081 URL: http://llvm.org/viewvc/llvm-project?rev=374081&view=rev Log: Replace static const StringRef with StringRef (NFC) Differential Revision: https://reviews.llvm.org/D68597 Modified: lldb/trunk/source/Interpreter/OptionValueB

[Lldb-commits] [lldb] r374082 - Replace regex match with rfind (NFCish)

Author: adrian Date: Tue Oct 8 09:29:39 2019 New Revision: 374082 URL: http://llvm.org/viewvc/llvm-project?rev=374082&view=rev Log: Replace regex match with rfind (NFCish) This change is mostly performance-neutral since our regex engine is fast, but it's IMHO slightly more readable. Also, match

[Lldb-commits] [lldb] r374080 - Remove constructor and unused method (NFC).

Author: adrian Date: Tue Oct 8 09:29:33 2019 New Revision: 374080 URL: http://llvm.org/viewvc/llvm-project?rev=374080&view=rev Log: Remove constructor and unused method (NFC). Differential Revision: https://reviews.llvm.org/D68595 Modified: lldb/trunk/source/Plugins/ObjectFile/Mach-O/Object

[Lldb-commits] [PATCH] D68354: [platform process list] add a flag for showing the processes of all users

shafik added a comment. I reverted this change b/c the green dragon bots have been red for too long. When you fix the problem please make sure you add Differential Revision: https://reviews.llvm.org/D68354 to your commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[Lldb-commits] [PATCH] D68558: [Testsuite] Get rid of most of the recursive shared library Makefiles

This revision was automatically updated to reflect the committed changes. Closed by commit rG3fb4e49a68f5: [Testsuite] Get rid of most of the recursive shared library Makefiles (authored by friss). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68558/

[Lldb-commits] [lldb] r374077 - Revert "[platform process list] add a flag for showing the processes of all users"

Author: shafik Date: Tue Oct 8 09:24:28 2019 New Revision: 374077 URL: http://llvm.org/viewvc/llvm-project?rev=374077&view=rev Log: Revert "[platform process list] add a flag for showing the processes of all users" This reverts commit 080f35fb875f52c924ee37ed4d56a51fe7056afa. Conflicts:

[Lldb-commits] [lldb] r374076 - [Testsuite] Get rid of most of the recursive shared library Makefiles

Author: friss Date: Tue Oct 8 09:23:28 2019 New Revision: 374076 URL: http://llvm.org/viewvc/llvm-project?rev=374076&view=rev Log: [Testsuite] Get rid of most of the recursive shared library Makefiles Most of the secondary Makefiles we have are just a couple variable definitions and then an incl

[Lldb-commits] [PATCH] D68638: [lldb] Avoid resource leak

This revision was automatically updated to reflect the committed changes. Closed by commit rG6d7fb29914e3: [lldb] Avoid resource leak (authored by kwk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68638/new/ https://reviews.llvm.org/D68638 Files:

[Lldb-commits] [PATCH] D68641: [LLDB] Fix for synthetic children memory leak

aprantl added a comment. Disclaimer: I'm not familiar with this code. Would it be safe/better to store a weak pointer instead of a raw pointer? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68641/new/ https://reviews.llvm.org/D68641

[Lldb-commits] [lldb] r374071 - [lldb] Avoid resource leak

Author: kwk Date: Tue Oct 8 08:56:02 2019 New Revision: 374071 URL: http://llvm.org/viewvc/llvm-project?rev=374071&view=rev Log: [lldb] Avoid resource leak Summary: Before the pointer variable `args_dict` was assigned the result of an allocation with `new` and then `args_dict` is passed to `GetV

[Lldb-commits] [PATCH] D68614: [LLDB] Remove standalone build dep on llvm-strip

compnerd added inline comments. Comment at: lit/CMakeLists.txt:64 ) +if(NOT LLDB_BUILT_STANDALONE) + list(APPEND LLDB_TEST_DEPS llvm-strip) JDevlieghere wrote: > xiaobai wrote: > > why not `if(TARGET llvm-strip)`? I think that expresses the intent more > > c

[Lldb-commits] [PATCH] D68647: Simplify LZMA decoding by using ArrayRef::take_back

This revision was automatically updated to reflect the committed changes. kwk marked an inline comment as done. Closed by commit rG8970d88b65f0: Simplify LZMA decoding by using ArrayRef::take_back (authored by kwk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[Lldb-commits] [lldb] r374069 - Simplify LZMA decoding by using ArrayRef::take_back

Author: kwk Date: Tue Oct 8 08:43:29 2019 New Revision: 374069 URL: http://llvm.org/viewvc/llvm-project?rev=374069&view=rev Log: Simplify LZMA decoding by using ArrayRef::take_back Summary: Follow-up for D66791#inline-616303 Reviewers: labath Subscribers: lldb-commits Tags: #lldb Differentia

[Lldb-commits] [PATCH] D67520: Add pretty printing of Clang "bitfield" enums

This revision was automatically updated to reflect the committed changes. Closed by commit rG41ff39605ea1: Add pretty printing of Clang "bitfield" enums (authored by friss). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D67520?vs=223705&id=223877#toc Repositor

[Lldb-commits] [lldb] r374066 - Extract and simplify DumpEnumValue

Author: friss Date: Tue Oct 8 08:35:58 2019 New Revision: 374066 URL: http://llvm.org/viewvc/llvm-project?rev=374066&view=rev Log: Extract and simplify DumpEnumValue Modified: lldb/trunk/source/Symbol/ClangASTContext.cpp Modified: lldb/trunk/source/Symbol/ClangASTContext.cpp URL: http://ll

  1   2   >