We actually call the libc++abi guard functions even for const static StringRefs, so that patch actually saves us a lot.
> On Oct 7, 2019, at 11:43 PM, Adrian Prantl via Phabricator via lldb-commits > <lldb-commits@lists.llvm.org> wrote: > > aprantl created this revision. > aprantl added a reviewer: JDevlieghere. > > I just don't think that we are saving anything by making these StringRefs > global variables. The strings they reference are constants anyway. > > > https://reviews.llvm.org/D68597 > > Files: > lldb/source/Interpreter/OptionValueBoolean.cpp > lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionSourceCode.h > > lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp > lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp > > <D68597.223662.patch>_______________________________________________ > lldb-commits mailing list > lldb-commits@lists.llvm.org > https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
