clayborg added a comment.

In D68541#1700398 <https://reviews.llvm.org/D68541#1700398>, @llunak wrote:

> In D68541#1700359 <https://reviews.llvm.org/D68541#1700359>, @clayborg wrote:
>
> > It would be fine to remove the 'd' shortcut for detach and resume if we 
> > need to by moving this functionality up into the menu bar. Right now the 
> > Process menu has "Detach" only, so it might be good to first change the 
> > "Process" menu to have "Detach" or "Detach suspended".  I agree that 
> > accidentally hitting 'd' would be bad.
>
>
> Ok, I can try to do that. And 'k' for "Kill process" should probably move to 
> the menu as well.


Sounds fine to me!

> But another shortcut I'd like to change is 'o' for "Step out", as that one is 
> 'f' for "Finish" in gdb tui, and I'm rather used to that.

I am fine with this as well.

> Unless you'd be willing to accept a patch changing that, can you comment on 
> the idea of making the shortcuts configurable?

Configurability would be nice, happy to accept patches that implement that.

I created "gui" mode many many years ago and hoped people would jump in and 
start making patches, so I am very happy to see this patch and look forward to 
more. It won't take too much work for us to make "gui" mode really useful, just 
a bit of work!


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68541/new/

https://reviews.llvm.org/D68541



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to