llunak added a comment.

In D68541#1698127 <https://reviews.llvm.org/D68541#1698127>, @JDevlieghere 
wrote:

> Would it be possible to add a test for this? Maybe you can extend 
> `TestGuiBasic.py`.


I can, although to me it looks like a new test would be better. But first of 
all I wanted some feedback on this, as the patch in this form doesn't even 
compile. I'd actually personally prefer to just nuke the "Detach and resume 
process" shortcut, as I not only fail to see its usefulness but I also find it 
dangerous (I certainly don't want to hit it by mistake and ruin my debugging 
session), but then I assume there probably was a reason why it was added.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68541/new/

https://reviews.llvm.org/D68541



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to