Author: asmith
Date: Thu Sep 27 19:33:51 2018
New Revision: 343292
URL: http://llvm.org/viewvc/llvm-project?rev=343292&view=rev
Log:
[lldb] Remove an assertion in RichManglingContext::GetBufferRef() hit when
debugging a native x86 Windows process
Summary: A RichManglingContext constructed with a
zturner accepted this revision.
zturner added a comment.
This revision is now accepted and ready to land.
BTW, I wrote a demangler for Windows ABI that should be 100% complete modulo
bugs and can generate an AST that RichManglingContext should use. So it would
be interesting if someone decided
zturner added a comment.
Couple of options:
1. Can you give an example of before/after output?
2. Is the `size_t` change related?
3. Can you use -U99 in the future when generating patches?
Repository:
rLLDB LLDB
https://reviews.llvm.org/D52627
_
zturner added a comment.
s/options/comments/
Repository:
rLLDB LLDB
https://reviews.llvm.org/D52627
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
zturner accepted this revision.
zturner added a comment.
Can you change the description of the patch before submitting it? It's hard to
understand why the change does what the description says it does, because the
description mentions 3 types of chars but the patch only handles 1. I would
jus
aprantl added inline comments.
Comment at: packages/Python/lldbsuite/test/macosx/debug_map/Makefile:22
+# Everything goes as .o files directly to the linker
+C_SOURCES :=
+
dexonsmith wrote:
> aprantl wrote:
> > same here, just remove it
> I haven't read the ful
dexonsmith added inline comments.
Comment at: packages/Python/lldbsuite/test/macosx/debug_map/Makefile:22
+# Everything goes as .o files directly to the linker
+C_SOURCES :=
+
aprantl wrote:
> same here, just remove it
I haven't read the full patch to see if thi
asmith accepted this revision.
asmith added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rLLDB LLDB
https://reviews.llvm.org/D52468
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cg
asmith created this revision.
asmith added reviewers: zturner, aleksandr.urakov, lldb-commits.
Repository:
rLLDB LLDB
https://reviews.llvm.org/D52627
Files:
source/Plugins/ExpressionParser/Clang/ClangUserExpression.cpp
source/Plugins/ExpressionParser/Clang/ClangUserExpression.h
source/Sy
asmith created this revision.
asmith added reviewers: aleksandr.urakov, zturner, lldb-commits.
Herald added a subscriber: erik.pilkington.
A RichManglingContext constructed with an invalid demangled name or with a
demangled function name without any context will have an empty context. This
trigg
aprantl added inline comments.
Comment at: packages/Python/lldbsuite/test/macosx/debug_map/Makefile:13
+# Set inputs empty, if not passed from the Python script.
+CFLAGS ?=
+LDFLAGS ?=
This is a noop. You can remove it without affecting anything.
==
zturner added a subscriber: aleksandr.urakov.
zturner added a comment.
It requires a lot of work (nobody has started porting it). lldb-server
exists on other platforms but it basically needs a full port to Windows. It
doesn’t use the same process plugin, but it would instead use a different
plugin
aleksandr.urakov added a comment.
I didn't know about such a priority, thanks... But in this case `lldb-server`
also must be able to allocate, read and write in a debuggee. Doesn't it use the
process plugin for that? Or somehow duplicates this functionality?
I have made some work on expressions
sgraenitz added inline comments.
Comment at: source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:468
// situation. Check the line tables and build the arange table from this.
SymbolContext sc;
sc.comp_unit = dwarf->GetCompUnitForDWARFCompUnit(this);
sgra
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good then as long as all tests pass on Darwin.
https://reviews.llvm.org/D52375
___
lldb-commits mailing list
lldb-commits@lists.llvm.or
Author: gclayton
Date: Thu Sep 27 10:55:36 2018
New Revision: 343243
URL: http://llvm.org/viewvc/llvm-project?rev=343243&view=rev
Log:
Fixes for GDB remote packet disassembler:
- Add latency timings to GDB packet log summary if timestamps are on log
- Add the ability to plot the latencies for eac
sgraenitz added inline comments.
Comment at: source/Symbol/Symtab.cpp:520
+ return false;
+}
+
clayborg wrote:
> This function is still pretty specific. Any comments on my above inlined
> comment?
Yes absolutely, but the same holds for most functions around her
Author: gclayton
Date: Thu Sep 27 10:45:14 2018
New Revision: 343242
URL: http://llvm.org/viewvc/llvm-project?rev=343242&view=rev
Log:
Add an interactive mode to BSD archive parser.
Modified:
lldb/trunk/examples/python/bsd.py
Modified: lldb/trunk/examples/python/bsd.py
URL:
http://llvm.org
clayborg added a comment.
We really should be making a lldb-server that works on windows instead of
making a native windows process plug-in that only works on windows. That will
allow remote debugging to windows machines instead of requiring a local
connection. It will also allows debug session
clayborg added inline comments.
Comment at: source/Symbol/Symtab.cpp:520
+ return false;
+}
+
This function is still pretty specific. Any comments on my above inlined
comment?
https://reviews.llvm.org/D52375
___
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Just a few fixes. Looking good.
Comment at: include/lldb/lldb-enumerations.h:643-660
+ eSectionTypeDWARFDebugAbbrevDwo,
eSectionTypeDWARFDebugAddr,
eSect
> On May 14, 2018, at 6:36 AM, Pavel Labath via Phabricator
> wrote:
>
> labath added a comment.
>
> In https://reviews.llvm.org/D46810#1097740, @jankratochvil wrote:
>
>> In https://reviews.llvm.org/D46810#1097503, @labath wrote:
>>
>>> (If that is true, then I think this is workable, but
aleksandr.urakov updated this revision to Diff 167338.
aleksandr.urakov added a comment.
Clang-format patch.
https://reviews.llvm.org/D52618
Files:
lit/Expr/TestIRMemoryMap.test
lit/Expr/TestIRMemoryMapWindows.test
source/Plugins/Process/Windows/Common/ProcessWindows.cpp
source/Plugins/
clayborg accepted this revision.
clayborg added inline comments.
This revision is now accepted and ready to land.
Comment at: tools/driver/Driver.cpp:71
typedef struct {
uint32_t usage_mask; // Used to mark options that can be used together. If
(1
tatyana
aleksandr.urakov created this revision.
aleksandr.urakov added reviewers: zturner, asmith, stella.stamenova, labath.
aleksandr.urakov added a project: LLDB.
Herald added subscribers: lldb-commits, teemperor, abidh.
This patch adds a basic implementation of `DoAllocateMemory` and
`DoDeallocateMemo
sgraenitz updated this revision to Diff 167335.
sgraenitz added a comment.
Add test for breakpoint resolution in DWARF debug map, exercising different LTO
and line-tables-only combinations
https://reviews.llvm.org/D52375
Files:
include/lldb/Symbol/Symtab.h
packages/Python/lldbsuite/test/ma
grimar updated this revision to Diff 167287.
grimar added a comment.
Herald added subscribers: arichardson, emaste.
Herald added a reviewer: espindola.
- Addressed review comments.
https://reviews.llvm.org/D52403
Files:
include/lldb/lldb-enumerations.h
lit/Breakpoint/Inputs/single-file-spli
jankratochvil added a comment.
@xbolva00 As you gave no reprodudcer it would be good to know how those two
`DWARFDebugInfoEntry`s differ. Without that I can look at it more only next
week - travelling.
Repository:
rL LLVM
https://reviews.llvm.org/D46810
__
tatyana-krasnukha added inline comments.
Comment at: tools/driver/Driver.cpp:71
typedef struct {
uint32_t usage_mask; // Used to mark options that can be used together. If
(1
This type is duplicated here to not break the encapsulation of lldb's private
t
tatyana-krasnukha created this revision.
tatyana-krasnukha added reviewers: clayborg, zturner.
tatyana-krasnukha added a project: LLDB.
Herald added a subscriber: lldb-commits.
Removed unused static arrays from headers, removed sentinel entry from
OptionDefinition array in Driver.cpp.
Repositor
This revision was automatically updated to reflect the committed changes.
Closed by commit rLLDB343191: Refactor ClangUserExpression::GetLanguageForExpr
(authored by teemperor, committed by ).
Repository:
rLLDB LLDB
https://reviews.llvm.org/D52561
Files:
source/Plugins/ExpressionParser/Clan
Author: teemperor
Date: Thu Sep 27 03:12:54 2018
New Revision: 343191
URL: http://llvm.org/viewvc/llvm-project?rev=343191&view=rev
Log:
Refactor ClangUserExpression::GetLanguageForExpr
Summary:
The `ClangUserExpression::GetLanguageForExpr` method is currently a big
source of sadness, as it's name
xbolva00 added inline comments.
Comment at: source/Symbol/SymbolFile.cpp:160
+ // guarantee correctness.
+ assert(std::async(
+ std::launch::async,
lldbassert?
https://reviews.llvm.org/D52543
___
lldb
JDevlieghere updated this revision to Diff 167248.
JDevlieghere added a comment.
- Add assertions per Greg's suggestion.
https://reviews.llvm.org/D52543
Files:
include/lldb/Symbol/SymbolFile.h
source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
source/Symbol/SymbolFile.cpp
Index: source/
JDevlieghere added a comment.
My first observations:
- We call `ResolveTypeUID` without going through the symbol vendor (similar to
`GetDeclContextForUID` in the stack trace). This is easy to fix, just add
locking to these functions.
- The module in the symbol vendor is different from the one i
xbolva00 accepted this revision.
xbolva00 added a comment.
This revision is now accepted and ready to land.
looks fine, thanks :)
Repository:
rLLDB LLDB
https://reviews.llvm.org/D52561
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
htt
xbolva00 added inline comments.
Comment at: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:179
+ if (!m_die_array.empty()) {
+lldbassert(!m_first_die || m_first_die == m_die_array.front());
+m_first_die = m_die_array.front();
xbolva00 wrote:
>
xbolva00 added inline comments.
Comment at: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:179
+ if (!m_die_array.empty()) {
+lldbassert(!m_first_die || m_first_die == m_die_array.front());
+m_first_die = m_die_array.front();
@jankratochvil is
This revision was automatically updated to reflect the committed changes.
Closed by commit rL343181: Replace pointer to C-array of PropertyDefinition
with llvm::ArrayRef (authored by tkrasnukha, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.ll
Author: tkrasnukha
Date: Thu Sep 27 00:11:58 2018
New Revision: 343181
URL: http://llvm.org/viewvc/llvm-project?rev=343181&view=rev
Log:
Replace pointer to C-array of PropertyDefinition with llvm::ArrayRef
Differential Revision: https://reviews.llvm.org/D52572
Modified:
lldb/trunk/include/l
Author: jdevlieghere
Date: Wed Sep 26 23:59:15 2018
New Revision: 343180
URL: http://llvm.org/viewvc/llvm-project?rev=343180&view=rev
Log:
[target] Fix typo and give bool a default value
This addresses Stella's review feedback in D51859.
Modified:
lldb/trunk/source/Target/Target.cpp
Modifie
41 matches
Mail list logo
