aprantl added inline comments.
================ Comment at: packages/Python/lldbsuite/test/macosx/debug_map/Makefile:13 +# Set inputs empty, if not passed from the Python script. +CFLAGS ?= +LDFLAGS ?= ---------------- This is a noop. You can remove it without affecting anything. ================ Comment at: packages/Python/lldbsuite/test/macosx/debug_map/Makefile:22 +# Everything goes as .o files directly to the linker +C_SOURCES := + ---------------- same here, just remove it ================ Comment at: packages/Python/lldbsuite/test/macosx/debug_map/Makefile:24 + +MAKE_DSYM := NO +SHELL = /bin/sh -x ---------------- If you do this, then you should also the NO_DEBUG_INFO_TESTCASE=True otherwise you're going to build dwarf and dsym variants of the test and they will be identical. ================ Comment at: packages/Python/lldbsuite/test/macosx/debug_map/Makefile:25 +MAKE_DSYM := NO +SHELL = /bin/sh -x + ---------------- this was for debugging? Also remove it ================ Comment at: packages/Python/lldbsuite/test/macosx/debug_map/Makefile:30 +main.o: main.c + $(CC) -c -g $(CFLAGS) $(CFLAGS_MAIN) -o main.o $(SRCDIR)/main.c + ---------------- ` $(CC) -c $(CFLAGS) $(CFLAGS_MAIN) -o $@ $^` -g should already be part of CFLAGS, no? ================ Comment at: packages/Python/lldbsuite/test/macosx/debug_map/Makefile:42 +a.out: main.o cu1.o cu2.o cu3.o + $(LD) main.o cu1.o cu2.o cu3.o -L. $(LDFLAGS) -o a.out ---------------- ` $(LD) $^ -L. $(LDFLAGS) -o a.out` or even shorter, remove the entire line and just declare the dependencies, because the default rule from Makefile.rules will kick in then. https://reviews.llvm.org/D52375 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
