sgraenitz added inline comments.

================
Comment at: source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:468
     // situation. Check the line tables and build the arange table from this.
     SymbolContext sc;
     sc.comp_unit = dwarf->GetCompUnitForDWARFCompUnit(this);
----------------
sgraenitz wrote:
> @clayborg Any idea how to reproduce this code path? I expected test_lt as 
> below would do, but debug_aranges is read from DIE even there. Is it (only) 
> for backwards compatibility?
> ```
> clang -c -gline-tables-only -o main_lt.o main.c
> clang -c -gline-tables-only -o cu1_lt.o cu1.c
> clang -gline-tables-only main_lt.o cu1_lt.o -o test_lt
> ```
> 
Found repros in the test suite. Some _dwarf and _gmodule variants seem to be 
failing due to my fix. Will investigate and post changes if necessary. Thanks 
for the review.


https://reviews.llvm.org/D52375



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to