dexonsmith added inline comments.
================ Comment at: packages/Python/lldbsuite/test/macosx/debug_map/Makefile:22 +# Everything goes as .o files directly to the linker +C_SOURCES := + ---------------- aprantl wrote: > same here, just remove it I haven't read the full patch to see if this is relevant, but my maybe-out-of-date-Makefile-fu says this is not no-op. It defines `C_SOURCES` as a variable, as opposed to a function-like macro (which would be `C_SOURCES =`, no colon). IIRC, with the former, any changes to `C_SOURCES` (like `C_SOURCES += ...`) are evaluated immediately when it's a variable, lazily (on use) when it's a macro. Usually the behaviour you want is a variable. https://reviews.llvm.org/D52375 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
